Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp546837ybh; Wed, 18 Mar 2020 04:53:07 -0700 (PDT) X-Google-Smtp-Source: ADFU+vun83eS26hFD8uARCY/vmsmQTv3ivYQ+1sfb8FGKdUei/wtVDeb5j6PbgGAF0z802zmfxTY X-Received: by 2002:a9d:5181:: with SMTP id y1mr3472309otg.199.1584532387409; Wed, 18 Mar 2020 04:53:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584532387; cv=none; d=google.com; s=arc-20160816; b=nB0dlg3KErgOrIw7Wxu0vWtdSc5/BG97EYiapz175idLc7IJVhFXKUCPCpdNyR5Pfk o2Uf9scaEYfP+8ZoSIgal8CUbB28+4nEmfPgJPgIF1uu4vfxJWCxdHDiQhFPqD0uPsBy 5FXKTuSXyvd6cnjA8sHHCa/hvpuk6n0hZut3AM0puqM+hlP45fLvZ17tVo4hb8fxR6Cw uK/23xNLkzXJ+KEzqPd9l+KkIA0o1KTAE0MyCJ6bA47Oyzd/fdBoGfEoA4VC6retLD6L OpfGyQSCTlxm1K3MruWlHQWF9PPb0wx9hhg3byOgu/Eh+o0ZakdlpystGT9eCNu3O/is xFsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=OmpuvAUt4zS+7Mh5h93SfB2Widczqav0dKnzzO20xSA=; b=RBufb6VI+YdZeCPMl5dKn3TyOqXkqbY5215v+8CE8ZafI8vMl1PdqihDLM/ajVClBP QXs7oRxX+6ZeZs8c0aM6Oghj7Qb65OYdJVvbb5clPD3TtJRsS/kNcs1n5vCPcUrviGhK fAQYVJsvWHnhv1fCmw8vTwkorhYTWaqebc6XwFP3ER2yppTmx6a7nORIY9JU2uOsJpV4 oXt7VLecOZfR7fGR1Eh8bb9GlX4rO20prR4Wc4azVDFt5DPbjZ3F2FjgoQ6FM3eP9NfI Izm66myWyjGswUOT/GktpaRXRFKhc8yvSgsjHldfZOZVIg9pHKhpilX0xIT/ytW+Cfdq j6Qw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=UA5oJmRW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i6si3658778otk.133.2020.03.18.04.52.55; Wed, 18 Mar 2020 04:53:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=UA5oJmRW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727009AbgCRLvo (ORCPT + 99 others); Wed, 18 Mar 2020 07:51:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:60968 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726586AbgCRLvo (ORCPT ); Wed, 18 Mar 2020 07:51:44 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 194272076D; Wed, 18 Mar 2020 11:51:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584532303; bh=rs4bW0ZkVYcjeCL/A3Dq7xVlHy1e1mmqD+dUYRHTOV4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UA5oJmRW1Y3nkwrN+PxYHwOUwy7KCIYjMDZpxhQ7+8l7cn585mnhCDiCwkUg2uNqj 1M9zGCSCFbixeD2m6QHFMuJojACUIlZ8IGdXEbzT7iuMdV3r9/4AgZosWCL510hsHf G1yXGg9Gp1cOWzeFnTaUcV5nzK0asQVaoRwE25WQ= Date: Wed, 18 Mar 2020 12:51:41 +0100 From: Greg KH To: Jolly Shah Cc: ard.biesheuvel@linaro.org, mingo@kernel.org, matt@codeblueprint.co.uk, sudeep.holla@arm.com, hkallweit1@gmail.com, keescook@chromium.org, dmitry.torokhov@gmail.com, michal.simek@xilinx.com, rajanv@xilinx.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Rajan Vaja Subject: Re: [PATCH v3 20/24] firmware: xilinx: Add APIs to read/write GGS/PGGS registers Message-ID: <20200318115141.GB2472686@kroah.com> References: <1583538452-1992-1-git-send-email-jolly.shah@xilinx.com> <1583538452-1992-21-git-send-email-jolly.shah@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1583538452-1992-21-git-send-email-jolly.shah@xilinx.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 06, 2020 at 03:47:28PM -0800, Jolly Shah wrote: > --- a/include/linux/firmware/xlnx-zynqmp.h > +++ b/include/linux/firmware/xlnx-zynqmp.h > @@ -105,6 +105,10 @@ enum pm_ioctl_id { > IOCTL_GET_PLL_FRAC_MODE, > IOCTL_SET_PLL_FRAC_DATA, > IOCTL_GET_PLL_FRAC_DATA, > + IOCTL_WRITE_GGS, > + IOCTL_READ_GGS, > + IOCTL_WRITE_PGGS, > + IOCTL_READ_PGGS, You do not have explicit numbers here? Bold :) greg k-h