Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp640916ybh; Wed, 18 Mar 2020 06:33:38 -0700 (PDT) X-Google-Smtp-Source: ADFU+vvRqnnoSvIjODVqynZkx1gW/dPJvDw0EmvvqbKcKeWMy3uzeAG1QQkICPaCFfhKA7gxOUz3 X-Received: by 2002:a9d:6457:: with SMTP id m23mr3932466otl.162.1584538418221; Wed, 18 Mar 2020 06:33:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584538418; cv=none; d=google.com; s=arc-20160816; b=sggQOohZM90Nsc8m3EFOjw7kStuqkTfXPW4m5DXDH3fhWH7U98TsKJ0MK9BPeRE/5/ Jg3hNeg2SsurHUsgQPpn1t0/x31VbDBSk10XMZAlUZKaXioL66xPkiZmU7OryL7jyRIi 4TY0L6WNsJ3KXZEl15WJX2HEwEO6IVy1Ih1v6oI4RycU4Hje6L20eaJJfPfVqw8ErfTq L9l9kViJZKzIPB+WfQ4itmk6Ylr7rnyL1+sYIlBurJZAwmKge7DexvV34x2uXebrpfHE l4SISY6rok7N/QIWeoiZLlSgbqQgffBYy6OW6nLK+DCf2KNHgJDTDBNG8fmCXi3glhHa WQ2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=G84lL0LtzEaL0veVBFRjgIHIWAwVKkwsmezTFwoIHwc=; b=gTKCOjLgppdFuOH69hdkUQOiBCj7JYsLzy+bidg7/S0juyW6yWP8CXJOIoNxBrfs1J V4XjdZAM6mCkPOBT7WadKoHz6SauwhdbNl3RpbxkBRDGG+yRYEUtiZygfFgJuN20418y z74r/KonItMTfN9Od9gqE1PzgY0Wne0l1RU1QHB0MuD4HbH79Y2bWoZDiQQZpgrfV19M KcM/cpltoPGtVu/UgFctOmMn11pfwHzggX9W4JqkXTdf7ndMJL0sUU5F8xs2wTkTpMib g7+uQj1bzevUWCq53rT1Vs5+iA6rqA/qBd1YG/fGH5FrkSEEGhIz2zVWcHRT1YKKIsy1 Yy4A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@c-s.fr header.s=mail header.b=XYtuqdKJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j1si3449175otp.318.2020.03.18.06.33.25; Wed, 18 Mar 2020 06:33:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@c-s.fr header.s=mail header.b=XYtuqdKJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726973AbgCRNbV (ORCPT + 99 others); Wed, 18 Mar 2020 09:31:21 -0400 Received: from pegase1.c-s.fr ([93.17.236.30]:38141 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726774AbgCRNbU (ORCPT ); Wed, 18 Mar 2020 09:31:20 -0400 Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 48j9sx40glz9v1vc; Wed, 18 Mar 2020 14:31:17 +0100 (CET) Authentication-Results: localhost; dkim=pass reason="1024-bit key; insecure key" header.d=c-s.fr header.i=@c-s.fr header.b=XYtuqdKJ; dkim-adsp=pass; dkim-atps=neutral X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id gQE5nnNjFsjF; Wed, 18 Mar 2020 14:31:17 +0100 (CET) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 48j9sx2wRxz9v1vY; Wed, 18 Mar 2020 14:31:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=c-s.fr; s=mail; t=1584538277; bh=G84lL0LtzEaL0veVBFRjgIHIWAwVKkwsmezTFwoIHwc=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=XYtuqdKJfkDzgOIYvHzljLu5MuAZuNLqYbq/2GyY4aFFvNS3/PYaHG3Hn92Yd4hty daB23nJXA5GEbk8J3vAS/pKkGE/8ZaQ1E2wCiSBk8BCoyoWnubsQCpeJAyBASccwDl XEw+boI+iSQSpSuY3REOY4mBwjroCqcZzFM9txgM= Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id AFE0F8B78A; Wed, 18 Mar 2020 14:31:18 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id LmKV_rQvLy0e; Wed, 18 Mar 2020 14:31:18 +0100 (CET) Received: from [192.168.4.90] (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id B97EE8B75B; Wed, 18 Mar 2020 14:31:17 +0100 (CET) Subject: Re: [PATCH 14/15] powerpc/watchpoint/xmon: Don't allow breakpoint overwriting To: Ravi Bangoria Cc: mpe@ellerman.id.au, mikey@neuling.org, apopple@linux.ibm.com, paulus@samba.org, npiggin@gmail.com, naveen.n.rao@linux.vnet.ibm.com, peterz@infradead.org, jolsa@kernel.org, oleg@redhat.com, fweisbec@gmail.com, mingo@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <20200309085806.155823-1-ravi.bangoria@linux.ibm.com> <20200309085806.155823-15-ravi.bangoria@linux.ibm.com> <56ee9190-2363-efbe-fd94-0b42194e6586@linux.ibm.com> From: Christophe Leroy Message-ID: <79b77ffc-afac-b8ff-20d8-35a48860e526@c-s.fr> Date: Wed, 18 Mar 2020 14:31:18 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <56ee9190-2363-efbe-fd94-0b42194e6586@linux.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 18/03/2020 à 13:37, Ravi Bangoria a écrit : > > > On 3/17/20 4:40 PM, Christophe Leroy wrote: >> >> >> Le 09/03/2020 à 09:58, Ravi Bangoria a écrit : >>> Xmon allows overwriting breakpoints because it's supported by only >>> one dawr. But with multiple dawrs, overwriting becomes ambiguous >>> or unnecessary complicated. So let's not allow it. >> >> Could we drop this completely (I mean the functionnality, not the patch). > > Not sure I follow. Isn't the same thing I'm doing? > Yes, I think I misunderstood the patch. That seems ok. Christophe