Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp672453ybh; Wed, 18 Mar 2020 07:07:09 -0700 (PDT) X-Google-Smtp-Source: ADFU+vs7y2EkzMLx69TSzQNWcd+rUGcOL9teTv4Q8bsT+dHOJu1KODHEBS96mgwqGq8JeBhj9BJ3 X-Received: by 2002:aca:ab16:: with SMTP id u22mr3090520oie.133.1584540428773; Wed, 18 Mar 2020 07:07:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584540428; cv=none; d=google.com; s=arc-20160816; b=x37jfj41eVTuJi55znUth0X6huovEJ0ovKmsMUOWq7mT1wBaJBnN3D6HSOOrys2Aca 9NQ6NfRA8smVXF6RoowYMZepe/lC0HkVIde3xWkdyxpGszPYpGKg0RzS4XeI+/25mszj TpRKUssQDucRr0dkCyYdghVoJT44/ddmTIhjIS6RZmPyAOOzsh8XdlyC8By/xNlosrFd Fj0Y7VkZHoijS6o/WBJ87aWnYp/3qUK59maEq1bzKfKZA//z0cMLnPfDwg+JvYAQZ96i S4G3gK5gqY4QB52R99g17/A1cTdiaUXHk4AUKiWOd0t1sWhkGvCArSdO26tblPAi5wqJ YZMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=7hngLHjvJQH18pXVNtvhQIhSbo94lmhbQP/T7HQ3TDk=; b=GcmO1AVDVejeR2EVNAqj4r3FGWQQCVQ/arGiwn+VDYucBEw3nC7BLrGUhI6XNl0s5o 7WWglNOVK8KkFa68WdZHYJvxAQTek6Wff0wOXATff9AEo1uYFvhdppSSVrcMjvZJEE6h boBjwTTG/FwHUOTxJb5aaJRS0nGNhPSpX4sBY/3Z/pCBBFMWrsFY3Y8DREWORgMJXP8p /eiuX0OVKz2uibK454bNIB7hU9exxxq0sS8+N9CDxiaKX4TtklwchAAYq8y4vya5+CGA xp+QmSkRr9ajJzhEvp8LFERz/M5BQkXyG0FzjAno1lqb4U+2XsbrETsB7gLkCr+lFVxj P3ig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=PmLN5H0U; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q137si3517382oic.139.2020.03.18.07.06.52; Wed, 18 Mar 2020 07:07:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=PmLN5H0U; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726738AbgCROGa (ORCPT + 99 others); Wed, 18 Mar 2020 10:06:30 -0400 Received: from us-smtp-delivery-74.mimecast.com ([216.205.24.74]:23814 "EHLO us-smtp-delivery-74.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726893AbgCROGa (ORCPT ); Wed, 18 Mar 2020 10:06:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584540389; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=7hngLHjvJQH18pXVNtvhQIhSbo94lmhbQP/T7HQ3TDk=; b=PmLN5H0U0fuooW0Ub3Lp7aAajWxYgFssKdUyb4HieIO4fKfVPluHieYWnqDlFvkdgKqdyZ EN9rX1+ZrIChpgjdfZvXtxeV3epeY20EsyVDW7XYcaQhEpIXgRlXzDGt34xxf641KVDkgi yrSVBXLeBDdrkRD1kLI24Z37GLYo6JM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-467-bHqky28iMf6qoNliq6lNgg-1; Wed, 18 Mar 2020 10:06:27 -0400 X-MC-Unique: bHqky28iMf6qoNliq6lNgg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C008A8014D1; Wed, 18 Mar 2020 14:06:26 +0000 (UTC) Received: from hp-dl360pgen8-07.khw2.lab.eng.bos.redhat.com (hp-dl360pgen8-07.khw2.lab.eng.bos.redhat.com [10.16.210.135]) by smtp.corp.redhat.com (Postfix) with ESMTP id 799255C1D8; Wed, 18 Mar 2020 14:06:23 +0000 (UTC) From: Jarod Wilson To: linux-kernel@vger.kernel.org Cc: Jarod Wilson , Moshe Levi , Marcelo Ricardo Leitner , netdev@vger.kernel.org Subject: [PATCH net] ipv6: don't auto-add link-local address to lag ports Date: Wed, 18 Mar 2020 10:06:05 -0400 Message-Id: <20200318140605.45273-1-jarod@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Bonding slave and team port devices should not have link-local addresses automatically added to them, as it can interfere with openvswitch being able to properly add tc ingress. Reported-by: Moshe Levi CC: Marcelo Ricardo Leitner CC: netdev@vger.kernel.org Signed-off-by: Jarod Wilson --- net/ipv6/addrconf.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 46d614b611db..aed891695084 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c @@ -3296,6 +3296,10 @@ static void addrconf_addr_gen(struct inet6_dev *id= ev, bool prefix_route) if (netif_is_l3_master(idev->dev)) return; =20 + /* no link local addresses on bond slave or team port devices */ + if (netif_is_lag_port(idev->dev)) + return; + ipv6_addr_set(&addr, htonl(0xFE800000), 0, 0, 0); =20 switch (idev->cnf.addr_gen_mode) { --=20 2.20.1