Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp790527ybh; Wed, 18 Mar 2020 09:10:21 -0700 (PDT) X-Google-Smtp-Source: ADFU+vtrr4IFLNNYnxsSUd165rJoNeNe6AkSCMm2l2kXxgrSyhRAuMTzPYHsKG6JucXam7bhR9Dx X-Received: by 2002:a05:6830:3090:: with SMTP id f16mr4356143ots.211.1584547821443; Wed, 18 Mar 2020 09:10:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584547821; cv=none; d=google.com; s=arc-20160816; b=FkrR9yr10+Ll5J/k0ATYQ8Y4xzSCIVmN16ZkE3SzaTsOBZdc88X1B+WByzjJB5jfzZ Xm7Cdn4h3MJRvFgaWGZfqPV89sCfAcvGEzXJOhqhlUo+y/mp/vFFbC2hf8uJ2z/5pVXY YCWRHrw2hHn5PpaK/a+ObM/1x23kG1iIwWAx3UTn3vtsSDAxQWnqzONTq8aydikL1+YZ TdwfCiFGSQYmoTrfIUaXLJpMvBsqgsemUBiQE0IfcrRRHOIf6ank4Dzv/zUxtHyZ6VRh uM3OnIvZj4UcfJKbXo2LuRnSPmjCS/gYp9igkj0W6CRq1TQTFX4UTo+MISaFY8I+cjpX 5zyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=TLgXmNozvDp9BcNHyqTO6GFcWWQD94IGFBX9Q7VenQE=; b=0+hCqgYBvSpLhl76Jqfw3TaWtBaPAvnvSb55C41PLTNr+qC4EOV+QV+sfYtGNuV6oD LBZxrOA5TTrGLUSCy9Df6Y5QBcQwzGLoCsjOxNk1yzVCnnDklEqOo/4SWnvNNhvAV/oJ v8+mVY246VUIv46M5nAdlOoV1meXKiPNncmXDCzAzjFfPS5B+kiDJz6cCTEzizJ4hXd4 EXpkIbQsJoLxbwnhqiDw2KVO/WvsvgQCJilK3bxOi2AsSg6IZo5Ae+v48ICmYQNPyW75 kr7PS969mJJxA2K5nTFzZV8WpLxJDwWvnqZ6rKf0GXi2zO4MGDMX1DcOhpL1cW2V1hEH oRZQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=bLFpCGM+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n9si3371834ota.103.2020.03.18.09.10.05; Wed, 18 Mar 2020 09:10:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=bLFpCGM+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726954AbgCRQI0 (ORCPT + 99 others); Wed, 18 Mar 2020 12:08:26 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:38267 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726817AbgCRQIZ (ORCPT ); Wed, 18 Mar 2020 12:08:25 -0400 Received: by mail-wm1-f68.google.com with SMTP id l20so86916wmi.3 for ; Wed, 18 Mar 2020 09:08:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=TLgXmNozvDp9BcNHyqTO6GFcWWQD94IGFBX9Q7VenQE=; b=bLFpCGM+/IwvHNaiAYAKTJ9y34pV6nWf2+rHEQSvy03mgzPEO4Eu2TClVo3U1ojGo+ MW2vMGAJ91RENQgmwvOOduFqC618kHgdsyCOl+mRbmpUE5s9R7O6jYJjlhDxSGveezrh tDWD7PhBoKOyFK4YOJ9xCfHH8mOxbszaAOCnzvWfA6gjEw7EeD+F1vPbQ28qBxFlt0/G zUMhM0AUHeD1bh29CBy3NgN9vMqxg7I2QtnzNw3LCgukbTeifMPqb1YktEryS5HVYhKq rT9vp0Ern543LnaI71qAkkJ+va1joW7gaRYjSsKkXfaTRkS+PwGG51CV0MBTwJlsCr/W 60mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=TLgXmNozvDp9BcNHyqTO6GFcWWQD94IGFBX9Q7VenQE=; b=UyDfX/BeWFtJLcThKlXOJteM56ARFwfbK+I7BOthFqaAPvrTLN0Wv/GrZPSWKIS0Gk tzT1NapL6UP0/nXCqH9de1Wp7S5oSp9TKnVSmrZsC54pAaM6FXqblvoNFw5VJ6qVfdyO GcA0M4xi1wz8bisRCs23hLhukZpOjP5RL+yeF194aMJUsIUxBWrrXY7/PxWvNNZ8y6Nm xlzdT3OqoBMwwzcNtxMULeF9i6EBC6/dXnK55zmzKZzZJo4ZzEJUaoQ9jntvkTEWjfA+ xwPt35t8yNmjOjnrpocIMrcxAdK26O9ylwj6Hy4Tx4hRZqALx8mW/I1vgQ6/Qz8A7bDO F7nQ== X-Gm-Message-State: ANhLgQ1JdnO21VKzVJAVWlUaHFSYudbiNIwEUZIIElEDH80m3RTaouXP 8VfYYgLALF2NG2u1H2Zo6sofXw== X-Received: by 2002:a1c:b154:: with SMTP id a81mr5935380wmf.175.1584547703944; Wed, 18 Mar 2020 09:08:23 -0700 (PDT) Received: from [192.168.86.34] (cpc89974-aztw32-2-0-cust43.18-1.cable.virginm.net. [86.30.250.44]) by smtp.googlemail.com with ESMTPSA id h16sm9957414wrr.48.2020.03.18.09.08.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Mar 2020 09:08:21 -0700 (PDT) Subject: Re: [PATCH v5 1/1] nvmem: Add support for write-only instances To: Nicholas Johnson , "linux-kernel@vger.kernel.org" Cc: Mika Westerberg References: From: Srinivas Kandagatla Message-ID: <1057389f-2bd0-909c-93c9-21a12af90660@linaro.org> Date: Wed, 18 Mar 2020 16:08:20 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/03/2020 15:20, Nicholas Johnson wrote: > There is at least one real-world use-case for write-only nvmem > instances. Refer to 03cd45d2e219 ("thunderbolt: Prevent crash if > non-active NVMem file is read"). > > Add support for write-only nvmem instances by adding attrs for 0200. > > Change nvmem_register() to abort if NULL group is returned from > nvmem_sysfs_get_groups(). > > Return NULL from nvmem_sysfs_get_groups() in invalid cases. > > Signed-off-by: Nicholas Johnson > --- > drivers/nvmem/core.c | 10 +++++-- > drivers/nvmem/nvmem-sysfs.c | 56 +++++++++++++++++++++++++++++++------ > 2 files changed, 56 insertions(+), 10 deletions(-) Applied thanks, --srini