Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp799510ybh; Wed, 18 Mar 2020 09:20:03 -0700 (PDT) X-Google-Smtp-Source: ADFU+vst9mgMJ++vn2n0MZ7gaVwmqxARr3PDGZEWEDGoJjQf8yN3eYRSkQ6mjxCKJIAVcbMuFbGa X-Received: by 2002:aca:a94a:: with SMTP id s71mr3636761oie.152.1584548403113; Wed, 18 Mar 2020 09:20:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584548403; cv=none; d=google.com; s=arc-20160816; b=JEnozjvDD8uMepcnszNy7D7SswJVdMskwu1359xXhNKdm2n/7iM8hS7DzbF2k035zb hy2Po/r8EIsU6JNxo28nMVHjE5pAS14/jqNke9ZtS0QOCIdw1k7v31O259PRez3EfzLR M0ORGX54XT1DeSNmie9x7YHHY3UaERqKGVvmboxSGXHk6gmzHYatpJS3a+TXJcXV5wLG hzDn4TSkQJ510eJ2I5QDUs+ZIoE4YS7ciaha1VutxY266c++K1k5fu2wwqGNO8c9I8Wo m/AIHWuNaCS+SQXZJTwlvHIWXZEHux8cbfOR0DMo94xg8vnU1Fdjz5sRydXIIC2F/o5B 8fOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=elm+Gb3eJr5t6iiA50ypdVkwGV4XXANmN118RGkuJAE=; b=p2nH3QsG5GjU7TbSCIpyYpbGaWxvkKO+DHtkLqEI6Unn9q35RNcukE77ETNVCDmHTm ixsrcoN93x6S5B2coRfOAs9kANCAGSWKoyx67z1P2TPhEWLcPGYMiTMPi48cp925JdsU AZSAe0RddoX/2shRpvmwmH1bXaI+1d2AjpfAK8AOFvEDPtdvWoa2bDp0TlBV4vsPi372 Q88LgHxIlXSTLGOaJNunL31CpFkW4mouqevPxKt/KceDmkltNAT3k7Fv//Ws9KhxIvkS FaJw4L/ADpZrcJqGRZzO4zbiiqoZby5Ty/hqnVxNX7WG1Z09H/ejWx6I0JuVEBnq1xSy zUBg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=archlinux.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 23si3474263ois.29.2020.03.18.09.19.50; Wed, 18 Mar 2020 09:20:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=archlinux.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727175AbgCRQTZ (ORCPT + 99 others); Wed, 18 Mar 2020 12:19:25 -0400 Received: from orion.archlinux.org ([88.198.91.70]:43124 "EHLO orion.archlinux.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726974AbgCRQTZ (ORCPT ); Wed, 18 Mar 2020 12:19:25 -0400 Received: from orion.archlinux.org (localhost [127.0.0.1]) by orion.archlinux.org (Postfix) with ESMTP id 8556C1A324B994; Wed, 18 Mar 2020 16:19:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on orion.archlinux.org X-Spam-Level: X-Spam-Status: No, score=-1.7 required=5.0 tests=ALL_TRUSTED=-1,BAYES_00=-1, DMARC_FAIL_NONE=0.25,T_DMARC_POLICY_NONE=0.01,T_DMARC_TESTS_FAIL=0.01 autolearn=no autolearn_force=no version=3.4.4 X-Spam-BL-Results: Received: from localhost.localdomain (unknown [IPv6:2001:8a0:f254:2300:dad6:8c60:8394:88da]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: ffy00) by orion.archlinux.org (Postfix) with ESMTPSA; Wed, 18 Mar 2020 16:19:21 +0000 (UTC) From: =?UTF-8?q?Filipe=20La=C3=ADns?= To: Jiri Kosina , Benjamin Tissoires , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Hutterer , Hans de Goede , Mario Limonciello , Richard Hughes Cc: =?UTF-8?q?Filipe=20La=C3=ADns?= Subject: [PATCH] HID: logitech-dj: issue udev change event on device connection Date: Wed, 18 Mar 2020 16:19:06 +0000 Message-Id: <20200318161906.3340959-1-lains@archlinux.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As discussed in the mailing list: > Right now the hid-logitech-dj driver will export one node for each > connected device, even when the device is not connected. That causes > some trouble because in userspace we don't have have any way to know if > the device is connected or not, so when we try to communicate, if the > device is disconnected it will fail. The solution reached to solve this issue is to trigger an udev change event when the device connects, this way userspace can just wait on those connections instead of trying to ping the device. Signed-off-by: Filipe LaĆ­ns --- drivers/hid/hid-logitech-dj.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/hid/hid-logitech-dj.c b/drivers/hid/hid-logitech-dj.c index 48dff5d6b605..fcd481a0be1f 100644 --- a/drivers/hid/hid-logitech-dj.c +++ b/drivers/hid/hid-logitech-dj.c @@ -1464,6 +1464,8 @@ static int logi_dj_dj_event(struct hid_device *hdev, if (dj_report->report_params[CONNECTION_STATUS_PARAM_STATUS] == STATUS_LINKLOSS) { logi_dj_recv_forward_null_report(djrcv_dev, dj_report); + } else { + kobject_uevent(&hdev->dev.kobj, KOBJ_CHANGE); } break; default: -- 2.25.1