Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200318103416.29067-1-yangx.jy@cn.fujitsu.com>
In-Reply-To: <20200318103416.29067-1-yangx.jy@cn.fujitsu.com>
From:   Masahiro Yamada <masahiroy@kernel.org>
Date:   Thu, 19 Mar 2020 01:45:43 +0900
Message-ID: <CAK7LNASHOuzZ5aU3fJRyODchDk1FUPrXFW-j_zDxNcviELnGeg@mail.gmail.com>
Subject: Re: [PATCH v2] modpost: Get proper section index by get_secindex()
 instead of st_shndx
To:     Xiao Yang <yangx.jy@cn.fujitsu.com>
Cc:     Michal Marek <michal.lkml@markovi.net>,
        Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Mar 18, 2020 at 7:39 PM Xiao Yang <yangx.jy@cn.fujitsu.com> wrote:
>
> (uint16_t) st_shndx is limited to 65535(i.e. SHN_XINDEX) so sym_get_data() gets
> wrong section index by st_shndx if requested symbol contains extended section
> index that is more than 65535.  In this case, we need to get proper section index
> by .symtab_shndx section.
>
> Module.symvers generated by building kernel with "-ffunction-sections -fdata-sections"
> shows the issue.
>
> Fixes: 56067812d5b0 ("kbuild: modversions: add infrastructure for emitting relative CRCs")
> Fixes: e84f9fbbece1 ("modpost: refactor namespace_from_kstrtabns() to not hard-code section name")
> Reviewed-by: Masahiro Yamada <masahiroy@kernel.org>
> Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
> ---

Applied to linux-kbuild/fixes.
Thanks.


>  scripts/mod/modpost.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
> index 7edfdb2f4497..1ce22896f3d8 100644
> --- a/scripts/mod/modpost.c
> +++ b/scripts/mod/modpost.c
> @@ -308,7 +308,8 @@ static const char *sec_name(struct elf_info *elf, int secindex)
>
>  static void *sym_get_data(const struct elf_info *info, const Elf_Sym *sym)
>  {
> -       Elf_Shdr *sechdr = &info->sechdrs[sym->st_shndx];
> +       unsigned int secindex = get_secindex(info, sym);
> +       Elf_Shdr *sechdr = &info->sechdrs[secindex];
>         unsigned long offset;
>
>         offset = sym->st_value;
> --
> 2.21.0
>
>
>


-- 
Best Regards
Masahiro Yamada