Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 18 Mar 2020 17:54:41 +0100
From:   Daniel Vetter <daniel@ffwll.ch>
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     Wambui Karuga <wambui.karugax@gmail.com>, airlied@linux.ie,
        daniel@ffwll.ch,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 00/17] drm: subsytem-wide debugfs functions refactor
Message-ID: <20200318165441.GA2363188@phenom.ffwll.local>
Mail-Followup-To: Greg KH <gregkh@linuxfoundation.org>,
        Wambui Karuga <wambui.karugax@gmail.com>, airlied@linux.ie,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
References: <20200310133121.27913-1-wambui.karugax@gmail.com>
 <20200310143307.GA3376131@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200310143307.GA3376131@kroah.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Mar 10, 2020 at 03:33:07PM +0100, Greg KH wrote:
> On Tue, Mar 10, 2020 at 04:31:04PM +0300, Wambui Karuga wrote:
> > This series includes work on various debugfs functions both in drm/core
> > and across various drivers in the subsystem.
> > Since commit 987d65d01356 (drm: debugfs: make drm_debugfs_create_files()
> > never fail), drm_debugfs_create_files() does not fail and only returns
> > zero. This series therefore removes the left over error handling and
> > checks for its return value across drm drivers.
> > 
> > As a result of these changes, most drm_debugfs functions are converted
> > to return void in this series. This also enables the
> > drm_driver, debugfs_init() hook to be changed to return void. 
> > 
> > v2: individual driver patches have been converted to have debugfs
> > functions return 0 instead of void to prevent breaking individual driver
> > builds.
> > The last patch then converts the .debugfs_hook() and its users across
> > all drivers to return void.
> 
> This looks much better to me, nice job:

Yup, really nice all!

> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Thanks for the patches (and the review), everything queued up in
drm-misc-next. But missed the 5.7 feature freeze in drm unfortunately, so
heading for 5.8. Apologies for being a bit too distracted past week and
not merging this a bit more timely.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch