Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 2/3] iio: dac: ad5686: add of_match_table
To:     Michael Auchter <michael.auchter@ni.com>,
        Michael Hennerich <Michael.Hennerich@analog.com>,
        Jonathan Cameron <jic23@kernel.org>,
        Hartmut Knaack <knaack.h@gmx.de>,
        Peter Meerwald-Stadler <pmeerw@pmeerw.net>
Cc:     linux-pm@vger.kernel.org, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20200318153434.62833-1-michael.auchter@ni.com>
 <20200318153434.62833-2-michael.auchter@ni.com>
From:   Lars-Peter Clausen <lars@metafoo.de>
Message-ID: <b67c7147-e35c-2408-8324-c688af4e82b7@metafoo.de>
Date:   Wed, 18 Mar 2020 18:33:58 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.5.0
MIME-Version: 1.0
In-Reply-To: <20200318153434.62833-2-michael.auchter@ni.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 3/18/20 4:34 PM, Michael Auchter wrote:
> Add of_match_table to this driver, so devices can be probed based on
> device tree contents.
> 
> Signed-off-by: Michael Auchter <michael.auchter@ni.com>
> ---
>   drivers/iio/dac/ad5696-i2c.c | 19 +++++++++++++++++++
>   1 file changed, 19 insertions(+)
> 
> diff --git a/drivers/iio/dac/ad5696-i2c.c b/drivers/iio/dac/ad5696-i2c.c
> index f100a5fe4219..26818bccffa2 100644
> --- a/drivers/iio/dac/ad5696-i2c.c
> +++ b/drivers/iio/dac/ad5696-i2c.c
> @@ -88,9 +88,28 @@ static const struct i2c_device_id ad5686_i2c_id[] = {
>   };
>   MODULE_DEVICE_TABLE(i2c, ad5686_i2c_id);
>   
> +static const struct of_device_id ad5686_of_match[] = {
> +	{ .compatible = "adi,ad5311r" },
> +	{ .compatible = "adi,ad5671r" },
> +	{ .compatible = "adi,ad5675r" },
> +	{ .compatible = "adi,ad5691r" },
> +	{ .compatible = "adi,ad5692r" },
> +	{ .compatible = "adi,ad5693" },
> +	{ .compatible = "adi,ad5693r" },
> +	{ .compatible = "adi,ad5694" },
> +	{ .compatible = "adi,ad5694r" },
> +	{ .compatible = "adi,ad5695r" },
> +	{ .compatible = "adi,ad5696" },
> +	{ .compatible = "adi,ad5696r" },
> +	{ .compatible = "adi,ad5338r" },

Same here, table should be ordered.

> +	{}
> +};
> +MODULE_DEVICE_TABLE(of, ad5686_of_match);
> +
>   static struct i2c_driver ad5686_i2c_driver = {
>   	.driver = {
>   		.name = "ad5696",
> +		.of_match_table = of_match_ptr(ad5686_of_match),
>   	},
>   	.probe = ad5686_i2c_probe,
>   	.remove = ad5686_i2c_remove,
>