Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH net] ipv6: don't auto-add link-local address to lag ports
To:     Jarod Wilson <jarod@redhat.com>, linux-kernel@vger.kernel.org
Cc:     Moshe Levi <moshele@mellanox.com>,
        Marcelo Ricardo Leitner <mleitner@redhat.com>,
        netdev@vger.kernel.org
References: <20200318140605.45273-1-jarod@redhat.com>
From:   Eric Dumazet <eric.dumazet@gmail.com>
Message-ID: <8a88d1c8-c6b1-ad85-7971-e6ae8c6fa0e4@gmail.com>
Date:   Wed, 18 Mar 2020 11:02:01 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.5.0
MIME-Version: 1.0
In-Reply-To: <20200318140605.45273-1-jarod@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 3/18/20 7:06 AM, Jarod Wilson wrote:
> Bonding slave and team port devices should not have link-local addresses
> automatically added to them, as it can interfere with openvswitch being
> able to properly add tc ingress.
> 
> Reported-by: Moshe Levi <moshele@mellanox.com>
> CC: Marcelo Ricardo Leitner <mleitner@redhat.com>
> CC: netdev@vger.kernel.org
> Signed-off-by: Jarod Wilson <jarod@redhat.com>


This does not look a net candidate to me, unless the bug has been added recently ?

The absence of Fixes: tag is a red flag for a net submission.

By adding a Fixes: tag, you are doing us a favor, please.

Thanks.

> ---
>  net/ipv6/addrconf.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
> index 46d614b611db..aed891695084 100644
> --- a/net/ipv6/addrconf.c
> +++ b/net/ipv6/addrconf.c
> @@ -3296,6 +3296,10 @@ static void addrconf_addr_gen(struct inet6_dev *idev, bool prefix_route)
>  	if (netif_is_l3_master(idev->dev))
>  		return;
>  
> +	/* no link local addresses on bond slave or team port devices */
> +	if (netif_is_lag_port(idev->dev))
> +		return;
> +
>  	ipv6_addr_set(&addr, htonl(0xFE800000), 0, 0, 0);
>  
>  	switch (idev->cnf.addr_gen_mode) {
>