Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp992458ybh; Wed, 18 Mar 2020 12:55:00 -0700 (PDT) X-Google-Smtp-Source: ADFU+vtOMO+eESTrjCSkJtg1AfD0Vm71nmrAMxz3QWRIKeIOMd+MD10fZo092fVzF2vjFuJToQbt X-Received: by 2002:aca:5014:: with SMTP id e20mr4699557oib.34.1584561300577; Wed, 18 Mar 2020 12:55:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584561300; cv=none; d=google.com; s=arc-20160816; b=UBRiVgJSGKI21Jk0v8dJwSFf9iIyM6I6pvl9td82cYva3I6GgjHmuGcn6fnxrYN/Dg llBv7ajPHrEtonsdBkNC2yINWntsRbS+U7RCkKPYrXbOkF4nFX/xHbAONb36XewTCOyo gIN/Ffi7+iOI/o5X6aGcRY8RW2crnRQPEOBaWgpIjtsPRXtTBf/LZe0bn+58IBI2NVGx y95ZM/EjNuW98on2zw1JOnqHtQDXKYgnH5qlnPhG+A7hbtLWcsu4WAkDJhHCfH8RPRZd ml48W9/JTHqRsEglI1aBz8RSaOp70ZgMQaVw3UgcGv+bjeCP2OI0/46M7mp9RFMu18H2 HkKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=Fo9kYsrqbtD6J5RLU4TBL3iKOuVOyJEInP6yb67PRu0=; b=QB8d6qsNGepVcbNmOXQXjkQAadpiVa37I1iRPIibSQT9kGbECGY3JN932zQFrCEz9c +l7O/RH2QPgzapn7bHWn6nfjt2Lbr+/pieeuqytwR8wY/LrAQVNXZxMmf9G2a9kudcqJ 3wtKEkay9R30lefJ0fLdg8ygVfJt21zbc5aeva/WFI7cpRuu+vgnCHx3WYyJZmfFH3cL mrr/wvDXueQcNy09KcEuBu1w1GoPiWS2ZIC0w79c9BHST/rp04SfimWZIdyvKCiPgr/j Dlr7LyC1PZWHH8QrFzLlKMskaI/CvjEgoWkBXSFR2TYZQnxuOMNq4CCORgQ+dzvxiLB6 oiCw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g22si999164otn.56.2020.03.18.12.54.49; Wed, 18 Mar 2020 12:55:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726943AbgCRTyG (ORCPT + 99 others); Wed, 18 Mar 2020 15:54:06 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:1950 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726647AbgCRTyG (ORCPT ); Wed, 18 Mar 2020 15:54:06 -0400 Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 02IJXENF025898; Wed, 18 Mar 2020 15:53:58 -0400 Received: from ppma01wdc.us.ibm.com (fd.55.37a9.ip4.static.sl-reverse.com [169.55.85.253]) by mx0a-001b2d01.pphosted.com with ESMTP id 2yupjt6m4q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 18 Mar 2020 15:53:57 -0400 Received: from pps.filterd (ppma01wdc.us.ibm.com [127.0.0.1]) by ppma01wdc.us.ibm.com (8.16.0.27/8.16.0.27) with SMTP id 02IJZI8b005100; Wed, 18 Mar 2020 19:53:56 GMT Received: from b03cxnp08025.gho.boulder.ibm.com (b03cxnp08025.gho.boulder.ibm.com [9.17.130.17]) by ppma01wdc.us.ibm.com with ESMTP id 2yrpw6jyjm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 18 Mar 2020 19:53:56 +0000 Received: from b03ledav005.gho.boulder.ibm.com (b03ledav005.gho.boulder.ibm.com [9.17.130.236]) by b03cxnp08025.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 02IJrtfH38338984 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 18 Mar 2020 19:53:55 GMT Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B8938BE04F; Wed, 18 Mar 2020 19:53:55 +0000 (GMT) Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 09626BE051; Wed, 18 Mar 2020 19:53:54 +0000 (GMT) Received: from sbct-3.pok.ibm.com (unknown [9.47.158.153]) by b03ledav005.gho.boulder.ibm.com (Postfix) with ESMTP; Wed, 18 Mar 2020 19:53:54 +0000 (GMT) Subject: Re: [PATCH] tpm2: Export tpm2_get_cc_attrs_tbl for ibmvtpm driver as module To: Jarkko Sakkinen , Stefan Berger Cc: linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, linux-next@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sachinp@linux.vnet.ibm.com, mpe@ellerman.id.au References: <20200317130819.720318-1-stefanb@linux.vnet.ibm.com> <20200318194247.GC48177@linux.intel.com> From: Stefan Berger Message-ID: <4b2949a9-b251-906d-d513-1b2ccef758a0@linux.ibm.com> Date: Wed, 18 Mar 2020 15:53:54 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200318194247.GC48177@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.645 definitions=2020-03-18_07:2020-03-18,2020-03-18 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 impostorscore=0 phishscore=0 clxscore=1015 malwarescore=0 adultscore=0 mlxlogscore=999 lowpriorityscore=0 spamscore=0 priorityscore=1501 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2003180086 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/18/20 3:42 PM, Jarkko Sakkinen wrote: > On Tue, Mar 17, 2020 at 09:08:19AM -0400, Stefan Berger wrote: >> From: Stefan Berger >> >> This patch fixes the following problem when the ibmvtpm driver >> is built as a module: >> >> ERROR: modpost: "tpm2_get_cc_attrs_tbl" [drivers/char/tpm/tpm_ibmvtpm.ko] undefined! >> make[1]: *** [scripts/Makefile.modpost:94: __modpost] Error 1 >> make: *** [Makefile:1298: modules] Error 2 >> >> Signed-off-by: Stefan Berger > Hi, wrong tag (we use "tpm:"), missing fixes tag and please cc stable. > Thanks. I did not add the fixes tag because I do not know the final commit hash, or is it the final commit hash once it is in linux-next? I doubt it with all the merging that can occur.    Stefan > > /Jarkko