Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964932AbWBTOR0 (ORCPT ); Mon, 20 Feb 2006 09:17:26 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964921AbWBTORZ (ORCPT ); Mon, 20 Feb 2006 09:17:25 -0500 Received: from pentafluge.infradead.org ([213.146.154.40]:59305 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S964932AbWBTORY (ORCPT ); Mon, 20 Feb 2006 09:17:24 -0500 Date: Mon, 20 Feb 2006 14:17:14 +0000 From: Christoph Hellwig To: Mathieu Desnoyers Cc: Tom Zanussi , Paul Mundt , Greg KH , linux-kernel@vger.kernel.org, axboe@suse.de, karim@opersys.com Subject: Re: [PATCH, RFC] sysfs: relay channel buffers as sysfs attributes Message-ID: <20060220141713.GA29479@infradead.org> Mail-Followup-To: Christoph Hellwig , Mathieu Desnoyers , Tom Zanussi , Paul Mundt , Greg KH , linux-kernel@vger.kernel.org, axboe@suse.de, karim@opersys.com References: <20060219171748.GA13068@linux-sh.org> <20060219175623.GA2674@kroah.com> <20060219185254.GA13391@linux-sh.org> <17401.21427.568297.830492@tut.ibm.com> <20060220130555.GA29405@Krystal> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060220130555.GA29405@Krystal> User-Agent: Mutt/1.4.2.1i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1107 Lines: 23 On Mon, Feb 20, 2006 at 08:05:56AM -0500, Mathieu Desnoyers wrote: > * LTTng does have its own ltt_poll and ltt_ioctl that are all what is needed to > control the interaction with the file (along with the relayfs mmap/unmap). > > In this scenario, the sysfs relay attribute creation would look like : > > - create an empty attr > - fill some of attr members > - sysfs_create_relay_file(kobj, attr); > (it will overwrite some attr members : kobj, rchan, rchan_buf) > * set specific LTTng file operations on the inode defintily not on sysfs. sysfs doesn't allow drivers to modify the file operations for good reasons. it'll probably work the same as-is when you use the rely file operations on debugfs or a custom filesystem, although you're code will have zero chance to get merged when it modifies an existing file operations struct or adds an ioctl. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/