Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=us-ascii
Subject: Re: [PATCH 2/2] perf: arm_dsu: Support DSU ACPI devices.
From:   Tuan Phan <tuanphan@amperemail.onmicrosoft.com>
In-Reply-To: <a571cf7e-c2a5-e8f8-e782-8087249143b0@arm.com>
Date:   Wed, 18 Mar 2020 19:42:13 -0700
Cc:     tuanphan@os.amperecomputing.com, patches@amperecomputing.com,
        will@kernel.org, mark.rutland@arm.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        sudeep.holla@arm.com
Content-Transfer-Encoding: quoted-printable
Message-Id: <9D13EDC1-B0A9-4945-AAC6-E71A1AAAEBC5@amperemail.onmicrosoft.com>
References: <1584491323-31436-1-git-send-email-tuanphan@os.amperecomputing.com>
 <a571cf7e-c2a5-e8f8-e782-8087249143b0@arm.com>
To:     Suzuki K Poulose <suzuki.poulose@arm.com>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [192.168.0.104] (73.151.103.95) by CY4PR06CA0070.namprd06.prod.outlook.com (2603:10b6:903:13d::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2835.18 via Frontend Transport; Thu, 19 Mar 2020 02:42:15 +0000
X-Mailer: Apple Mail (2.3608.60.0.2.5)
X-Originating-IP: [73.151.103.95]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9c618678-fb61-4bcb-74e4-08d7cbaf233f
X-MS-TrafficTypeDiagnostic: MWHPR01MB2239:|MWHPR01MB2239:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <MWHPR01MB223917E84F152F9A295A99A7E0F40@MWHPR01MB2239.prod.exchangelabs.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:983;
X-Forefront-PRVS: 0347410860
X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4636009)(396003)(136003)(376002)(39840400004)(366004)(346002)(199004)(66476007)(66946007)(6916009)(66556008)(2906002)(6486002)(52116002)(316002)(16576012)(53546011)(33656002)(8676002)(4326008)(81166006)(956004)(42882007)(2616005)(8936002)(26005)(16526019)(186003)(81156014)(478600001)(5660300002);DIR:OUT;SFP:1102;SCL:1;SRVR:MWHPR01MB2239;H:MWHPR01MB2317.prod.exchangelabs.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:0;
Received-SPF: None (protection.outlook.com: os.amperecomputing.com does not
 designate permitted sender hosts)
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: wkYZAMPAL20jCtM5lyl8PugBpHdWWIWYOxwGPcFfbH6udaQqFDbJZaN1Hi2PkFkxaySeoqADEVYtp4A6Y7z8LhzdHDC5vUAusT75GwfCjUKpPg9bpk2GnXovoS2YYb2jIfYIdTbWvLb0wsg7w+Mb7N6n/tyqF7f+41mbKEXsZfk02UwrAoQ3fR9yYAkbe8rlEniE3EUoxbZmgC5G23sLu2ts7UohgYCXOSL+y4yB5J1xuDZrlHBiEIZW8TSZiPkAv5/ahSpIq5qGfCgItk+jquko3AUtk+4yTovPULK2yXTNcStUkOvZUO644Qy3/l3DGi7p8Vkl6glfbbmIYLos1VRpiq2htTqeNJLKLLFwaPEtEiccEAYb51THORi4Buyk6/6e4A+Gtk1mYz4v/TdlnE3fSKEYF4pMK9oEXEVNGBGWiqF8SsHAJgl29qnrUCdM
X-MS-Exchange-AntiSpam-MessageData: Dcu41/S3gtJkOHGVbir4HGPHWNzSVyAaWtC/lX0ioRUmlirz6mG9zV3f/0sff1V4pGTzTR8CjF9yL8evn4I78MQHi0bzNT1z/yODlkm+6KL0BBDrxfddQCrbSDz9wVDK2qFgYA43hnzKlMSJTwEAHA==
X-OriginatorOrg: amperemail.onmicrosoft.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9c618678-fb61-4bcb-74e4-08d7cbaf233f
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Mar 2020 02:42:17.2658
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qDnoEDOJkDdNwZuHyeCBFjzLEwY9fO32bJARQIXKoSn+QY/Sv2BkzWFWD3LHm1Xp9Wxh1dMOebxiWcde3HN0ronSxO7y2XZiUxVdYPONjz0AYO7fTR8dviWkHgDtHlPN
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR01MB2239
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Thanks Suzuki and Robin for quick reply.
Please find my comments below.

> On Mar 18, 2020, at 5:45 PM, Suzuki K Poulose <suzuki.poulose@arm.com> wr=
ote:
>=20
> Hello,
>=20
>=20
> Please find my comments below.
>=20
> On 03/18/2020 12:28 AM, Tuan Phan wrote:
>> Add support for probing device from ACPI node.
>> Each DSU ACPI node defines "cpus" package which
>> each element is the MPIDR of associated cpu.
>> Signed-off-by: Tuan Phan <tuanphan@os.amperecomputing.com>
>> ---
>>  drivers/perf/arm_dsu_pmu.c | 53 +++++++++++++++++++++++++++++++++++++++=
-------
>>  1 file changed, 45 insertions(+), 8 deletions(-)
>> diff --git a/drivers/perf/arm_dsu_pmu.c b/drivers/perf/arm_dsu_pmu.c Tua
>> index 2622900..6ef762c 100644
>> --- a/drivers/perf/arm_dsu_pmu.c
>> +++ b/drivers/perf/arm_dsu_pmu.c
>> @@ -11,6 +11,7 @@
>>  #define DRVNAME		PMUNAME "_pmu"
>>  #define pr_fmt(fmt)	DRVNAME ": " fmt
>>  +#include <linux/acpi.h>
>>  #include <linux/bitmap.h>
>>  #include <linux/bitops.h>
>>  #include <linux/bug.h>
>> @@ -603,18 +604,22 @@ static struct dsu_pmu *dsu_pmu_alloc(struct platfo=
rm_device *pdev)
>>  }
>>    /**
>> - * dsu_pmu_dt_get_cpus: Get the list of CPUs in the cluster.
>> + * dsu_pmu_get_cpus: Get the list of CPUs in the cluster.
>>   */
>> -static int dsu_pmu_dt_get_cpus(struct device_node *dev, cpumask_t *mask=
)
>> +static int dsu_pmu_get_cpus(struct platform_device *pdev)
>>  {
>> +#ifndef CONFIG_ACPI
>> +	/* Get the list of CPUs from device tree */
>=20
> What if we have a kernel with both:
>=20
> CONFIG_OF=3Dy
> CONFIG_ACPI=3Dy
>=20
> and boot the kernel on a system with DT ? In other words, the decision
> to choose the DT vs ACPI must be runtime decision, not buildtime.
>=20
> See drivers/hwtracing/coresight/coresight-platform.c:coresight_get_platfo=
rm_data() for an example.

I will update so it can be detected in runtime.

>>  	int i =3D 0, n, cpu;
>>  	struct device_node *cpu_node;
>> +	struct dsu_pmu *dsu_pmu =3D
>> +		(struct dsu_pmu *) platform_get_drvdata(pdev);
>>  -	n =3D of_count_phandle_with_args(dev, "cpus", NULL);
>> +	n =3D of_count_phandle_with_args(pdev->dev.of_node, "cpus", NULL);
>>  	if (n <=3D 0)
>>  		return -ENODEV;
>>  	for (; i < n; i++) {
>> -		cpu_node =3D of_parse_phandle(dev, "cpus", i);
>> +		cpu_node =3D of_parse_phandle(pdev->dev.of_node, "cpus", i);
>>  		if (!cpu_node)
>>  			break;
>>  		cpu =3D of_cpu_node_to_id(cpu_node);
>> @@ -626,9 +631,33 @@ static int dsu_pmu_dt_get_cpus(struct device_node *=
dev, cpumask_t *mask)
>>  		 */
>>  		if (cpu < 0)
>>  			continue;
>> -		cpumask_set_cpu(cpu, mask);
>> +		cpumask_set_cpu(cpu, &dsu_pmu->associated_cpus);
>>  	}
>>  	return 0;
>> +#else /* CONFIG_ACPI */
>> +	int i, cpu, ret;
>> +	const union acpi_object *obj;
>> +	struct acpi_device *adev =3D ACPI_COMPANION(&pdev->dev);
>> +	struct dsu_pmu *dsu_pmu =3D
>> +		(struct dsu_pmu *) platform_get_drvdata(pdev);
>> +
>=20
>> +	ret =3D acpi_dev_get_property(adev, "cpus", ACPI_TYPE_ANY, &obj);
>=20
> Is the binding documented somewhere ?

=3D> Will add one.

>=20
>=20
> nit: Also, why not :
> 	ret =3D acpi_dev_get_propert(adev, "cpus", ACPI_TYPE_PACKAGE, &obj);
> 	if (ret < 0)
> 		return ret;
> ?
>=20
>=20
>> +	if (ret < 0)
>> +		return -EINVAL;
>> +
>> +	if (obj->type !=3D ACPI_TYPE_PACKAGE)
>> +		return -EINVAL;
>> +
>> +	for (i =3D 0; i < obj->package.count; i++) {
>=20
>=20
>> +		/* Each element is the MPIDR of associated cpu */
>> +		for_each_possible_cpu(cpu) {
>> +			if (cpu_physical_id(cpu) =3D=3D
>> +				obj->package.elements[i].integer.value)
>> +				cpumask_set_cpu(cpu, &dsu_pmu->associated_cpus);
>> +		}
>> +	}
>> +	return 0;
>> +#endif
>>  }
>> =20
>=20
> Otherwise looks good to me.
>=20
> Suzuki