Received: by 2002:a25:d783:0:0:0:0:0 with SMTP id o125csp349733ybg; Thu, 19 Mar 2020 00:37:00 -0700 (PDT) X-Google-Smtp-Source: ADFU+vuHNA+HYQ5X90Ts/dmuDvwUZ5Wpfg8Z18AIlqaenxGdkwJquFxdaEDvK9G+HC6JCPdXox9J X-Received: by 2002:a9d:4d0d:: with SMTP id n13mr1223856otf.19.1584603420540; Thu, 19 Mar 2020 00:37:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584603420; cv=none; d=google.com; s=arc-20160816; b=qGihZDP42FpsETgxk5ronZFXSVI41pFDkchXEBvtN1lUy4We9WVjrmv1YjCL7LzG+p 2dx+h5U5V42udkvuWqAg1kQmLdQIiIvG+BiNUN7IXzCcmV2omnJCRhRFdpthWHFSeRGx WHLDzswwmMDDvwefaaFvzUtceVz5+iq6Hu0Y+olXGXKM7xQUVL+2+m3vAbX7AmwgZYda j8Vif8UWpDtszIcaoHAhd9Y1JpWj4MhrccNKPQDAmuV4/q5BG6EC9OgwRjYN8HNONlUf 8j4yi7OEPG+GEQ7vBGDY3GAxX2Watnzpk9xU0zLDjCQGnnkzUqvz7d//LCqjx9QNzAnO +wPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject; bh=/fBhfT+rMlthGFu+Ema02hVyZyQrqXcJWnXzmXawybo=; b=dyEf1LUnCyH6e7kJUZKPHWAiTYf/gsjlLrmKJcPpKQDL+wNEZxGJXvweuX+f1Wnt7G XrkJFyngyOBXQeURle+oQgJmxXp9OYq+XJuOCLWL7v2X4/3yBu1fdZ6d1hfLbCYeMPaT PxLrU/5tDosEZZDnP6ci8BE86d5+Gziz/VZrW+5TXAfICO30u9hDFbIiPWq/u22oNxia i2EKd0sPxVlbrU94F8cU+/USKW0DMvkF+m5hEPBDVJq5GwEpWIjmiiVuERYI2UUO2MY3 4hbFgnU4041PJigJLobQ7JCvwI45SV4hZzRH5TQNyVZu4Y3thM0k8BAHZ07f//wZTCca LCoQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g19si887740otn.219.2020.03.19.00.36.47; Thu, 19 Mar 2020 00:37:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726989AbgCSHgc (ORCPT + 99 others); Thu, 19 Mar 2020 03:36:32 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:38331 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725767AbgCSHgc (ORCPT ); Thu, 19 Mar 2020 03:36:32 -0400 Received: by mail-wr1-f66.google.com with SMTP id s1so1392363wrv.5; Thu, 19 Mar 2020 00:36:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=/fBhfT+rMlthGFu+Ema02hVyZyQrqXcJWnXzmXawybo=; b=hglReycdjEceDak/rSEAaO2Q+N8oo6Azfp+dtxmJ7EkJ3C7M2IyhbCRsxr6OFViM+F +kMxQdpdKs3GwRYYw+dJidRJ+iTk0S/JLd5gLD8Z8cCQQU0o8m4ZStMQ27MBBeRjOLem OTYZ59+fLseWz6YkDCersHOUzZowUGl3fXWIoZVaOBShVwRxJU0vjEbSi8cbLWwKNIx9 RXpMeeY1dgs2MEi5eHyeHUSb7PBiPPBiWz3Kf8WlAghtfLUXR/upHWjAwoam1McFJcpY OjRJFuF37GHUwwmX/8r/SMNxs3Zg6/MMykppJl/1/ZVgd938lNBviE8dRDPNRxcR665S EGaQ== X-Gm-Message-State: ANhLgQ0+gAfkbUVqZ79fbXrOP0qQGf2yrOC9O7BvmnPWLb/c5Th2qPNk 92qFWXfDm+NLnmxNS950uq0= X-Received: by 2002:a05:6000:10d:: with SMTP id o13mr2356381wrx.84.1584603390572; Thu, 19 Mar 2020 00:36:30 -0700 (PDT) Received: from ?IPv6:2a0b:e7c0:0:107::49? ([2a0b:e7c0:0:107::49]) by smtp.gmail.com with ESMTPSA id y5sm1951580wmi.34.2020.03.19.00.36.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Mar 2020 00:36:29 -0700 (PDT) Subject: Re: [PATCH v2 1/2] vt: vt_ioctl: fix VT_DISALLOCATE freeing in-use virtual console To: Eric Biggers , Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, syzkaller-bugs@googlegroups.com, Eric Dumazet , Nicolas Pitre References: <20200318222704.GC2334@sol.localdomain> <20200318223810.162440-1-ebiggers@kernel.org> <20200318223810.162440-2-ebiggers@kernel.org> From: Jiri Slaby Autocrypt: addr=jslaby@suse.com; prefer-encrypt=mutual; keydata= mQINBE6S54YBEACzzjLwDUbU5elY4GTg/NdotjA0jyyJtYI86wdKraekbNE0bC4zV+ryvH4j rrcDwGs6tFVrAHvdHeIdI07s1iIx5R/ndcHwt4fvI8CL5PzPmn5J+h0WERR5rFprRh6axhOk rSD5CwQl19fm4AJCS6A9GJtOoiLpWn2/IbogPc71jQVrupZYYx51rAaHZ0D2KYK/uhfc6neJ i0WqPlbtIlIrpvWxckucNu6ZwXjFY0f3qIRg3Vqh5QxPkojGsq9tXVFVLEkSVz6FoqCHrUTx wr+aw6qqQVgvT/McQtsI0S66uIkQjzPUrgAEtWUv76rM4ekqL9stHyvTGw0Fjsualwb0Gwdx ReTZzMgheAyoy/umIOKrSEpWouVoBt5FFSZUyjuDdlPPYyPav+hpI6ggmCTld3u2hyiHji2H cDpcLM2LMhlHBipu80s9anNeZhCANDhbC5E+NZmuwgzHBcan8WC7xsPXPaiZSIm7TKaVoOcL 9tE5aN3jQmIlrT7ZUX52Ff/hSdx/JKDP3YMNtt4B0cH6ejIjtqTd+Ge8sSttsnNM0CQUkXps w98jwz+Lxw/bKMr3NSnnFpUZaxwji3BC9vYyxKMAwNelBCHEgS/OAa3EJoTfuYOK6wT6nadm YqYjwYbZE5V/SwzMbpWu7Jwlvuwyfo5mh7w5iMfnZE+vHFwp/wARAQABtBxKaXJpIFNsYWJ5 IDxqc2xhYnlAc3VzZS5jb20+iQI4BBMBAgAiBQJOkujrAhsDBgsJCAcDAgYVCAIJCgsEFgID AQIeAQIXgAAKCRC9JbEEBrRwSc1VD/9CxnyCYkBrzTfbi/F3/tTstr3cYOuQlpmufoEjCIXx PNnBVzP7XWPaHIUpp5tcweG6HNmHgnaJScMHHyG83nNAoCEPihyZC2ANQjgyOcnzDOnW2Gzf 8v34FDQqj8CgHulD5noYBrzYRAss6K42yUxUGHOFI1Ky1602OCBRtyJrMihio0gNuC1lE4YZ juGZEU6MYO1jKn8QwGNpNKz/oBs7YboU7bxNTgKrxX61cSJuknhB+7rHOQJSXdY02Tt31R8G diot+1lO/SoB47Y0Bex7WGTXe13gZvSyJkhZa5llWI/2d/s1aq5pgrpMDpTisIpmxFx2OEkb jM95kLOs/J8bzostEoEJGDL4u8XxoLnOEjWyT82eKkAe4j7IGQlA9QQR2hCMsBdvZ/EoqTcd SqZSOto9eLQkjZLz0BmeYIL8SPkgnVAJ/FEK44NrHUGzjzdkE7a0jNvHt8ztw6S+gACVpysi QYo2OH8hZGaajtJ8mrgN2Lxg7CpQ0F6t/N1aa/+A2FwdRw5sHBqA4PH8s0Apqu66Q94YFzzu 8OWkSPLgTjtyZcez79EQt02u8xH8dikk7API/PYOY+462qqbahpRGaYdvloaw7tOQJ224pWJ 4xePwtGyj4raAeczOcBQbKKW6hSH9iz7E5XUdpJqO3iZ9psILk5XoyO53wwhsLgGcrkCDQRO kueGARAAz5wNYsv5a9z1wuEDY5dn+Aya7s1tgqN+2HVTI64F3l6Yg753hF8UzTZcVMi3gzHC ECvKGwpBBwDiJA2V2RvJ6+Jis8paMtONFdPlwPaWlbOv4nHuZfsidXkk7PVCr4/6clZggGNQ qEjTe7Hz2nnwJiKXbhmnKfYXlxftT6KdjyUkgHAs8Gdz1nQCf8NWdQ4P7TAhxhWdkAoOIhc4 OQapODd+FnBtuL4oCG0c8UzZ8bDZVNR/rYgfNX54FKdqbM84FzVewlgpGjcUc14u5Lx/jBR7 ttZv07ro88Ur9GR6o1fpqSQUF/1V+tnWtMQoDIna6p/UQjWiVicQ2Tj7TQgFr4Fq8ZDxRb10 Zbeds+t+45XlRS9uexJDCPrulJ2sFCqKWvk3/kf3PtUINDR2G4k228NKVN/aJQUGqCTeyaWf fU9RiJU+sw/RXiNrSL2q079MHTWtN9PJdNG2rPneo7l0axiKWIk7lpSaHyzBWmi2Arj/nuHf Maxpc708aCecB2p4pUhNoVMtjUhKD4+1vgqiWKI6OsEyZBRIlW2RRcysIwJ648MYejvf1dzv mVweUa4zfIQH/+G0qPKmtst4t/XLjE/JN54XnOD/TO1Fk0pmJyASbHJQ0EcecEodDHPWP6bM fQeNlm1eMa7YosnXwbTurR+nPZk+TYPndbDf1U0j8n0AEQEAAYkCHwQYAQIACQUCTpLnhgIb DAAKCRC9JbEEBrRwSTe1EACA74MWlvIhrhGWd+lxbXsB+elmL1VHn7Ovj3qfaMf/WV3BE79L 5A1IDyp0AGoxv1YjgE1qgA2ByDQBLjb0yrS1ppYqQCOSQYBPuYPVDk+IuvTpj/4rN2v3R5RW d6ozZNRBBsr4qHsnCYZWtEY2pCsOT6BE28qcbAU15ORMq0nQ/yNh3s/WBlv0XCP1gvGOGf+x UiE2YQEsGgjs8v719sguok8eADBbfmumerh/8RhPKRuTWxrXdNq/pu0n7hA6Btx7NYjBnnD8 lV8Qlb0lencEUBXNFDmdWussMAlnxjmKhZyb30m1IgjFfG30UloZzUGCyLkr/53JMovAswmC IHNtXHwb58Ikn1i2U049aFso+WtDz4BjnYBqCL1Y2F7pd8l2HmDqm2I4gubffSaRHiBbqcSB lXIjJOrd6Q66u5+1Yv32qk/nOL542syYtFDH2J5wM2AWvfjZH1tMOVvVMu5Fv7+0n3x/9shY ivRypCapDfcWBGGsbX5eaXpRfInaMTGaU7wmWO44Z5diHpmQgTLOrN9/MEtdkK6OVhAMVenI w1UnZnA+ZfaZYShi5oFTQk3vAz7/NaA5/bNHCES4PcDZw7Y/GiIh/JQR8H1JKZ99or9LjFeg HrC8YQ1nzkeDfsLtYM11oC3peHa5AiXLmCuSC9ammQ3LhkfET6N42xTu2A== Message-ID: <2f762aee-720b-9bec-620f-61129c724de6@suse.com> Date: Thu, 19 Mar 2020 08:36:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200318223810.162440-2-ebiggers@kernel.org> Content-Type: text/plain; charset=iso-8859-2 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18. 03. 20, 23:38, Eric Biggers wrote: > --- a/drivers/tty/vt/vt.c > +++ b/drivers/tty/vt/vt.c > @@ -1102,6 +1102,9 @@ int vc_allocate(unsigned int currcons) /* return 0 on success */ > tty_port_init(&vc->port); > INIT_WORK(&vc_cons[currcons].SAK_work, vc_SAK); > > + /* if this wasn't the case, we'd have to implement port->ops.destruct */ > + BUILD_BUG_ON(offsetof(struct vc_data, port) != 0); > + This is 3 lines, implementing destruct would be like 4-5 :)? Please implement destruct instead. Otherwise looks good. thanks, -- js suse labs