Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Valdis Kl=?utf-8?Q?=c4=93?=tnieks" <valdis.kletnieks@vt.edu>
To:     Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc:     Eugeniu Rosca <erosca@de.adit-jv.com>,
        linux-kernel@vger.kernel.org,
        John Ogness <john.ogness@linutronix.de>,
        Petr Mladek <pmladek@suse.com>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ingo Molnar <mingo@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Peter Zijlstra <peterz@infradead.org>,
        Jisheng Zhang <Jisheng.Zhang@synaptics.com>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Andrew Gabbasov <andrew_gabbasov@mentor.com>,
        Dirk Behme <dirk.behme@de.bosch.com>,
        Eugeniu Rosca <roscaeugeniu@gmail.com>
Subject: Re: [RFC PATCH 3/3] watchdog: Turn console verbosity on when reporting softlockup
In-Reply-To: <20200319064836.GB24020@google.com>
References: <20200315170903.17393-1-erosca@de.adit-jv.com> <20200315170903.17393-4-erosca@de.adit-jv.com> <20200317021818.GD219881@google.com> <20200318180525.GA5790@lxhi-065.adit-jv.com>
 <20200319064836.GB24020@google.com>
Mime-Version: 1.0
Content-Type: multipart/signed; boundary="==_Exmh_1584603506_13116P";
         micalg=pgp-sha1; protocol="application/pgp-signature"
Content-Transfer-Encoding: 7bit
Date:   Thu, 19 Mar 2020 03:38:26 -0400
Message-ID: <16373.1584603506@turing-police>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--==_Exmh_1584603506_13116P
Content-Type: text/plain; charset=us-ascii

On Thu, 19 Mar 2020 15:48:36 +0900, Sergey Senozhatsky said:

> So the issue is that when we bump `console_loglevel' or `ignore_loglevel'
> we lift restrictions globally. For all CPUs, for all contexts which call
> printk(). This may have negative impact. Fuzzing is one example. It
> usually generates a lot of printk() noise, so lifting global printk()
> log_level restrictions does cause problems. I recall that fuzzing people
> really disliked the
> 			old_level = console_loglevel
> 			console_loglevel = new_level
> 			....
> 			console_loglevel = old_level
>
> approach. Because if lets all CPUs and tasks to pollute serial logs.
> While what we want is to print messages from a particular CPU/task.

Well... how does this sound for a RFC idea?  We already have CONFIG_PRINTK_TIME
and CONFIG_PRINTK_CALLER.  How about adding an option to allow printing the
calling CPU as well, or just extend CALLER to print [pid/cpu] rather than just
[pid]?

(And yes, I know that the concept of "this CPU" can change quickly, which is
why per_cpu data may not be accurate for anything more than statistical
aggregation purposes.  It's only worth pondering how to deal with that if it's
worth developing the patch at all... :)


--==_Exmh_1584603506_13116P
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Comment: Exmh version 2.9.0 11/07/2018

iQIVAwUBXnMhcgdmEQWDXROgAQIpVxAAh/dMuQn+/WY3Tf02NolMacc55goAz7jP
wuQz4/9+SseYJBe6eq8bjshKtvexOSEjWwfC2TtuJUDLuLwASqUXaUchGGJs6z5z
bXl0aDmK9jQW8ogcd1S1NZMs3iOqC4e0+Ej3pkWNFiUpvY5hcKar/+w/G/6v80hw
3fF835wFNjGOtsmFBPvvqSjTrDX7QQnfAJ5frFDlMgvgXqKtPqzZUaFJaoUgvOia
gFJb2vbX86ilYj0W/FOax+8EfVLgBUEjTO2/ubZNXRnEykQKVVDL2i6xwTyj4Jk7
cJcCDWwk4oJCTUdTxC6+EcpCZSQB+dqBDxRwhRQZfesnM9g6w88Gc1Gdl+oVlVRo
ktCbwL7+Wy3epQRIO+gNFJm5V/DnElMCNr5ZDviQLGQvS0jiyp4baxt59hitG8De
l09n8V8mRXxQhfy/z8tyQzPwN01OaVB1XR9762BrXJ/sOwNRU8cF5UHtyhGXzEdO
QgIcQIUTnZ6dBr+vA30/NrP2iHvvodguJktXPDZGgzsxAAtNbA25UybM+9rZAEtE
FNka9fKe29GojsGCrSCkgICjO4N0JvqJ2ZXBgvz+4y6cX/7rqf4TXVHxxXgV74kt
BnPuWnduDE9E3qKzhDBdtBAFflQCLg/B33W3DMwvo49C/cLvY11rH+4OvMyPRglx
G8wVW+Un+dU=
=MV91
-----END PGP SIGNATURE-----

--==_Exmh_1584603506_13116P--