Received: by 2002:a25:d783:0:0:0:0:0 with SMTP id o125csp400147ybg; Thu, 19 Mar 2020 01:45:46 -0700 (PDT) X-Google-Smtp-Source: ADFU+vuCNeIXtxxmYe/5YHC8xNVxcqs+M6gy8/qFtkEI0YHovlLHMmRkNI214NQCbvypboLOpxrx X-Received: by 2002:aca:724f:: with SMTP id p76mr549933oic.112.1584607546106; Thu, 19 Mar 2020 01:45:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584607546; cv=none; d=google.com; s=arc-20160816; b=GcWIX1BchxwyFYLUTpyNkGhKBHNM9rnkUWBRYTJMQ4Ey2l3u3k9XZse2Ls5R4KnLYl 90PkuxycTxnmQF+RUEqM+nyUEr/h7Kpx3eXgfxBUVg8vCMEGlJuKJXYhVxEs5eRLZg3Q TaUvSLAJSY7nTwOHFqR9BASSDbS+ftEIv8cdRKJ/l7aMS3eHRHteyeSk5KsuYr09RPW+ uTutpShE6HzVyQKzRyZTFPhmRpH6QG0t3lgGFZ+LNBRihb9dpp6R5BOnX+NMgKa8CnHi Nk9DdLb6xU/qI+B++n8F17NipVizw+8XKmLeqp9KBdC0Vy/zznXr5n1c93ArFbYHyDPE ej/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:message-id:references :in-reply-to:subject:cc:to:from:date:content-transfer-encoding :mime-version:dkim-signature; bh=qsz5pmj0rgyh4a5dT/Gw/3ooHpR4V5wv3aDoJIUbGmw=; b=JKHZ5J1Fwk3bu5kt4R4b6fOW1QtIy4e0g9YZDpyKWuO7hWdPqee1vxhz5BwWX2mxeJ tT1h1QUEEk/meqfQgMozPgsNTaxgWmGucoY2xeFexdrW08ABr4BITx4e+QUtpXwbJSjk 2uypBzgY3P6mjWZjlKwVCAhgfPiJDl/xobMaBUtgp3WiPJolgRcKYbGqqVQp3IwBaAEU ZSubQYSiR2N5pjWGnTc2wZJcmr1thWEkMz31kC1u+/TTuboVKv01rlrH15MN09X1bVC4 isxRAoRxj0YJ4WKwLb59tYEcsXKdZHaCWitu0JnF+KMw9pYT17PqJJH4vTreTUCXVt6G LlEg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=rf6u2PFm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f63si707161oib.85.2020.03.19.01.45.33; Thu, 19 Mar 2020 01:45:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=rf6u2PFm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726589AbgCSIpB (ORCPT + 99 others); Thu, 19 Mar 2020 04:45:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:57380 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725601AbgCSIpB (ORCPT ); Thu, 19 Mar 2020 04:45:01 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 48F9120724; Thu, 19 Mar 2020 08:45:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584607500; bh=nsLp4Rn/WbNgg5c0efrndSO2d36JwaT+wQJoqmu5/SA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=rf6u2PFmQqWvwY1WKpZe255t6/NQBguN0WrcCWUMycs3Keq2eiQSpMPlRJ9m4wGPW D9gF1iZzqBJ9KxJhaOg3VrMZxn58ybEA/Cq8b+OX/He/2rZLpAfZrQWm+Co8RbTj+6 QHy5OK5sHF9g1b0Fp66Nsw3p+Qi+iWNLXSMYaxO8= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jEqnS-00Dsyj-Cb; Thu, 19 Mar 2020 08:44:58 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 19 Mar 2020 08:44:58 +0000 From: Marc Zyngier To: Sungbo Eo Cc: Linus Walleij , Thomas Gleixner , Jason Cooper , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-oxnas@groups.io, Neil Armstrong Subject: Re: [PATCH v2] irqchip/versatile-fpga: Handle chained IRQs properly In-Reply-To: <20200319023448.1479701-1-mans0n@gorani.run> References: <002b72cab9896fa5ac76a52e0cb503ff@kernel.org> <20200319023448.1479701-1-mans0n@gorani.run> Message-ID: X-Sender: maz@kernel.org User-Agent: Roundcube Webmail/1.3.10 X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: mans0n@gorani.run, linus.walleij@linaro.org, tglx@linutronix.de, jason@lakedaemon.net, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-oxnas@groups.io, narmstrong@baylibre.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-03-19 02:34, Sungbo Eo wrote: > Enclose the chained handler with chained_irq_{enter,exit}(), so that > the > muxed interrupts get properly acked. > > This patch also fixes a reboot bug on OX820 SoC, where the jiffies > timer > interrupt is never acked. The kernel waits a clock tick forever in > calibrate_delay_converge(), which leads to a boot hang. > > Fixes: c41b16f8c9d9 ("ARM: integrator/versatile: consolidate FPGA IRQ > handling code") > Signed-off-by: Sungbo Eo > Cc: Neil Armstrong > --- > v2: moved readl below chained_irq_enter() > added Fixes tag > > drivers/irqchip/irq-versatile-fpga.c | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) Queued for 5.7. Thanks, M. -- Jazz is not dead. It just smells funny...