Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <5e730c2f.1c69fb81.9eda3.5c70@mx.google.com>
In-Reply-To: <5e730c2f.1c69fb81.9eda3.5c70@mx.google.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Thu, 19 Mar 2020 12:24:00 +0200
Message-ID: <CAHp75Vf+SA7ptRQRxvMtVfN0MzQeQ_AgzAP7fc3eaT5nmsxo_g@mail.gmail.com>
Subject: Re: [PATCH] iio: imu: inv_mpu6050: add debugfs register r/w interface
To:     Rohit Sarkar <rohitsarkar5398@gmail.com>
Cc:     linux-iio <linux-iio@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Jonathan Cameron <jic23@kernel.org>,
        Hartmut Knaack <knaack.h@gmx.de>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
        Jean-Baptiste Maneyrol <jmaneyrol@invensense.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Linus Walleij <linus.walleij@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Mar 19, 2020 at 8:10 AM Rohit Sarkar <rohitsarkar5398@gmail.com> wrote:
>
> The iio debugfs interface provides direct access to read and write device
> registers if debugfs is enabled.

But regmap API provides at least reading facility. Isn't it enough?

...

>  static const struct iio_info mpu_info = {
>         .read_raw = &inv_mpu6050_read_raw,
>         .write_raw = &inv_mpu6050_write_raw,
>         .write_raw_get_fmt = &inv_write_raw_get_fmt,
>         .attrs = &inv_attribute_group,
>         .validate_trigger = inv_mpu6050_validate_trigger,

> +       .debugfs_reg_access = &inv_mpu6050_reg_access

Leaving comma is helpful for future development.

>  };


-- 
With Best Regards,
Andy Shevchenko