Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200318171003.5179-1-jagan@amarulasolutions.com> <20200318185713.GA28092@ravnborg.org>
In-Reply-To: <20200318185713.GA28092@ravnborg.org>
From:   Jagan Teki <jagan@amarulasolutions.com>
Date:   Thu, 19 Mar 2020 16:06:30 +0530
Message-ID: <CAMty3ZAjmu+h7XTyTUfge3kXFE=a=1iFm7MjR6DYnQnZ615fOg@mail.gmail.com>
Subject: Re: [PATCH v2 1/3] dt-bindings: display: panel: Convert feiyang,
 fy07024di26a30d to DT schema
To:     Sam Ravnborg <sam@ravnborg.org>
Cc:     Thierry Reding <thierry.reding@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        devicetree <devicetree@vger.kernel.org>,
        David Airlie <airlied@linux.ie>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        linux-amarula <linux-amarula@amarulasolutions.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Sam,

On Thu, Mar 19, 2020 at 12:27 AM Sam Ravnborg <sam@ravnborg.org> wrote:
>
> Hi Jagan.
>
> On Wed, Mar 18, 2020 at 10:40:01PM +0530, Jagan Teki wrote:
> > Convert the feiyang,fy07024di26a30d panel bindings to DT schema.
> >
> > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
>
> Thanks for the resend.
>
> Please fix so the two bindings uses panel-common.yaml.

Is is because few of the bindings in this panel are similar to
panel-common.yaml?

>
> And then only properties specific for this binding shall have a
> description.
>
> See below - please fix both bindings and resend.
>
>         Sam
>
> > ---
> > Changes for v2:
> > - fix dt_binding_check
> >
> >  .../display/panel/feiyang,fy07024di26a30d.txt | 20 -------
> >  .../panel/feiyang,fy07024di26a30d.yaml        | 57 +++++++++++++++++++
> >  2 files changed, 57 insertions(+), 20 deletions(-)
> >  delete mode 100644 Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.txt
> >  create mode 100644 Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.txt b/Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.txt
> > deleted file mode 100644
> > index 82caa7b65ae8..000000000000
> > --- a/Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.txt
> > +++ /dev/null
> > @@ -1,20 +0,0 @@
> > -Feiyang FY07024DI26A30-D 7" MIPI-DSI LCD Panel
> > -
> > -Required properties:
> > -- compatible: must be "feiyang,fy07024di26a30d"
> > -- reg: DSI virtual channel used by that screen
> > -- avdd-supply: analog regulator dc1 switch
> > -- dvdd-supply: 3v3 digital regulator
> > -- reset-gpios: a GPIO phandle for the reset pin
> > -
> > -Optional properties:
> > -- backlight: phandle for the backlight control.
> > -
> > -panel@0 {
> > -     compatible = "feiyang,fy07024di26a30d";
> > -     reg = <0>;
> > -     avdd-supply = <&reg_dc1sw>;
> > -     dvdd-supply = <&reg_dldo2>;
> > -     reset-gpios = <&pio 3 24 GPIO_ACTIVE_HIGH>; /* LCD-RST: PD24 */
> > -     backlight = <&backlight>;
> > -};
> > diff --git a/Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.yaml b/Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.yaml
> > new file mode 100644
> > index 000000000000..f292c57a5bd6
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.yaml
> > @@ -0,0 +1,57 @@
> > +# SPDX-License-Identifier: (GPL-2.0+ OR X11)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/display/panel/feiyang,fy07024di26a30d.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Feiyang FY07024DI26A30-D 7" MIPI-DSI LCD Panel
> > +
> > +maintainers:
> > +  - Jagan Teki <jagan@amarulasolutions.com>
> > +
> > +properties:
> > +  compatible:
> > +    const: feiyang,fy07024di26a30d
> > +
> > +  reg:
> > +    description: DSI virtual channel used by that screen
> reg is already described elsewhere so no description.
> Thus is becomes:
>
>     reg: true

Look like reg didn't describe in panel-common.yaml

Jagan.