Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 19 Mar 2020 11:38:34 +0100 (CET)
From:   Miroslav Benes <mbenes@suse.cz>
To:     Jan Beulich <jbeulich@suse.com>
cc:     boris.ostrovsky@oracle.com, jgross@suse.com,
        sstabellini@kernel.org, tglx@linutronix.de, mingo@redhat.com,
        bp@alien8.de, hpa@zytor.com, jpoimboe@redhat.com,
        andrew.cooper3@citrix.com, x86@kernel.org,
        linux-kernel@vger.kernel.org, live-patching@vger.kernel.org,
        xen-devel@lists.xenproject.org, jslaby@suse.cz
Subject: Re: [PATCH v2 2/2] x86/xen: Make the secondary CPU idle tasks
 reliable
In-Reply-To: <2ca0a03c-734c-3a9e-90fd-8209046c5f01@suse.com>
Message-ID: <alpine.LSU.2.21.2003191131280.24428@pobox.suse.cz>
References: <20200319095606.23627-1-mbenes@suse.cz> <20200319095606.23627-3-mbenes@suse.cz> <2ca0a03c-734c-3a9e-90fd-8209046c5f01@suse.com>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 19 Mar 2020, Jan Beulich wrote:

> On 19.03.2020 10:56, Miroslav Benes wrote:
> > --- a/arch/x86/xen/smp_pv.c
> > +++ b/arch/x86/xen/smp_pv.c
> > @@ -53,6 +53,7 @@ static DEFINE_PER_CPU(struct xen_common_irq, xen_irq_work) = { .irq = -1 };
> >  static DEFINE_PER_CPU(struct xen_common_irq, xen_pmu_irq) = { .irq = -1 };
> >  
> >  static irqreturn_t xen_irq_work_interrupt(int irq, void *dev_id);
> > +extern unsigned char asm_cpu_bringup_and_idle[];
> 
> Imo this would better reflect the actual type, i.e. be a function
> decl. If left as an array one, I guess you may want to add const.

I sticked to what x86 has for secondary_startup_64. I can make it

void asm_cpu_bringup_and_idle(void);

Miroslav