Received: by 2002:a25:d783:0:0:0:0:0 with SMTP id o125csp498242ybg; Thu, 19 Mar 2020 03:45:04 -0700 (PDT) X-Google-Smtp-Source: ADFU+vucr+cpmLzPPSpOgxNu/q5kS/VAVhBpQgwHeNvpHOyENiyhbwFGvLxLL3bdL88w55WYo9CW X-Received: by 2002:aca:ef82:: with SMTP id n124mr1740829oih.73.1584614704049; Thu, 19 Mar 2020 03:45:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584614704; cv=none; d=google.com; s=arc-20160816; b=nL29cvu85oP36CBfnnVHPQbF/yMMUyitFafD5X6qMjfeZmf7XCU0f9mXG7DpC3rjpz s8MlZ+dB6Pb0vRqEAydzC8snpUXc72mGpjEaBypwed7sQ0GgranLKi41RT3eMsUSbQBH t0q8cUwVqs+kdf4ZO5HsqrFdwWi+12c/QbEJft0ltiG5HuYURKj+cW8ZEJMI6zzo39mR FEhYMhPIf7dFyXSpach820yS79hKU/p2xA0c/LDU6AO62vUMP4V9ssIYlKZX3CNM025D JttrYBcejEE2XYeEdpiMdz2iTl68zScc7FoViZl+nDKEq8sO70HvE1yYyE1Q0/Sx/0/C 840Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=Y2aRXaeoTLh7dktyPjKj0jzvJY8J3ygeQfIzNeVPSOo=; b=BsfzF0afQmtlK/QwgrKXiAdUAAdDcw8Eb3INIlOWHb5shl0hF4wgEw5UZHc/BaoH5U tk32AGXKpcpSCdj3i6gx3KZrfUP3sDXeTpldMYPLCO+JiNFuOsg25LC76zRbTU6z4g6v u3PzV1JpVVee7iKg8cUD0+Zi1QWRw2PygJ8ZcW5BiTSF3YswTN5/1FVSQBRaPtOmkYN0 uffENvz1i44srAY3yYSZnxbJHbB9ziIDHOrmovN3fjwFvynaSvasoWGPT1ij4jdFN2qU 6+J/cnftakpS0PDKeIoJWY++PJVRWa5hw7c3hE5B9/vyze+81sznLZFFeCNsUuyAHW1C pQEg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=virtuozzo.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q13si1056751otn.141.2020.03.19.03.44.50; Thu, 19 Mar 2020 03:45:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=virtuozzo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726983AbgCSKnG (ORCPT + 99 others); Thu, 19 Mar 2020 06:43:06 -0400 Received: from relay.sw.ru ([185.231.240.75]:43536 "EHLO relay.sw.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726911AbgCSKnG (ORCPT ); Thu, 19 Mar 2020 06:43:06 -0400 Received: from [192.168.15.99] by relay.sw.ru with esmtp (Exim 4.92.3) (envelope-from ) id 1jEscu-0005aV-EY; Thu, 19 Mar 2020 13:42:12 +0300 Subject: Re: [PATCH v7 0/6] block: Introduce REQ_ALLOCATE flag for REQ_OP_WRITE_ZEROES To: Christoph Hellwig , martin.petersen@oracle.com Cc: axboe@kernel.dk, bob.liu@oracle.com, darrick.wong@oracle.com, agk@redhat.com, snitzer@redhat.com, dm-devel@redhat.com, song@kernel.org, tytso@mit.edu, adilger.kernel@dilger.ca, Chaitanya.Kulkarni@wdc.com, ming.lei@redhat.com, osandov@fb.com, jthumshirn@suse.de, minwoo.im.dev@gmail.com, damien.lemoal@wdc.com, andrea.parri@amarulasolutions.com, hare@suse.com, tj@kernel.org, ajay.joshi@wdc.com, sagi@grimberg.me, dsterba@suse.com, bvanassche@acm.org, dhowells@redhat.com, asml.silence@gmail.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org References: <158157930219.111879.12072477040351921368.stgit@localhost.localdomain> <69c0b8a4-656f-98c4-eb55-2fd1184f5fc9@virtuozzo.com> <67d63190-c16f-cd26-6b67-641c8943dc3d@virtuozzo.com> <20200319102819.GA26418@infradead.org> From: Kirill Tkhai Message-ID: Date: Thu, 19 Mar 2020 13:42:11 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200319102819.GA26418@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19.03.2020 13:28, Christoph Hellwig wrote: > On Fri, Mar 13, 2020 at 04:08:58PM +0300, Kirill Tkhai wrote: >> I just don't understand the reason nothing happens :( >> I see newly-sent patches comes fast into block tree. >> But there is only silence... I grepped over Documentation, >> and there is no special rules about block tree. So, >> it looks like standard rules should be applyable. >> >> Some comments? Some requests for reworking? Some personal reasons to ignore my patches? > > I'm still completely opposed to the magic overloading using a flag. > That is just a bad design waiting for trouble to happen. This flag is suggested by Martin Petersen, while the first version of the patchset was based on a separate operation. Since I see only Jens in MAINTAINERS: BLOCK LAYER M: Jens Axboe L: linux-block@vger.kernel.org T: git git://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git S: Maintained F: block/ F: drivers/block/ F: kernel/trace/blktrace.c F: lib/sbitmap.c I expect his comments about final design of this, because both you and Martin are maintainers of another subsystems. I don't want rework this many times until Jens says he wants some third design. I think I'm pretty polite and patient in my waiting, while Jens completely ignores me by some reasons, which are completely unclear for me. I don't think this is completely polite in relation to me. Kirill