Received: by 2002:a25:d783:0:0:0:0:0 with SMTP id o125csp614161ybg; Thu, 19 Mar 2020 05:50:09 -0700 (PDT) X-Google-Smtp-Source: ADFU+vsbCVatb5kHUa86gEGl7qoNK8mUFzKtDbu1sz3ezegnkYG+Q8HNqnksv7gi91qpV9DviQuQ X-Received: by 2002:a9d:6c58:: with SMTP id g24mr2093935otq.106.1584622208943; Thu, 19 Mar 2020 05:50:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584622208; cv=none; d=google.com; s=arc-20160816; b=fCoZ1Y3ee1KyCd3wKU5g8vbB4gl9Vrnwb2PStMIWB1nV7MIu/wkdH5lSdbc+el6ney nDI9PID+89G5jWvbmXPpKU35o/z0uL0FXbpspnB8Lf3RNY2G/Wmel1WFXurpNUPMDq2T mLV9XyQLjU5Okfk+KfRmjlr41mQmEXb83+jvvzxVmw/J9pUfpSlj7tXrNnBIjQwX5ZRG lB3XIQpjXCaAtlivfORuqWBoi7LXwJDeokJRTKjtsC13b4RfPLqprJy3LPXXiJGXWmuc +F8uxbQfF1WbmHIGmx/J432cc+TeM/b++CqjHSqHybBGybrICpU4y8kvsbDSgGvTm6iW vIMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=ClZxlMhKdTHfajskxZDRWXcL3ALgK+kLArLrTOCwgyw=; b=DQ66yEjW2ok5RCxxP6286McztUwJwb9jniot8JhYugXiXIszXTR4vnyxCn/agNhr+d I1jYwBJyhj+bQbVpmNRd9oj+SRtsYPWIwLGSGt8/M0y7fRV0FCX5KRKRzo4nNLx+34HO LxN003y6WeZbz/byGDj4WYEsFQi0JGZofwhmxXfFjlgDRxdzanq0RJCpM9yExwBsNJP4 KLYqaEaiDX0SgaVwEIpe7nMBDmmZPk9xYr55/UqyvLeGOM6LUHVVxn3FIHP1Dt+RwwDX QD83kZV9dVaStO7VQtP4Th3cXbs4pcmLVZ03rbjdj1Yxt59SrCUbq+c8kdan0OsaImRo nxMw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="M/71xg2N"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p12si1222728otq.62.2020.03.19.05.49.56; Thu, 19 Mar 2020 05:50:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="M/71xg2N"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727009AbgCSMst (ORCPT + 99 others); Thu, 19 Mar 2020 08:48:49 -0400 Received: from mail-lf1-f66.google.com ([209.85.167.66]:39475 "EHLO mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726589AbgCSMst (ORCPT ); Thu, 19 Mar 2020 08:48:49 -0400 Received: by mail-lf1-f66.google.com with SMTP id j15so1507237lfk.6 for ; Thu, 19 Mar 2020 05:48:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ClZxlMhKdTHfajskxZDRWXcL3ALgK+kLArLrTOCwgyw=; b=M/71xg2N4jYJ2rI7E2oJ6vVQN2VbgmjAhziH1DJKvHak/gbDELAL2mO55GZLOCp67S 9gvkRaVfvjs6x0IVR4w6bKeGeVVH65N+M66tTsGukJHmWlFFsXpIWU39O5hnNTvCHIbW iOAdFjQUGMnx/pCC3hysWQ6Eby/an59wWRPQ1ZX0NBj8/Am7JDVgvVsZol7c7RNamEBH RPwr5tdHz7EmC0Fr0bvs3GNrJai9FdZjhurFiuOYR/WP/paWWYN8CZK6+dM+pVS5bLcM tdQj9ZooVU48jG4ofvosZyzbfCijpc2McmOnq9hVR2uxT5Ye1NC2HtNkoYMJYnv+Tbak xOuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ClZxlMhKdTHfajskxZDRWXcL3ALgK+kLArLrTOCwgyw=; b=l+ys974tScjhwXzoTsHpUbACEIO2qhemjPqVuwFEXkbKyC9+qfzH3qd3Z5W0qBtF5C pTonUjn9rLBHnhj6dkMpPpICppJzFEsEsMvmMnlVx76v+6nq+yP2VvtvAT8xuF9vb9ov 9eaqqyuou5PfUH510gNbH3gP/LoduglM20c3fZlmCUoqOUDBSs1ZXpXKB0t6pmke4Dr6 ULTiovVN7WbC2C8VfXHHnxyn88UJrJRmfFkwPWgFeYyAkhfPYOsKxe5FdyNNxqxKJ8e1 VoabMCpn6gb8LLWKZ3V4Y9Vf7jQqP+/kLytVuDNKajTywkpo3AZsnYxhWzXhynh8KvD2 kENw== X-Gm-Message-State: ANhLgQ2vwlBFBXR9kF1ZNH3V3Y2FsiaDPl2JnL+vnWmUHS5T+MWUcqAn d19v617SNbHONaj/2pZHZj1vhg== X-Received: by 2002:ac2:5587:: with SMTP id v7mr2105554lfg.198.1584622126779; Thu, 19 Mar 2020 05:48:46 -0700 (PDT) Received: from localhost (c-413e70d5.07-21-73746f28.bbcust.telenor.se. [213.112.62.65]) by smtp.gmail.com with ESMTPSA id r18sm1578017lji.16.2020.03.19.05.48.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2020 05:48:46 -0700 (PDT) From: Anders Roxell To: jingoohan1@gmail.com, gustavo.pimentel@synopsys.com, lorenzo.pieralisi@arm.com, bhelgaas@google.com Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Anders Roxell Subject: [PATCH] PCI: dwc: fix ERROR: modpost: dw_pcie_ep_*.o undefined Date: Thu, 19 Mar 2020 13:48:32 +0100 Message-Id: <20200319124832.15165-1-anders.roxell@linaro.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When building the PCIE_TEGRA194 as a module the common parts are build-in. That leads us to the following modpost error: ERROR: modpost: "dw_pcie_ep_init" [drivers/pci/controller/dwc/pcie-tegra194.ko] undefined! ERROR: modpost: "dw_pcie_ep_linkup" [drivers/pci/controller/dwc/pcie-tegra194.ko] undefined! ERROR: modpost: "dw_pcie_ep_init_notify" [drivers/pci/controller/dwc/pcie-tegra194.ko] undefined! ERROR: modpost: "dw_pcie_ep_init_complete" [drivers/pci/controller/dwc/pcie-tegra194.ko] undefined! make[2]: *** [../scripts/Makefile.modpost:94: __modpost] Error 1 make[1]: *** [/linux/Makefile:1298: modules] Error 2 make: *** [Makefile:180: sub-make] Error 2 make: Target 'modules' not remade because of errors. Rework to EXPORT_SYMBOL_GPL for those functions. Fixes: 5b645b7fade9 ("PCI: tegra: Add support for PCIe endpoint mode in Tegra194") Signed-off-by: Anders Roxell --- drivers/pci/controller/dwc/pcie-designware-ep.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/pci/controller/dwc/pcie-designware-ep.c b/drivers/pci/controller/dwc/pcie-designware-ep.c index 4233c4321373..1cdcbd102ce8 100644 --- a/drivers/pci/controller/dwc/pcie-designware-ep.c +++ b/drivers/pci/controller/dwc/pcie-designware-ep.c @@ -18,6 +18,7 @@ void dw_pcie_ep_linkup(struct dw_pcie_ep *ep) pci_epc_linkup(epc); } +EXPORT_SYMBOL_GPL(dw_pcie_ep_linkup); void dw_pcie_ep_init_notify(struct dw_pcie_ep *ep) { @@ -25,6 +26,7 @@ void dw_pcie_ep_init_notify(struct dw_pcie_ep *ep) pci_epc_init_notify(epc); } +EXPORT_SYMBOL_GPL(dw_pcie_ep_init_notify); static void __dw_pcie_ep_reset_bar(struct dw_pcie *pci, enum pci_barno bar, int flags) @@ -535,6 +537,7 @@ int dw_pcie_ep_init_complete(struct dw_pcie_ep *ep) return 0; } +EXPORT_SYMBOL_GPL(dw_pcie_ep_init_complete); int dw_pcie_ep_init(struct dw_pcie_ep *ep) { @@ -629,3 +632,4 @@ int dw_pcie_ep_init(struct dw_pcie_ep *ep) return dw_pcie_ep_init_complete(ep); } +EXPORT_SYMBOL_GPL(dw_pcie_ep_init); -- 2.20.1