Received: by 2002:a25:d783:0:0:0:0:0 with SMTP id o125csp651385ybg; Thu, 19 Mar 2020 06:26:00 -0700 (PDT) X-Google-Smtp-Source: ADFU+vtRGWa1CdxlnwOMetsH+/c6NBESrKQX3kt+KEsjja0VQrP0n1bcsBZ+oWXYgMvzlkkNd5Jp X-Received: by 2002:a54:478c:: with SMTP id o12mr2206831oic.106.1584624360740; Thu, 19 Mar 2020 06:26:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584624360; cv=none; d=google.com; s=arc-20160816; b=EXD3HNR0P/C9HwOiXyF2Uk7ktHBuOQPQbr8rhB88B9HgKtXIP5SfQwlYi6RNf7jWIk tw7RLCBs++j9AFOGOy4Y0bkuITEDu3IC50HEGs9fqtSD3PEtJ3QCQQP3Pan4IopMqVH5 73XajSnicSc8Ih+UKfrUDKPL7WPUGIosXyHNjkJJaFSakcB/6rcHf2jp89Jp2YbAhH/2 VCs+zC/yt6GuHK0aqrjZvY/2Jqp81oLV3y8b5mfpDmHlKhdUZvN0TEEpzk6ZZrC/S600 IA1COhUBMeRMbuiKUq1mtNufTRMJdRPSRpFrRfnsZ78qca48ES3uNSiBFB6y4yWQ9fX1 m5og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=64IaLJ/UoVVsWyxaJmq7OZKW/vmDH0lZ5da4n5xcRYs=; b=AVIJnl/LkEpt1yBqcFQ/G0zAWB4Jn/IY/hFWGcobMPscrXjOM4co53hAAo/g2Z8ecd /bQjY1kNSqz80rNZx6cqJ36M9nGDrwUxN5Pj3gcFhssTRMe7OmVJBoia6Na0yIpnZTIc 5A/pSGveQIlK+7bD4ka88uH3hGCfIpBTaWhtN3433oQRuGcGz0uM5DuBg/HzC9/cfqk0 MotwRtsBTGqUmNAXboi3UlLtz0vJqtZOu7Swvvh36IBQXrGJ/zKhIfiOShBChaKRqr2t pqsuXZtLU/X7EM17TpvWoIQlWM3foSAyRfmzbdmylVOX0Wr+iK9/s/OXWwAvUjV9LQ+y IhLg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=2aokacV0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s200si1021479oie.188.2020.03.19.06.25.48; Thu, 19 Mar 2020 06:26:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=2aokacV0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730635AbgCSNZa (ORCPT + 99 others); Thu, 19 Mar 2020 09:25:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:53058 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730626AbgCSNZ2 (ORCPT ); Thu, 19 Mar 2020 09:25:28 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E61CA208D6; Thu, 19 Mar 2020 13:25:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584624328; bh=iUS63HzURkdNWPqhwTnoxFpkn4beUpwEPN/ZA6lYULI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2aokacV097h9yXuwxN8Xz09PtUSjmilIkmGOfvSUNAJzcldy2yXYF9Eo7dFkjudaw uuQxAGSUMw2rlojEMWiPZey7Fwsaz3v707xtk/25BLmSjjIm9+PFL+BMih6Nh8e0cp I1dF6u5lCdLgjs0UnSZkfoGymH+8tiDBmIV+bA00= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Johannes Berg , Sasha Levin Subject: [PATCH 5.5 24/65] cfg80211: check reg_rule for NULL in handle_channel_custom() Date: Thu, 19 Mar 2020 14:04:06 +0100 Message-Id: <20200319123934.021795100@linuxfoundation.org> X-Mailer: git-send-email 2.25.2 In-Reply-To: <20200319123926.466988514@linuxfoundation.org> References: <20200319123926.466988514@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Johannes Berg [ Upstream commit a7ee7d44b57c9ae174088e53a668852b7f4f452d ] We may end up with a NULL reg_rule after the loop in handle_channel_custom() if the bandwidth didn't fit, check if this is the case and bail out if so. Signed-off-by: Johannes Berg Link: https://lore.kernel.org/r/20200221104449.3b558a50201c.I4ad3725c4dacaefd2d18d3cc65ba6d18acd5dbfe@changeid Signed-off-by: Johannes Berg Signed-off-by: Sasha Levin --- net/wireless/reg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/wireless/reg.c b/net/wireless/reg.c index fff9a74891fc4..1a8218f1bbe07 100644 --- a/net/wireless/reg.c +++ b/net/wireless/reg.c @@ -2276,7 +2276,7 @@ static void handle_channel_custom(struct wiphy *wiphy, break; } - if (IS_ERR(reg_rule)) { + if (IS_ERR_OR_NULL(reg_rule)) { pr_debug("Disabling freq %d MHz as custom regd has no rule that fits it\n", chan->center_freq); if (wiphy->regulatory_flags & REGULATORY_WIPHY_SELF_MANAGED) { -- 2.20.1