Received: by 2002:a25:d783:0:0:0:0:0 with SMTP id o125csp652680ybg; Thu, 19 Mar 2020 06:27:13 -0700 (PDT) X-Google-Smtp-Source: ADFU+vuKq5lqZU/6QQA0FUgI0tt2WT9N4DW5cTLVUX/e/OwxGcYRgJpmLB5GlI0MAuVgB+lAIVfM X-Received: by 2002:aca:cc41:: with SMTP id c62mr2390602oig.58.1584624432295; Thu, 19 Mar 2020 06:27:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584624432; cv=none; d=google.com; s=arc-20160816; b=y3H8ZK1/oL/v/W8PJ8OL60d5kjnqGu0cqkVZJiyU6Iq7jdzxN/5m55UJ2MMHnr8zoN WX3l9vGC/01omf/dqdLhYPFo3nB9rbB5Hbf7izCIGPBS1YAayvfVH4WBXhvWYELvnpaT BPQaE2/07PKf3o12RUP3LJ5OMlUmNRTG8yin1jGNUWSEfwPurqxqt22ccA8p+XRuh7M9 T0TAXWAfrV1V6ESYDiUcNLjd41wFy3LfU2a6EbXQzv3cNNv3iaCFlDuxNBa+I7xRVhJk JzIRaof87rxTfqWkGAsb/q/27SZGIfbjlYj1RGPvz0FO0jF2iVipjQqZvlYlefF6VsZ7 yM1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=rJ2XsCFG4dQfpvBPVPkeGn84h3ipD6sVwpf5m8g5r8k=; b=GbFtC6QvfbBRmgemfj+kENR0ruPrxgpU0Uan9FYZeIFYWrPMX1HDPKfTgd4GHNGSq6 dRtdu8VO0FE7tDztnvTQCTzYzcMAx5SWEYPl5fgN5FF45ALrr7j/ndlW2S+SVSgO7Jj1 EuIgtlWQOu1ikwgTAqQwytI7tP8quAIphXRvaRRZ7R1jlW6UpKwy3ShfCShFlEdV1YYj 1SsqMpZUeJGx3OajQYBB+D+DzxQbcMndmM5UyS27hUBQsEh5BNzuGGfrbJFBM7W2c761 TUYNSkQw3V5n0fJ2Zs1V9FWledtnTMryS7b/O40vOzPnHFn/V0rURQNgkDyGtbjQgpyY EgoQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=C7wV8bA2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r29si1333802oth.324.2020.03.19.06.27.00; Thu, 19 Mar 2020 06:27:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=C7wV8bA2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730444AbgCSNZl (ORCPT + 99 others); Thu, 19 Mar 2020 09:25:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:53330 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730655AbgCSNZk (ORCPT ); Thu, 19 Mar 2020 09:25:40 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4AE1C214D8; Thu, 19 Mar 2020 13:25:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584624338; bh=YAFvu5ij+AyAowyPL31UII9ZhMcFpurD7oRq4jnXm+Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=C7wV8bA28ZfK9Is1qsSJB3/gz230DlFzCUSSDPnAoUQ8HL+Qh0gurZx95qYbqc7Ml 0NQ57kGkspNmXVVFiKI3zLL2MunNUDZMVGBMB632gFPSyLT0ImP5X3DBnJJnfr/G04 wbPlnvZDnBU8eVBXzY1An7WXeU60irhOZKU3BqGU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Mansour Behabadi , Jiri Kosina , Sasha Levin Subject: [PATCH 5.5 10/65] HID: apple: Add support for recent firmware on Magic Keyboards Date: Thu, 19 Mar 2020 14:03:52 +0100 Message-Id: <20200319123929.495355777@linuxfoundation.org> X-Mailer: git-send-email 2.25.2 In-Reply-To: <20200319123926.466988514@linuxfoundation.org> References: <20200319123926.466988514@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mansour Behabadi [ Upstream commit e433be929e63265b7412478eb7ff271467aee2d7 ] Magic Keyboards with more recent firmware (0x0100) report Fn key differently. Without this patch, Fn key may not behave as expected and may not be configurable via hid_apple fnmode module parameter. Signed-off-by: Mansour Behabadi Signed-off-by: Jiri Kosina Signed-off-by: Sasha Levin --- drivers/hid/hid-apple.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c index 6ac8becc2372e..d732d1d10cafb 100644 --- a/drivers/hid/hid-apple.c +++ b/drivers/hid/hid-apple.c @@ -340,7 +340,8 @@ static int apple_input_mapping(struct hid_device *hdev, struct hid_input *hi, unsigned long **bit, int *max) { if (usage->hid == (HID_UP_CUSTOM | 0x0003) || - usage->hid == (HID_UP_MSVENDOR | 0x0003)) { + usage->hid == (HID_UP_MSVENDOR | 0x0003) || + usage->hid == (HID_UP_HPVENDOR2 | 0x0003)) { /* The fn key on Apple USB keyboards */ set_bit(EV_REP, hi->input->evbit); hid_map_usage_clear(hi, usage, bit, max, EV_KEY, KEY_FN); -- 2.20.1