Received: by 2002:a25:d783:0:0:0:0:0 with SMTP id o125csp653161ybg; Thu, 19 Mar 2020 06:27:41 -0700 (PDT) X-Google-Smtp-Source: ADFU+vt5MfEEv6m31Ij05C00+jhxcO1wqYwQQUpfvSpfVJGkA28gnmwZhzE5Yo9TVbzc5SzFmcW5 X-Received: by 2002:a9d:470c:: with SMTP id a12mr2177957otf.372.1584624461301; Thu, 19 Mar 2020 06:27:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584624461; cv=none; d=google.com; s=arc-20160816; b=yC/0CsAe7z/JKJ6QRqn0ybujitp4RayWYraVbHi2HQsUmm/MAyGbZPsahye0jLYPD/ 5laRVy9RCqB5xVh9moFjx2BFiR22NhMmb1g5gAjqDZcwIojPdR6VrkN5QiSyqVnbw0Hs iY5EA45R+0M1k+MO108dWvFlRm8UuRHcugyln4x4dl0sltgel89GXMtwG52S/Vo3fydH NgzIn9zgJxMUIxZGwybnNH3jPbuQZPM5kWpDaTmqqiyrkkWKBxMphpAioZnpOABlI0XT L5x+xJQqyePjirJ+F7tpj29NQJuw6Fx51nDOV2rkXUcAm4oNdAaph9igBuAlIEhsFFGS f8dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=vxRvS5BAWytAqSiw78P5c6Sr9TcmLEvTZloOhZaVvFE=; b=Rcf6YmTM/omoyP1J30ISeqRHy1oziVEucxWH04LqXqWb3vYfXmnVquDmZz7qUIt18M pCiWBgx4NNqEX9rHpmQWLRq31m15B5+oUbV0AcCuO1BHgJhqBSKEVc2JtU7XE0ZcNZtP TwOHEHIIpir0r7KURrQ4f2DaF1SuF0zDy/hx76Ys5JNirwJnWhyqbF0rAy4mjViPLEzb X9DaQrvu+8Y7cZT/tA3+uMH7+z3Fn9fxP4Sem1zDw2tVgFyYJG96Z0ROCFfPyE7QReJ8 djkZsvY593UHgN6rX4Qu7e69XTsDSPaOmw/XsuBcrynOUgiOVn9LrgO8d+QVgI4XGgii lRTg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=bByQC7p8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n5si1164912otk.178.2020.03.19.06.27.29; Thu, 19 Mar 2020 06:27:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=bByQC7p8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730619AbgCSN02 (ORCPT + 99 others); Thu, 19 Mar 2020 09:26:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:54386 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730785AbgCSN0Z (ORCPT ); Thu, 19 Mar 2020 09:26:25 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6E6E52080C; Thu, 19 Mar 2020 13:26:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584624384; bh=SBlGPjDxTktVE+Zjo7EzEDmtdlPEaGueBE/SF2K63Ks=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bByQC7p8l/GVzdNxwHaI59+5syI5xdKGo819/fT8EjTxpctNU/a75CqswbpH8x+V5 FiLZiahsRlvU8rBG+QfdplRSD5QcHiGXQyfc+d+UR3sf1jdFShi4sDiaJpXNvFsSf3 M606aPyUDo/GU5+HrmEgvoRUhWUh1Czp1E4j1a7I= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Luo bin , "David S. Miller" , Sasha Levin Subject: [PATCH 5.5 44/65] hinic: fix a bug of setting hw_ioctxt Date: Thu, 19 Mar 2020 14:04:26 +0100 Message-Id: <20200319123940.368966688@linuxfoundation.org> X-Mailer: git-send-email 2.25.2 In-Reply-To: <20200319123926.466988514@linuxfoundation.org> References: <20200319123926.466988514@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Luo bin [ Upstream commit d2ed69ce9ed3477e2a9527e6b89fe4689d99510e ] a reserved field is used to signify prime physical function index in the latest firmware version, so we must assign a value to it correctly Signed-off-by: Luo bin Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c | 1 + drivers/net/ethernet/huawei/hinic/hinic_hw_dev.h | 2 +- drivers/net/ethernet/huawei/hinic/hinic_hw_if.h | 1 + 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c b/drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c index 6f2cf569a283c..79b3d53f2fbfa 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c @@ -297,6 +297,7 @@ static int set_hw_ioctxt(struct hinic_hwdev *hwdev, unsigned int rq_depth, } hw_ioctxt.func_idx = HINIC_HWIF_FUNC_IDX(hwif); + hw_ioctxt.ppf_idx = HINIC_HWIF_PPF_IDX(hwif); hw_ioctxt.set_cmdq_depth = HW_IOCTXT_SET_CMDQ_DEPTH_DEFAULT; hw_ioctxt.cmdq_depth = 0; diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hw_dev.h b/drivers/net/ethernet/huawei/hinic/hinic_hw_dev.h index b069045de416c..66fd2340d4479 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_hw_dev.h +++ b/drivers/net/ethernet/huawei/hinic/hinic_hw_dev.h @@ -151,8 +151,8 @@ struct hinic_cmd_hw_ioctxt { u8 lro_en; u8 rsvd3; + u8 ppf_idx; u8 rsvd4; - u8 rsvd5; u16 rq_depth; u16 rx_buf_sz_idx; diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hw_if.h b/drivers/net/ethernet/huawei/hinic/hinic_hw_if.h index 517794509eb29..c7bb9ceca72ca 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_hw_if.h +++ b/drivers/net/ethernet/huawei/hinic/hinic_hw_if.h @@ -137,6 +137,7 @@ #define HINIC_HWIF_FUNC_IDX(hwif) ((hwif)->attr.func_idx) #define HINIC_HWIF_PCI_INTF(hwif) ((hwif)->attr.pci_intf_idx) #define HINIC_HWIF_PF_IDX(hwif) ((hwif)->attr.pf_idx) +#define HINIC_HWIF_PPF_IDX(hwif) ((hwif)->attr.ppf_idx) #define HINIC_FUNC_TYPE(hwif) ((hwif)->attr.func_type) #define HINIC_IS_PF(hwif) (HINIC_FUNC_TYPE(hwif) == HINIC_PF) -- 2.20.1