Received: by 2002:a25:d783:0:0:0:0:0 with SMTP id o125csp654844ybg; Thu, 19 Mar 2020 06:29:24 -0700 (PDT) X-Google-Smtp-Source: ADFU+vsX8EBnkQ7EJVQkEv9wZBToHNlY60xitAxE0MU+KxNGuPDxyKcsc+PkclbtYZO79hzmU5jq X-Received: by 2002:a05:6830:3109:: with SMTP id b9mr2403863ots.369.1584624564140; Thu, 19 Mar 2020 06:29:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584624564; cv=none; d=google.com; s=arc-20160816; b=h2bLOi8Ggw54EfdFMxxcLP0QuuSIVZdPPEA6TmZGwFZYQhtihpeqbl7vxJGqaYkE7m YAkz+7Egadmo5W+s5eZPCUEi62dieXSJuppwQTbJFL5R0LJmeLzkxenO3NMAiC96PaYj 5Qs3BAZFz0Om8upY5WAsgl40TIrW89MQwTnscRCjbZ5CRYz6el3I5/YMrllpvAeVaLEc ApqTRSOsxu1rIKBf6RnQlvAvk1Do/sXT80iAI9vlBk3ySERbDYkqvyGXksdoCGIX6FPw 45UONhTns2nDl80Tdwm22aechgRHj2RosuCVWIIyDc8FZ3uy+2C7SKw11LjKmVGbFDrD RhkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=GS3gYmgY4IvL3GM0jEhN8r+gS8wQXtKCs29vubf6axs=; b=G0wz51cpz3ll7Goso0/M+AtcDldGUg7CCT9dW4zxcfPDmsarIbLWSeRur/mFmA6UdD KrKK9f19A5XletVYHp09PdoLscgxqd50Bh6BRNIHhg0D7srvjfLVsAhhj5hU5uWB8lS0 Fto4HfCl/YzZmDWsXvLgCoagJOhc6l13wb/TvgOhR021VhIXsZkErNsD69ai1Hi3zpoH QPTd6UBfpu+zRHaF83ad4XXOx4IWcEANHPbew7/WJp2PhhfIfQ2Y70hGgWmAmyJgVJgT uNuwnj9KJQItFLo8e5v3qej1lOfy3E11dKKmK7ItLls4M551zVDMpbclyuFydzroFV+G d0gg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=pJE8zY3z; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a66si1231205otb.65.2020.03.19.06.29.11; Thu, 19 Mar 2020 06:29:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=pJE8zY3z; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730850AbgCSN2N (ORCPT + 99 others); Thu, 19 Mar 2020 09:28:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:56266 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730939AbgCSN1s (ORCPT ); Thu, 19 Mar 2020 09:27:48 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5B3CA20B80; Thu, 19 Mar 2020 13:27:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584624467; bh=GBW4HS3rcU46yI/YSEUk0+2oIxX7o1ouHTysQw84VJE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pJE8zY3zFiHu1G9GgaeObnTvoqvho2FamydIMZ/2me2qdommr6cVvo9fza2KFu8mb sk995LTuFBHpQg0E9S3Ve6S0Li8I8g0onqIXgfRU0IIGYPJl7DFVqshrYMipIuRB6M 62fZ7mxNC5Bx+/kPDFr7nj5IqRcAtHnBB1EFsH2Q= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Amit Cohen , Ido Schimmel , Jiri Pirko , "David S. Miller" , Sasha Levin Subject: [PATCH 5.5 55/65] mlxsw: pci: Wait longer before accessing the device after reset Date: Thu, 19 Mar 2020 14:04:37 +0100 Message-Id: <20200319123943.593234706@linuxfoundation.org> X-Mailer: git-send-email 2.25.2 In-Reply-To: <20200319123926.466988514@linuxfoundation.org> References: <20200319123926.466988514@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Amit Cohen [ Upstream commit ac004e84164e27d69017731a97b11402a69d854b ] During initialization the driver issues a reset to the device and waits for 100ms before checking if the firmware is ready. The waiting is necessary because before that the device is irresponsive and the first read can result in a completion timeout. While 100ms is sufficient for Spectrum-1 and Spectrum-2, it is insufficient for Spectrum-3. Fix this by increasing the timeout to 200ms. Fixes: da382875c616 ("mlxsw: spectrum: Extend to support Spectrum-3 ASIC") Signed-off-by: Amit Cohen Signed-off-by: Ido Schimmel Signed-off-by: Jiri Pirko Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/mellanox/mlxsw/pci_hw.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlxsw/pci_hw.h b/drivers/net/ethernet/mellanox/mlxsw/pci_hw.h index e0d7d2d9a0c81..43fa8c85b5d9f 100644 --- a/drivers/net/ethernet/mellanox/mlxsw/pci_hw.h +++ b/drivers/net/ethernet/mellanox/mlxsw/pci_hw.h @@ -28,7 +28,7 @@ #define MLXSW_PCI_SW_RESET 0xF0010 #define MLXSW_PCI_SW_RESET_RST_BIT BIT(0) #define MLXSW_PCI_SW_RESET_TIMEOUT_MSECS 900000 -#define MLXSW_PCI_SW_RESET_WAIT_MSECS 100 +#define MLXSW_PCI_SW_RESET_WAIT_MSECS 200 #define MLXSW_PCI_FW_READY 0xA1844 #define MLXSW_PCI_FW_READY_MASK 0xFFFF #define MLXSW_PCI_FW_READY_MAGIC 0x5E -- 2.20.1