Received: by 2002:a25:d783:0:0:0:0:0 with SMTP id o125csp655566ybg; Thu, 19 Mar 2020 06:30:10 -0700 (PDT) X-Google-Smtp-Source: ADFU+vuzWOWXiOYWgPMDejme806v5rzuNm+2aQbHQq449yULOwLgjz9dQLgIY02k7buOkYBz4YQ/ X-Received: by 2002:aca:f4d0:: with SMTP id s199mr2358215oih.109.1584624610391; Thu, 19 Mar 2020 06:30:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584624610; cv=none; d=google.com; s=arc-20160816; b=iMlEGD5h40jcpK5nV6O1QolOxVF+Ww5SHBEG6SukQyFNn5wt1mSI+a+fPsapBc1z0m NtpP46r4ZTYNUVwPojXLbQ8rE+yFfFieEq8RZZHzt799aQAXYeGqk8ZNfJMsPGSkVw/D Qx8lIesyOz7g+mzKAxZb6DpAfQfQ8UZGwLuFKGcjdn6temY1cCPAfZmfzi6gLQkfTyiF YdVl9d+yRyral2lwWKH5NxcythWW0BtFKtV03YfuBbnP+v8Ic/M5znnkAOdtUI2qaY4Q bMhfaQDBBdCcVhPHPfYal0nRzaMeSr64rItSytL7hAyFv1IhnrvrkUPCh0zfG6LlY5Fh 0CDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=n4et5NNI7gGTXPI13it22UpblN3wxBkgQvW3n0rTens=; b=aSfP9BklUuqhZo05rebDB0LJHAOGgvcrKmqFDLkmiDcF9w06eK0EoiLtafle95Qe9G qlCzz7YcXpL83TwpMn530NSymgv0eZ8mYQna7AVkhyvdaMW7qienPRDrBiR+Bd95CAv+ Dum63vqMt3dlvCkBV1jp9HuxRBciahCAHwSf4WplOhCxF1P0m8DEu/GDLs1f3wQHHM/3 RCfogJP7qgmExdp9TBOfHDcXTfPKl9fojDvItkMYzdo/fXygTGSb2neZpKy+tRC0pvrb 5+v1smH6rBTqQKgZOZTFkL8FN1BYXvedenNQY4wd0N9orfh3tgX3CaoKsykjFOAMVIZC dzJw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=e7VkPkpv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f36si1292907otf.201.2020.03.19.06.29.58; Thu, 19 Mar 2020 06:30:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=e7VkPkpv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727740AbgCSN00 (ORCPT + 99 others); Thu, 19 Mar 2020 09:26:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:54348 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730317AbgCSN0W (ORCPT ); Thu, 19 Mar 2020 09:26:22 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EECE920658; Thu, 19 Mar 2020 13:26:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584624382; bh=CF0oxVd1Ljc33k3LLpWxJqOxe/MbmHC6fvTOzBAh5b0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=e7VkPkpvWb9RnkHr48YaVxfmM9h9Ul2usUwk11bZFJ96qHmDL+md0gZ88YyNOe2ns dt90EqR6aYPsThY86Uez2zgf8n6nDv8JmysEf6eBBcDQ/hfpYmrlhqqeYtfmfpF6B4 kDNZNaDl7qbtN18HKVH8PzBvWResW27PHyMeAIFU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Luo bin , "David S. Miller" , Sasha Levin Subject: [PATCH 5.5 43/65] hinic: fix a irq affinity bug Date: Thu, 19 Mar 2020 14:04:25 +0100 Message-Id: <20200319123940.063740055@linuxfoundation.org> X-Mailer: git-send-email 2.25.2 In-Reply-To: <20200319123926.466988514@linuxfoundation.org> References: <20200319123926.466988514@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Luo bin [ Upstream commit 0bff777bd0cba73ad4cd0145696ad284d7e6a99f ] can not use a local variable as an input parameter of irq_set_affinity_hint Signed-off-by: Luo bin Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/huawei/hinic/hinic_hw_qp.h | 1 + drivers/net/ethernet/huawei/hinic/hinic_rx.c | 5 ++--- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hw_qp.h b/drivers/net/ethernet/huawei/hinic/hinic_hw_qp.h index f4a339b10b10b..79091e1314181 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_hw_qp.h +++ b/drivers/net/ethernet/huawei/hinic/hinic_hw_qp.h @@ -94,6 +94,7 @@ struct hinic_rq { struct hinic_wq *wq; + struct cpumask affinity_mask; u32 irq; u16 msix_entry; diff --git a/drivers/net/ethernet/huawei/hinic/hinic_rx.c b/drivers/net/ethernet/huawei/hinic/hinic_rx.c index 56ea6d692f1c3..2695ad69fca60 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_rx.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_rx.c @@ -475,7 +475,6 @@ static int rx_request_irq(struct hinic_rxq *rxq) struct hinic_hwdev *hwdev = nic_dev->hwdev; struct hinic_rq *rq = rxq->rq; struct hinic_qp *qp; - struct cpumask mask; int err; rx_add_napi(rxq); @@ -492,8 +491,8 @@ static int rx_request_irq(struct hinic_rxq *rxq) } qp = container_of(rq, struct hinic_qp, rq); - cpumask_set_cpu(qp->q_id % num_online_cpus(), &mask); - return irq_set_affinity_hint(rq->irq, &mask); + cpumask_set_cpu(qp->q_id % num_online_cpus(), &rq->affinity_mask); + return irq_set_affinity_hint(rq->irq, &rq->affinity_mask); } static void rx_free_irq(struct hinic_rxq *rxq) -- 2.20.1