Received: by 2002:a25:d783:0:0:0:0:0 with SMTP id o125csp662525ybg; Thu, 19 Mar 2020 06:36:32 -0700 (PDT) X-Google-Smtp-Source: ADFU+vt3UHVbkqZW6PMU3kuibP2+vlcZdzz9JxKuYkp1HgcxxoU2Io2Mjuj3CyrLdVWA8rE3aqko X-Received: by 2002:aca:5194:: with SMTP id f142mr2437947oib.100.1584624992461; Thu, 19 Mar 2020 06:36:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584624992; cv=none; d=google.com; s=arc-20160816; b=WRoaa++P9paDbOn6TzP3vbCgaqvtGgY5OPcGyCNssA5MVbFHdRTWyGwcWJLdNae+n9 BmVLZu7YoiC9xG54In6P+QTTE7kwPOd9cVMff+fThRyH94wEZQxZwuJLQoll4I0nCWZR 8tmwEc222GhXeVHW2gfzVPe1Y3f4zW0tJxISHZKaudKXbJ9BB8rxRIntBUaQq/8oLq1p 3K6Km4a3ljLA99m4YOpft6N1bi/HklZxU5vewEZpB7N6bv9V6psNBghxO5Va+YxC0smC hO1FwhVKSTrqkt4a4EYvkYb9322x/in3YNJ0kj5I4cIlAZDv+dQTpxT8/9ZH53MVKJd3 b/RQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=DmER7SvJuhT0i8cwvo/19lgRA5qmXBsRwSZNFsspXnk=; b=XLresX5eCBp/OO8Q8w8N9Uemvy/8gSNcWBs1rAWLvwcggTTEANOf/Ws59TWAPmOzSu cpfYi18ouf1FVk6133ne1lVgEZWeikcztj/vRjqk/lk8wJGBBL24tZnQZZa1nenuTgaE Dez1NkzmG7uChn1FTs4tzGdH4jB4gOxQqairlFx4l4BHn/AWfy2M0MzK18Bc6yobbJBh v0NM4lBG04jzkdTfHhBzVwTXG8GCsyBp+EsO19dLbS26bIugs2/rgzHAJ8peKTKqVYds ItMUhKeY1wRu+xz/xnbZRKN/wrwzO2PA9LEDWcqjo8Y8Ak9ot4DXjRyaVM4Y+dlb6oDI nVcQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y8si1234830otg.112.2020.03.19.06.36.19; Thu, 19 Mar 2020 06:36:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727975AbgCSNL3 (ORCPT + 99 others); Thu, 19 Mar 2020 09:11:29 -0400 Received: from 8bytes.org ([81.169.241.247]:53810 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726975AbgCSNL0 (ORCPT ); Thu, 19 Mar 2020 09:11:26 -0400 Received: by theia.8bytes.org (Postfix, from userid 1000) id 8ECFE1D4; Thu, 19 Mar 2020 14:11:24 +0100 (CET) Date: Thu, 19 Mar 2020 14:11:22 +0100 From: Joerg Roedel To: Jean-Philippe Brucker Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mediatek@lists.infradead.org, virtualization@lists.linux-foundation.org, Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , Rob Clark , Sean Paul , Will Deacon , Robin Murphy , Matthias Brugger , Thierry Reding , Andy Gross , Bjorn Andersson , Joerg Roedel Subject: Re: [PATCH 13/15] iommu/qcom: Use accessor functions for iommu private data Message-ID: <20200319131122.GS3794@8bytes.org> References: <20200310091229.29830-1-joro@8bytes.org> <20200310091229.29830-14-joro@8bytes.org> <20200316155223.GM304669@myrica> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200316155223.GM304669@myrica> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jean-Philippe, On Mon, Mar 16, 2020 at 04:52:23PM +0100, Jean-Philippe Brucker wrote: > Should be: > > if (!dev_iommu_priv_set(dev)) Thanks a lot for your reviews! I made the changes to arm-smmu and the qcom driver you requested and will post a new version later today. Thanks, Joerg