Received: by 2002:a25:d783:0:0:0:0:0 with SMTP id o125csp748259ybg; Thu, 19 Mar 2020 08:05:44 -0700 (PDT) X-Google-Smtp-Source: ADFU+vvWbAjwNYncU+SdlxCSVSWTL85pXdXsa/XpCoVFiv/ghLWllYJMFyL+OmUlrgcFa3+wzP4V X-Received: by 2002:a05:6830:1251:: with SMTP id s17mr2815829otp.75.1584630344213; Thu, 19 Mar 2020 08:05:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584630344; cv=none; d=google.com; s=arc-20160816; b=NLtwW015iBKdKkNjK/9ubeUqiXx2R+2UWQAOjwrNy2gc6XxgACRQ43TIFu6rPG0/j/ 1AkCxXE+wSBfPgw50KN72FhhjW9K7SC0NaQoahf2S+HjX7Dp3lMENXYTJ84g6h9kbRPa LqeQqMp9k4bvbkqHjHdx9D8KB+3I/kaQeXOwSiZUiTNlmx7TxoYcJoLKUDG87qJrRk2a ceOzgAY7UHVbTL/U1XyoOILDdo5xtHfZyJKIHiYW1x3uBSxTdrP+cTdNlbpFGMNtSoeg Z7gnRXG/VHj+48IT35mBIj4EVkBE/J6OWvVMpmLMrpU9kfMeg5Z1S9MioXM6pnSb7qBO rFMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:ironport-sdr:ironport-sdr; bh=hSJftOeBmXELNArEO2fnE9OD0BtVRnKo6yVrvnMYJVc=; b=hRHB2Pgjdy8r6PxhWddA4v+ZwOW9acuzYpA+FlE1O3Dj6xfLRikINOOy6tsiTlhn5h oHDMb9inCmFjeH5mrkVaBKP7nAACq+tG9BdOaZvYltQtrQiCWY+ZulV/iKI+u0tEqaIo OdoUX7bucooMV+2Y1/POKD4CzDe2c1F/OoT8Wq/bC/KQWc+78h5F6pVQEtdizI/SDVbE ls4ttOGu9cT8Dndi6MsC3ckSFWO7NOVFG64P1DRCmGQic6LVkTDwdSwVt7+pUzb6lc43 gN1nanhRLhmg2TLy+rYpSBsgUSQ38kPxmCTuGmRSvBht4T+MmXpJunoh+DplwAAUeJxb XbCA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m6si1122162oim.230.2020.03.19.08.05.07; Thu, 19 Mar 2020 08:05:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728453AbgCSPDR (ORCPT + 99 others); Thu, 19 Mar 2020 11:03:17 -0400 Received: from esa3.mentor.iphmx.com ([68.232.137.180]:32379 "EHLO esa3.mentor.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728435AbgCSPDO (ORCPT ); Thu, 19 Mar 2020 11:03:14 -0400 IronPort-SDR: 5Jq3RKvLYTAyLEqWcpKPL+X7sjRYA9I00NjWhYhzpEP+ecJhAozwJkNb5TYHC/OfWosxuyRGXt 01Avo63f0kjPIhuEelXmOP94ZEiMsgWS4fpwPy8iQFaNg+SmGQHNN2lm+FGVwRucaKLO5GAzHz J60QJcJDuL1DdoKz3144OPo2otj1Y0eKMD5FQDHfoFlkyoJt4MyfiRANgBwILixsfXSGydw+GZ zuaLkryr5ZaZQdAcEtZgPCd4hkougaim5q8gpd7zvzkrhYWGo3EWLMMC3Z8ZRerx9RR9J+bQ2d g7A= X-IronPort-AV: E=Sophos;i="5.70,572,1574150400"; d="scan'208";a="46891060" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa3.mentor.iphmx.com with ESMTP; 19 Mar 2020 07:03:14 -0800 IronPort-SDR: o9oTlPpDDDoKlapVti8kaUvE0cke1Is3vdMmgwl1RQFVcs9yu+cN7kKSFkI3evS8/yl9WgqStB DE69twgXtjO/a50kROpTpAST5s46mmqF/fkRI6r679HKoFTjVXMEyHJlO5ZqXzFyBaQqCDDkMc kb2yxlOdB0d/XZEdEuISKvHVNpwyvu/8Ist4iQhViIAUOZGlI43ubiGje8fa3W2HWMZqGgKkfL uMqNRaFysSW9KhRxTrTyGDlQo5etfoC0eH4svwsZg8LRyhUzrI61aDCr8uQ1RioNbHHML7PpfB uO8= From: Jiada Wang To: , , , , , CC: , , , , Subject: [PATCH v8 44/52] Input: Atmel: improve error handling in mxt_update_cfg() Date: Thu, 19 Mar 2020 08:00:08 -0700 Message-ID: <20200319150016.61398-45-jiada_wang@mentor.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200319150016.61398-1-jiada_wang@mentor.com> References: <20200319150016.61398-1-jiada_wang@mentor.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Deepak Das mxt_update_cfg() failed to propagate the error code from mxt_init_t7_power_cfg() so return the error code. Signed-off-by: Deepak Das Signed-off-by: George G. Davis Signed-off-by: Jiada Wang --- drivers/input/touchscreen/atmel_mxt_ts.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c index 1eedde24e38f..edab65337061 100644 --- a/drivers/input/touchscreen/atmel_mxt_ts.c +++ b/drivers/input/touchscreen/atmel_mxt_ts.c @@ -2185,7 +2185,9 @@ static int mxt_update_cfg(struct mxt_data *data, const struct firmware *fw) dev_info(dev, "Config successfully updated\n"); /* T7 config may have changed */ - mxt_init_t7_power_cfg(data); + ret = mxt_init_t7_power_cfg(data); + if (ret) + dev_warn(dev, "Power Config failed to update\n"); release_mem: kfree(cfg.mem); -- 2.17.1