Received: by 2002:a25:d783:0:0:0:0:0 with SMTP id o125csp784751ybg; Thu, 19 Mar 2020 08:42:40 -0700 (PDT) X-Google-Smtp-Source: ADFU+vv9iYTZL8Lp3/F4hVwa5tVk4ELkpXyIASp9tyl3J+aRSmYJf15AmTcuvf9nhKTanLuo9W70 X-Received: by 2002:a05:6830:1d4f:: with SMTP id p15mr2729692oth.38.1584632560676; Thu, 19 Mar 2020 08:42:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584632560; cv=none; d=google.com; s=arc-20160816; b=XDXDF3bOzviF5LG/AyDSWyXUy3g2vH+TgGGTha6Co+lNCFrblOSIyeEU1osLqFSykK /B7xJz0CxIpwSbK1vfK2e/Q+c0M1SnJpx5OUE/yHwiHi6Ted4ByBjoqHu9tneFgFobjy tQPMTZ4i3Rt9qX4CRcyNt5HJlQovYStcZp5LPPyu5gACw5aMrcIpps7Ve80uWUZj9WAm 6JMQmtOj4fOzodzhxz/lzOzJO7KYQLuLl456Wo7eX/Wtmlo2XVaAh+ARjOU0M0ZbrXaN PC+mt7T13tZNxr1CW82g1D9xKQrw5xiISFQmds1zh0W9mU3WHwq/EPjLU3tUepfWyYtn c2EA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=Svhqsdakkesw8kI+E1Ch25OR5y1TYqLbot9UWdcc4Ww=; b=hJbhab7hzleR5Y3XHtZ4HbJSPnJozwKa0B8EX+BoBwQJ/awaT5BfatKp7U9AZPekYQ gk0qzUkQPF3v9vY964x0FRmddQ9RRDR3wc340xq697tLTDgNEyIxCoCR5Af5Zwib9oo+ HDF4RCbZH2pfzPHGLujTDgn64kSAImSfjl8x9QUXg49KtoEepJm5d+0XpeF5NmP3eZjf VMiDcdn1cho7Du9E5fjKdNg2JIIUlLL7L6sZkkHBH559GxwgnkqJTZryJRVWAgJMVlH7 hagEulcJVSZ0z1aaAQ8mTCpXJWd9nvZljd5j9ExneAUSV6u2iADfB1cG4jV9O4iSHep9 PNAw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v20si1187253oif.63.2020.03.19.08.42.28; Thu, 19 Mar 2020 08:42:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728120AbgCSPle (ORCPT + 99 others); Thu, 19 Mar 2020 11:41:34 -0400 Received: from inva020.nxp.com ([92.121.34.13]:41436 "EHLO inva020.nxp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728107AbgCSPlN (ORCPT ); Thu, 19 Mar 2020 11:41:13 -0400 Received: from inva020.nxp.com (localhost [127.0.0.1]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 64F1F1A0107; Thu, 19 Mar 2020 16:41:11 +0100 (CET) Received: from inva024.eu-rdc02.nxp.com (inva024.eu-rdc02.nxp.com [134.27.226.22]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 58E571A00C6; Thu, 19 Mar 2020 16:41:11 +0100 (CET) Received: from fsr-ub1864-111.ea.freescale.net (fsr-ub1864-111.ea.freescale.net [10.171.82.141]) by inva024.eu-rdc02.nxp.com (Postfix) with ESMTP id C6E64205C2; Thu, 19 Mar 2020 16:41:10 +0100 (CET) From: Diana Craciun To: linux-kernel@vger.kernel.org, laurentiu.tudor@nxp.com, stuyoder@gmail.com, leoyang.li@nxp.com, linux-arm-kernel@lists.infradead.org, bharatb.yadav@gmail.com Cc: Diana Craciun Subject: [PATCH 05/10] bus/fsl-mc: Set the QMAN/BMAN region flags Date: Thu, 19 Mar 2020 17:40:46 +0200 Message-Id: <20200319154051.30609-6-diana.craciun@oss.nxp.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200319154051.30609-1-diana.craciun@oss.nxp.com> References: <20200319154051.30609-1-diana.craciun@oss.nxp.com> X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The QMAN region is memory mapped, so it should be of type IORESOURCE_MEM. The region flags bits were wrongly used to pass additional information. Use the bus specific bits for this purpose. Signed-off-by: Diana Craciun --- drivers/bus/fsl-mc/fsl-mc-bus.c | 7 ++----- drivers/bus/fsl-mc/fsl-mc-private.h | 6 ------ 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/drivers/bus/fsl-mc/fsl-mc-bus.c b/drivers/bus/fsl-mc/fsl-mc-bus.c index b9ccac9862b7..a99a0edef252 100644 --- a/drivers/bus/fsl-mc/fsl-mc-bus.c +++ b/drivers/bus/fsl-mc/fsl-mc-bus.c @@ -571,11 +571,8 @@ static int fsl_mc_device_get_mmio_regions(struct fsl_mc_device *mc_dev, regions[i].end = regions[i].start + region_desc.size - 1; regions[i].name = "fsl-mc object MMIO region"; - regions[i].flags = IORESOURCE_IO; - if (region_desc.flags & DPRC_REGION_CACHEABLE) - regions[i].flags |= IORESOURCE_CACHEABLE; - if (region_desc.flags & DPRC_REGION_SHAREABLE) - regions[i].flags |= IORESOURCE_MEM; + regions[i].flags = region_desc.flags & IORESOURCE_BITS; + regions[i].flags |= IORESOURCE_MEM; } mc_dev->regions = regions; diff --git a/drivers/bus/fsl-mc/fsl-mc-private.h b/drivers/bus/fsl-mc/fsl-mc-private.h index be6bb0fb4603..81b9a9b16698 100644 --- a/drivers/bus/fsl-mc/fsl-mc-private.h +++ b/drivers/bus/fsl-mc/fsl-mc-private.h @@ -359,12 +359,6 @@ int dprc_set_obj_irq(struct fsl_mc_io *mc_io, int obj_id, u8 irq_index, struct dprc_irq_cfg *irq_cfg); - -/* Region flags */ -/* Cacheable - Indicates that region should be mapped as cacheable */ -#define DPRC_REGION_CACHEABLE 0x00000001 -#define DPRC_REGION_SHAREABLE 0x00000002 - /** * enum dprc_region_type - Region type * @DPRC_REGION_TYPE_MC_PORTAL: MC portal region -- 2.17.1