Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 19 Mar 2020 11:56:35 -0400 (EDT)
From:   Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To:     Florian Weimer <fw@deneb.enyo.de>
Cc:     libc-alpha <libc-alpha@sourceware.org>, carlos <carlos@redhat.com>,
        Rich Felker <dalias@libc.org>,
        linux-api <linux-api@vger.kernel.org>,
        Boqun Feng <boqun.feng@gmail.com>,
        Will Deacon <will.deacon@arm.com>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ben Maurer <bmaurer@fb.com>, Dave Watson <davejwatson@fb.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Paul <paulmck@linux.vnet.ibm.com>, Paul Turner <pjt@google.com>,
        Joseph Myers <joseph@codesourcery.com>
Message-ID: <2147217200.3240.1584633395285.JavaMail.zimbra@efficios.com>
In-Reply-To: <874kukpf9f.fsf@mid.deneb.enyo.de>
References: <20200319144110.3733-1-mathieu.desnoyers@efficios.com> <20200319144110.3733-5-mathieu.desnoyers@efficios.com> <874kukpf9f.fsf@mid.deneb.enyo.de>
Subject: Re: [RFC PATCH glibc 4/8] glibc: Perform rseq(2) registration at C
 startup and thread creation (v15)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Thread-Topic: glibc: Perform rseq(2) registration at C startup and thread creation (v15)
Thread-Index: +wQ/afczq9ft3jDapmb/EGDwKihxiQ==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

----- On Mar 19, 2020, at 10:53 AM, Florian Weimer fw@deneb.enyo.de wrote:

> * Mathieu Desnoyers via Libc-alpha:
> 
>> Changes since v14:
>> - Update copyright range to include 2020.
>> - Introduce __ASSUME_RSEQ defined for --enable-kernel=4.18.0 and higher.
>> - Use ifdef __ASSUME_RSEQ rather than ifdef __NR_rseq to discover rseq
>>   availability. This is necessary now that the system call numbers are
>>   integrated within glibc.
> 
> It's not quite clear to me why you need __ASSUME_RSEQ.

This is how I noticed other Linux features were being integrated,
so I figured this is how I should do it. Monkey see, monkey do. ;-)

> Can you use __has_include in <sys/rseq.h>, with a copy of the kernel
> definitions if the kernel header is not available?

Sure. Should I pull a verbatim copy of uapi linux/rseq.h into glibc ?
If so, where should I put it ?

Thanks,

Mathieu


-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com