Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 19 Mar 2020 17:05:24 +0100
From:   Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= 
        <marmarek@invisiblethingslab.com>
To:     Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc:     xen-devel@lists.xenproject.org, Juergen Gross <jgross@suse.com>,
        Stefano Stabellini <sstabellini@kernel.org>,
        Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>,
        Simon Gaiser <simon@invisiblethingslab.com>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] xen-pciback: fix INTERRUPT_TYPE_* defines
Message-ID: <20200319160524.GX18599@mail-itl>
References: <20200319040648.10396-1-marmarek@invisiblethingslab.com>
 <e6c48552-9866-497c-7d2f-62849122f867@oracle.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="xaJmculcd5PV2weY"
Content-Disposition: inline
In-Reply-To: <e6c48552-9866-497c-7d2f-62849122f867@oracle.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--xaJmculcd5PV2weY
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PATCH] xen-pciback: fix INTERRUPT_TYPE_* defines

On Thu, Mar 19, 2020 at 11:07:13AM -0400, Boris Ostrovsky wrote:
>=20
> On 3/19/20 12:06 AM, Marek Marczykowski-G=C3=B3recki wrote:
> > INTERRUPT_TYPE_NONE should be 0,
>=20
>=20
> Would
>=20
> =C2=A0 return ret ?: INTERRUPT_TYPE_NONE
>=20
> in xen_pcibk_get_interrupt_type() work?
>=20
>=20
> I think it's better not to tie macro name to a particular value.

I can do that too. But I'd change INTERRUPT_TYPE_NONE to 0 anyway, as
more logical value (as the value is a bitmask).

> -boris
>=20
>=20
> >   as it is assumed in
> > xen_pcibk_get_interrupt_type(). Fix the definition, and also shift other
> > values to not leave holes.
> > But also use INTERRUPT_TYPE_NONE in xen_pcibk_get_interrupt_type() to
> > avoid similar confusions in the future.
> >=20
> > Fixes: 476878e4b2be ("xen-pciback: optionally allow interrupt enable fl=
ag writes")
> > Signed-off-by: Marek Marczykowski-G=C3=B3recki <marmarek@invisiblething=
slab.com>
> >=20

--=20
Best Regards,
Marek Marczykowski-G=C3=B3recki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?

--xaJmculcd5PV2weY
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAl5zmEQACgkQ24/THMrX
1yyYtwf+Pg91y5j0VuyfObz5D6ca2GNocsfVmm3WdXCHHpgx6nmJMWkfq+JWk+De
Qqp/HjmenfTPVnYbkRgE9A9qiCT/eQ1WTkfAmk+0oqQIcuNrv4lssV5QtS+b3D8X
ToKagzMOYGS0WMcMEbbAs9N9rLnJVOJw0PRI3HcTsoNoWNymyIVrLgoyoBYTGx0O
J8vHvSydTsAuwf1KESUnglaEBr/KTLwNOya5lccQaSEYYu2vbqIhinyOI1v2pP27
cTMYNR5TGxjcCCAWB7BvzhUq0Xe4OTYEbB3WMhHnq+OsxrHKsAMYpm+3CCBI/suJ
oJ22cTJ/CG7dyGddWmdrkbbtUHuVFA==
=uRFZ
-----END PGP SIGNATURE-----

--xaJmculcd5PV2weY--