Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 19 Mar 2020 18:22:46 +0100
From:   Andreas Kemnade <andreas@kemnade.info>
To:     Lee Jones <lee.jones@linaro.org>
Cc:     robh+dt@kernel.org, mark.rutland@arm.com, a.zummo@towertech.it,
        alexandre.belloni@bootlin.com, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org,
        stefan@agner.ch, b.galvani@gmail.com, phh@phh.me,
        letux-kernel@openphoenux.org, knaack.h@gmx.de, lars@metafoo.de,
        pmeerw@pmeerw.net, linux-iio@vger.kernel.org, jic23@kernel.org
Subject: Re: [PATCH RESEND v6 2/7] mfd: rn5t618: add IRQ support
Message-ID: <20200319182246.27d4809b@kemnade.info>
In-Reply-To: <20200319161149.GB5477@dell>
References: <20200313064535.31503-1-andreas@kemnade.info>
        <20200313064535.31503-3-andreas@kemnade.info>
        <20200319161149.GB5477@dell>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 boundary="Sig_/siGgyZ4Qye9Mavy.deiaD6/"; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--Sig_/siGgyZ4Qye9Mavy.deiaD6/
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

On Thu, 19 Mar 2020 16:11:49 +0000
Lee Jones <lee.jones@linaro.org> wrote:

> On Fri, 13 Mar 2020, Andreas Kemnade wrote:
[...]
I agree to the other comments.

> > +	if (priv->irq > 0) { =20
>=20
> There are already have checks in rn5t618_irq_init().
>=20
> Just call it regardless.
>=20
> > +		if (rn5t618_irq_init(priv)) =20
>=20
> If this returns an error, you should return that error from .probe().
>=20
Hmm, that would be a regression. Current users do not specify an interrupt
in the devicetree yet, so the MFD driver would stop working on these devices
completely.
Therefore I think we should keep the existing functionality if there is no
IRQ specified in the devicetree and ignore the error. The new subdevices
are checking the IRQ availability and give error messages and have
reduced functionality.

Regards,
Andreas

--Sig_/siGgyZ4Qye9Mavy.deiaD6/
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEPIWxmAFyOaBcwCpFl4jFM1s/ye8FAl5zqmcACgkQl4jFM1s/
ye9G7w//WlnawIpi36NIAadLtast9vu33weBJVgKnN3mfwzi5RbM/l5IAVJZH+uN
gpKeObNx1hxpWNresKQfEnEapfmnINbb6l3v4JzoiGtpyWWZeb1jFrWZjzxhqtMv
oqqfUkhETSDajTzt+siADhGd/CcldVY9oZOsGOzzAyO7hTKqP1wLaYi3ZcHTKE2q
HgXYnqYUMANhN1M9uWgAIt4uz41uHrvoFpnL8X1nUj3cEUU3L7ik1lK4uuDFcnQQ
Yu5EA27appMEeLf3scttVFfec9854vq7lxbLHWd1qnS/9R5QFxxguL3EOWLI5FGz
WW5VPTY6ke+s3Srf5fj6ZZuiVzyScXWTMFnaIgo0wHieeAA8yVcd5DG7qJrB03nE
2nRz/IdvHdMLJPAeMOYM9NMqYkbJtB6u19IFVvr9G+5tEAlhTeYqwbRp8W5CSY6N
8oY2Dd6wDJjQWfQ6nadeQ97hKIZhKQzLV0ApFLVI+hbP3v1QwGUNu+lWxO9Hm7yl
LuUFK4vnj/BWiCNzlZAJHq2E3N/wwVcIMtKBp5Xl4QXxNUgVD1VjDFdcYCyHfZUy
Xb6WWsn8t+dvby2nUGJm6WyNKoUzeb+HFh2R2YoeTNFO6sz1lo2aVFFq4oxSDK/F
yF/FaLCKTTCfbHlUN6nR9yCeXKqYzt+dUIiKYepMLuN/1Ddu3tk=
=DMzN
-----END PGP SIGNATURE-----

--Sig_/siGgyZ4Qye9Mavy.deiaD6/--