Received: by 2002:a17:90a:1609:0:0:0:0 with SMTP id n9csp777038pja; Thu, 19 Mar 2020 10:47:40 -0700 (PDT) X-Google-Smtp-Source: ADFU+vsHA8LXf7KHxvthJlxaX0rz9I+PyKVDoY6YLYbfm4mQl4jt2ccudYoATYdK/PQIYzsrYxpf X-Received: by 2002:aca:5057:: with SMTP id e84mr3390770oib.120.1584640060558; Thu, 19 Mar 2020 10:47:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584640060; cv=none; d=google.com; s=arc-20160816; b=Ub2uBl1oleVngpJeWvEs++XFl6MSdw6MgUOeQUJPvq+atnjPe+nU9fr8Y64mJ+F/M2 9OdsnGy3Pc7ySCEp45CyOVbxn7CMHfiQhmAixLJNnAgoXOWIBt1tqHmHq+OQC4cYZT3z 4M2lpdTRnb9vEzNAzAGgCCa55VZS9PP+XHQLj6+CLImPr5DValek3Hkzgb8KTdHqttA7 ep2ENNQ31TLwv9reNdNAKoVhnJRgAonNjTwN6sVjOn6Vs+J300ixL+TwVCtpqnKCobAG 3v3i2t1AtZHA0oXojnKwY9npk7U1l/OQ/kAESpzNkt/L05FUMLBNeO5h/pfOtviit7TA PHkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:dkim-signature; bh=aA76ES7e43xggaYU1fSodrMujaNKIwSE//1w1Lnn+qQ=; b=l9kcTsL6aM1qCLJqxttij9GBhLTjG1X37naKrpo9yKIzPmby3nDLpShJz+zgSubL84 3V/+SELbne6O0iRi8XswKOYK9EJ3H3g1P+tGQHQAi8rQMl+4cNR6hR/Ig/djEbqg0zhL L9ptyjcAs/+fppnnlkakz/b3l5UGG0gto+FvbVq1JMV0ROTiCSBnMJY9OZqDl9W8gsq5 GnUbjttTz2aEancMPYKwg5TSTs1ZFdJv2ucawXxpjAb6J+xOYBE479ymiz2spZ054gzM smL8P7YWYSDTNlWsqEEB14DIChy9MgP9sE1cX5s8QDs1j6ZQ09F8hOFBkl8PnqRWfddf fsog== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=aXvs6D1S; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m2si1637843otr.270.2020.03.19.10.47.27; Thu, 19 Mar 2020 10:47:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=aXvs6D1S; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727212AbgCSRrH (ORCPT + 99 others); Thu, 19 Mar 2020 13:47:07 -0400 Received: from us-smtp-delivery-74.mimecast.com ([216.205.24.74]:26502 "EHLO us-smtp-delivery-74.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726934AbgCSRrH (ORCPT ); Thu, 19 Mar 2020 13:47:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584640026; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aA76ES7e43xggaYU1fSodrMujaNKIwSE//1w1Lnn+qQ=; b=aXvs6D1S6Nn91J8ZS2dTipJ/2sQXY0u/wosYRX/KdbWtfp1q9GWZJDnrqt8gRUjvKtE2EQ 7Z1BdDbh9QjNvewwDIyf1rlw3RdD8Z6IIWtenO796lVWAyMYRPkwR6+GUmlzGVdgHnRNpj xiHTJBdLVSMIhIxiSWC+mzsGBuucoFQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-309-YbKSdRvnMb-H-gKH__LWFQ-1; Thu, 19 Mar 2020 13:47:02 -0400 X-MC-Unique: YbKSdRvnMb-H-gKH__LWFQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D88AF85EE74; Thu, 19 Mar 2020 17:47:00 +0000 (UTC) Received: from gondolin (ovpn-113-188.ams2.redhat.com [10.36.113.188]) by smtp.corp.redhat.com (Postfix) with ESMTP id 71F6B1001B28; Thu, 19 Mar 2020 17:46:55 +0000 (UTC) Date: Thu, 19 Mar 2020 18:46:53 +0100 From: Cornelia Huck To: Alex Williamson Cc: kvm@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, dev@dpdk.org, mtosatti@redhat.com, thomas@monjalon.net, bluca@debian.org, jerinjacobk@gmail.com, bruce.richardson@intel.com, kevin.tian@intel.com Subject: Re: [PATCH v3 7/7] vfio/pci: Cleanup .probe() exit paths Message-ID: <20200319184653.6c10638b.cohuck@redhat.com> In-Reply-To: <158396396706.5601.17691989521568973524.stgit@gimli.home> References: <158396044753.5601.14804870681174789709.stgit@gimli.home> <158396396706.5601.17691989521568973524.stgit@gimli.home> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 11 Mar 2020 15:59:27 -0600 Alex Williamson wrote: > The cleanup is getting a tad long. > > Signed-off-by: Alex Williamson > --- > drivers/vfio/pci/vfio_pci.c | 54 ++++++++++++++++++++----------------------- > 1 file changed, 25 insertions(+), 29 deletions(-) Reviewed-by: Cornelia Huck