Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <1584502004-11349-1-git-send-email-Anson.Huang@nxp.com>
References: <1584502004-11349-1-git-send-email-Anson.Huang@nxp.com>
Subject: Re: [PATCH] clk: imx: clk-pllv3: Use readl_poll_timeout() for PLL lock wait
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     Linux-imx@nxp.com
To:     Anson Huang <Anson.Huang@nxp.com>, abel.vesa@nxp.com,
        allison@lohutok.net, festevam@gmail.com, gustavo@embeddedor.com,
        kernel@pengutronix.de, kstewart@linuxfoundation.org,
        linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
        linux-kernel@vger.kernel.org, mturquette@baylibre.com,
        s.hauer@pengutronix.de, shawnguo@kernel.org, tglx@linutronix.de
Date:   Thu, 19 Mar 2020 12:58:52 -0700
Message-ID: <158464793223.152100.9637932949695874103@swboyd.mtv.corp.google.com>
User-Agent: alot/0.9
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Quoting Anson Huang (2020-03-17 20:26:44)
> diff --git a/drivers/clk/imx/clk-pllv3.c b/drivers/clk/imx/clk-pllv3.c
> index df91a82..3dfa9c3 100644
> --- a/drivers/clk/imx/clk-pllv3.c
> +++ b/drivers/clk/imx/clk-pllv3.c
> @@ -53,23 +56,14 @@ struct clk_pllv3 {
> =20
>  static int clk_pllv3_wait_lock(struct clk_pllv3 *pll)
>  {
> -       unsigned long timeout =3D jiffies + msecs_to_jiffies(10);
>         u32 val =3D readl_relaxed(pll->base) & pll->power_bit;
> =20
>         /* No need to wait for lock when pll is not powered up */
>         if ((pll->powerup_set && !val) || (!pll->powerup_set && val))
>                 return 0;
> =20
> -       /* Wait for PLL to lock */
> -       do {
> -               if (readl_relaxed(pll->base) & BM_PLL_LOCK)
> -                       break;
> -               if (time_after(jiffies, timeout))
> -                       break;
> -               usleep_range(50, 500);
> -       } while (1);
> -
> -       return readl_relaxed(pll->base) & BM_PLL_LOCK ? 0 : -ETIMEDOUT;
> +       return readl_poll_timeout(pll->base, val, val & BM_PLL_LOCK, 500,

Did you want to use readl_relaxed_poll_timeout() to keep it the same as
before?