Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp137273ybb; Thu, 19 Mar 2020 13:06:16 -0700 (PDT) X-Google-Smtp-Source: ADFU+vu80GRIHPaUhcV72WK/Z2h4nVoi/xiOCBRT6ApCrNOdUHSE1XZCOpO3oAQaTz3dmGjkVVSR X-Received: by 2002:a9d:7646:: with SMTP id o6mr3935606otl.179.1584648376659; Thu, 19 Mar 2020 13:06:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584648376; cv=none; d=google.com; s=arc-20160816; b=cWrAzdA3DRM27IXzvMWyBEq7b9Hb8kGL2EYF4lpAunCMxAh8AenVofZcDYYhSKVR+o XW6MS5l7u22SUc+iOTLowrlsG1vGx0iSGjbqU1LxUqFDYq3aQ9w6iTJJUgxFDcIMZxA6 i53IUNN49cKlpCJmvJVodP9bnKY6LZe5qChZg+y8l106TIE0N5jcLCh2ANCa/j9/kdWa UtOY7S7Ofn6HDsE2sG4MTcgpxBV6ZPbtC+3jy92Wtu1rcoFHDQeA3hWjuIasuksaIhiU OpyMXb5hp3DEszSQpHwJ5PAJ0pBdDPFRwhIRutmbfyfUrxnBgEDJSiJGuBw09hATsTMc OLjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=PoFHz0rvBd8YobHVZ+bLMI6U8qaQsb5tud5LUDZe2Yo=; b=M6EoayX5+HPr5rYpanGc+Pa2kKfPKmrrte0uA6sQQiyEmyANRm594pZJhdSvZ/2HJs /BmEzj3Dw/AqpcFrtnd3flVt6qYkXm5Zr8TkezUGeKXTUGKwnFQavF0/5MdjulPziLxX ljMhKDq3yHu1qA39NVn6sI6KJyQJW3Gh2Fknk4/jW2IOgPgYVhF0wo32d74tcCIZueey 4zB5RmKfBx+W0gtojWCQ413ZluP/gGAkv+PqBvN2pUZa0BFx06bAKEzvDyk4dv4ff4i8 zkmpdX9a7biUxUlg+sWTb1ZPF4X8/Nqq0JnSuva1NzjuGdI2i7yces/Z9KwBlyhT2rTd zAXw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n4si1413712oic.213.2020.03.19.13.06.03; Thu, 19 Mar 2020 13:06:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727102AbgCSUFM (ORCPT + 99 others); Thu, 19 Mar 2020 16:05:12 -0400 Received: from correo.us.es ([193.147.175.20]:51892 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726864AbgCSUFL (ORCPT ); Thu, 19 Mar 2020 16:05:11 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 9228711EB86 for ; Thu, 19 Mar 2020 21:04:38 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 80DEBFC5E9 for ; Thu, 19 Mar 2020 21:04:38 +0100 (CET) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 7609EFC5E8; Thu, 19 Mar 2020 21:04:38 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on antivirus1-rhel7.int X-Spam-Level: X-Spam-Status: No, score=-108.2 required=7.5 tests=ALL_TRUSTED,BAYES_50, SMTPAUTH_US2,USER_IN_WHITELIST autolearn=disabled version=3.4.1 Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id B356AFC5E5; Thu, 19 Mar 2020 21:04:35 +0100 (CET) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Thu, 19 Mar 2020 21:04:35 +0100 (CET) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (unknown [90.77.255.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 8F2A542EFB80; Thu, 19 Mar 2020 21:04:35 +0100 (CET) Date: Thu, 19 Mar 2020 21:05:06 +0100 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Haishuang Yan Cc: Jozsef Kadlecsik , Florian Westphal , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] netfilter: nf_flow_table: reload ip{v6}h in nf_flow_nat_ip{v6} Message-ID: <20200319200506.nobauwzokz2bexzg@salvia> References: <1584410573-6812-1-git-send-email-yanhaishuang@cmss.chinamobile.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1584410573-6812-1-git-send-email-yanhaishuang@cmss.chinamobile.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 17, 2020 at 10:02:52AM +0800, Haishuang Yan wrote: > Since nf_flow_snat_port and nf_flow_snat_ip{v6} call pskb_may_pull() > which may change skb->data, so we need to reload ip{v6}h at the right > palce. Applied, thanks.