Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp137862ybb; Thu, 19 Mar 2020 13:06:50 -0700 (PDT) X-Google-Smtp-Source: ADFU+vvi8iEBE+J+tRGgEWl7QICp1Xl6zb1XdfeTQgNpXe8qbYmUuYoYKTMoCeuyRk9tp2/1mgef X-Received: by 2002:a9d:18f:: with SMTP id e15mr3659491ote.42.1584648409988; Thu, 19 Mar 2020 13:06:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584648409; cv=none; d=google.com; s=arc-20160816; b=DoFIN22vYT0N5ovMvnhNT2HOekL4ru4IKRqA4Vl1cJRfG3UG6qAuEaRF0rVvUElCOC tIJs3HvhrFoxdvN2keg2+704tpn9QA6v4MsMjmY5mYHYfVMadY1R2UuDiCIcItS5WeAr WRYVyuzMb5uYA5phdgVT3TqT4HxmtR8ezeX/kRn16cJL9MxeSTTpE8pmv+jqp99JV5c7 pfScXUjF23DeYG/f0V3KvM+W3s9+Klvl7eZCBmoX3Ou4pE/K17FBPHlRXO74DYOdWuq2 JeS9FFP7GoixLGagcMp8xfsYzi+0c1kAv5Y8p5nTOI7bTrGCBqEfv478K5M1XCd7v741 1ZPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=RkMIMeiS+VMIws7GJig5TcTcVv1dWSIlCSWUgIEhVbg=; b=BwrlULJtPHW5T5e8OAgzcADC2vuDC6AFPuYr3ovKLLtWnl+m5MHiXShM+BigpFAGLu OQOGiMBI3sRGJzi+nuacajIrnSKVJyIyMmRTQ2Zhk6cdJJLHJx/femXzmVR6vBcpMqaX Sk6jOJ4o2nQUCSLww2fvO61RskcMWmJNlXv/degGCecz7UZv1K4bwL3cP2FmijRxaUAp by4Wjf3NqcRHflrspM86G4P4XqmjfB2ILF19bh+8Cal/vwhH/tFgVjp0Sc0pBYmyMx+q QND+OBVMEhs7S0cc7XJ+THGp97aN0taolZcsL0G6vN6iBf9ttqt7EJOXxpKLYeTufHAd LGKQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g25si1840428otn.258.2020.03.19.13.06.34; Thu, 19 Mar 2020 13:06:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727195AbgCSUFU (ORCPT + 99 others); Thu, 19 Mar 2020 16:05:20 -0400 Received: from correo.us.es ([193.147.175.20]:51950 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727136AbgCSUFT (ORCPT ); Thu, 19 Mar 2020 16:05:19 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id D7A3A11EB90 for ; Thu, 19 Mar 2020 21:04:45 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id C8645FC5EC for ; Thu, 19 Mar 2020 21:04:45 +0100 (CET) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id BAFECFC5EE; Thu, 19 Mar 2020 21:04:45 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on antivirus1-rhel7.int X-Spam-Level: X-Spam-Status: No, score=-108.2 required=7.5 tests=ALL_TRUSTED,BAYES_50, SMTPAUTH_US2,USER_IN_WHITELIST autolearn=disabled version=3.4.1 Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 56643DA72F; Thu, 19 Mar 2020 21:04:43 +0100 (CET) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Thu, 19 Mar 2020 21:04:43 +0100 (CET) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (unknown [90.77.255.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 3478A42EFB80; Thu, 19 Mar 2020 21:04:43 +0100 (CET) Date: Thu, 19 Mar 2020 21:05:13 +0100 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Haishuang Yan Cc: Jozsef Kadlecsik , Florian Westphal , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] netfilter: nf_flow_table: reload ip{v6}h in nf_flow_tuple_ip{v6} Message-ID: <20200319200513.5az6whhu4gdyqpll@salvia> References: <1584410573-6812-1-git-send-email-yanhaishuang@cmss.chinamobile.com> <1584410573-6812-2-git-send-email-yanhaishuang@cmss.chinamobile.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1584410573-6812-2-git-send-email-yanhaishuang@cmss.chinamobile.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 17, 2020 at 10:02:53AM +0800, Haishuang Yan wrote: > Since pskb_may_pull may change skb->data, so we need to reload ip{v6}h at > the right place. Also applied, thanks.