Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp207042ybb; Thu, 19 Mar 2020 20:03:34 -0700 (PDT) X-Google-Smtp-Source: ADFU+vtlfUhWhiUyxcWr2bm6b0Lfm7YNcc2TKEg4Oz3DnDIehwrbdwmAWalGDs5B2e4M29kdp3Rq X-Received: by 2002:a05:6830:1193:: with SMTP id u19mr5164740otq.190.1584673414480; Thu, 19 Mar 2020 20:03:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584673414; cv=none; d=google.com; s=arc-20160816; b=nzHecWiHlSfzYrsNjTKk8cMfiI75EOenQpA/4gg9Cnwwa7CuTNdFcS3QmNrQDYjIgb SjdmO3uNW8IY6qW01/tasihw1a30n874aiWY6UMOX/oHJfUDlNWgvRdNHKWMmU2PU2I8 9XKDnxIABudjDyry/EF33VR2o4yr3X6bbDQmScj2vFyFl7z5xPHje8WfBALpjEBxOZXj 0jvFxw3FayhLyTwCMQm/p2Ka8XoaoeFYaM5L1ypHCfPGEw0TheKSjljhpFwQe/Bs4v4+ fCwYHRdGeqwb4KEk9Xo/0a7vUGjvEHChBPq47nUFeVetSZcJSh12aZoy11wlHB83jEcD MLjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Wy2Rb8SY1Pz/c/o65ADYdzfkIZ3xe9SUJygVcDWd17g=; b=d8yZf6QbOv0qrur5u61tOnvy26AOrHzLrgcyIiAvvNhWx7QHOTZLd9M+aPJ54bGWkk zBETHtA84rAUzfZ6CMrwm2RgHWzAupOZAgBj0miVNQKB75Fk3BJ8/yakaO4Rg2EIgew/ 94D67kwjqWVTU5COWyvP/i7MURvMThF2Z4l1P1WTkTrSrVflFHJae1TFSMTiOkpdjJKn X18QPfFTpHpojh4sYyaeuyodQ9HZb+sweqEnopr/JJN/hm5xFrKRBH1Rn0UkkzpQhI8i n2W12bTPA+w1IolfP7lUiNubWFjZEDoTxGH5mCrIwQ5usR4JWc2UKvvwez78eBtKVRCo pZwQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=jsy9jEof; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e6si2198278oiy.229.2020.03.19.20.03.20; Thu, 19 Mar 2020 20:03:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=jsy9jEof; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726842AbgCTDCp (ORCPT + 99 others); Thu, 19 Mar 2020 23:02:45 -0400 Received: from mail-pl1-f194.google.com ([209.85.214.194]:40065 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726596AbgCTDCp (ORCPT ); Thu, 19 Mar 2020 23:02:45 -0400 Received: by mail-pl1-f194.google.com with SMTP id h11so1905341plk.7; Thu, 19 Mar 2020 20:02:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Wy2Rb8SY1Pz/c/o65ADYdzfkIZ3xe9SUJygVcDWd17g=; b=jsy9jEofnUXn+21zXMtuprVG8J+jXN9DsDWkV7vIF9V1EdUcihkMN+d4eP06Tpi6eK wYEp1qQpvtf/1sigok9t5ii//EZ3lnljCAMuvSdnm60Y6cVNHB1HWOxxZN7y92km4M2d kmjxngCkGCPpzYazTLN6agsyIvbWZfsebekdqaAMblIzUPZrPgj04EDlQBhV6cp3k2rp SIh85/aB2P9iVHIytGoPZHC2eInGAXBmfPrW/zaSWdiYxu4hr9I8++Ec+YCtBZoWkmLn um7TlH+J+dDqO69OjZ+IBKbg+lVj1MAqsGTGtfVLydktKxdqEwdGGPx52vdBddM94z97 wqJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=Wy2Rb8SY1Pz/c/o65ADYdzfkIZ3xe9SUJygVcDWd17g=; b=Rn9d2gJeDQHU2Q44aQkgqR+l/qlz6WphGhNIY1UPZicsPXP2X9Xih7Advgt+y87qhV GG4ge65Pzdtd5ZaItRbTretPvjw7eV0DqAjDtvLmqZv7hnjAYHMDPctzE84ZMAOEd+XX EHgvve2s7MrXfAi8uEPBOZwtr+FMfTujuXc8RBYGrUjDDItTSTq1BMKQqs3SBqG2QiPx KTV163pYwTE7JxwZs/5W4LxF5L+E90Mgh1wbhujAgJmlDlUwuv8gh2Nib/vUoh8+6+hg doAczwIDVIWdoG8+VH6o18Yic/WOraWrW7jO4gkWfhaMT3Pu2u+KgVoCdTPz65M5/EFS Xfew== X-Gm-Message-State: ANhLgQ1OZaVIY8XHOApbwzsBMbrjDUY2Nc1s/8ve0QRxSanX+2MT3oAj qSu7sadFyggzZE1kqPtYBhPOL3Fs X-Received: by 2002:a17:902:b198:: with SMTP id s24mr6209268plr.89.1584673364104; Thu, 19 Mar 2020 20:02:44 -0700 (PDT) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id 5sm3752191pfw.98.2020.03.19.20.02.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 19 Mar 2020 20:02:43 -0700 (PDT) Date: Thu, 19 Mar 2020 20:02:42 -0700 From: Guenter Roeck To: Grant Peltier Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, adam.vaughn.xh@renesas.com Subject: Re: [PATCH v2 1/2] hwmon: (pmbus) add support for 2nd Gen Renesas digital multiphase Message-ID: <20200320030242.GA2413@roeck-us.net> References: <10f2ef1746e5d079ac3b3c6054ffd2bbfc314572.1584568073.git.grantpeltier93@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <10f2ef1746e5d079ac3b3c6054ffd2bbfc314572.1584568073.git.grantpeltier93@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 19, 2020 at 10:49:50AM -0500, Grant Peltier wrote: > Extend the isl68137 driver to provide support for 2nd generation Renesas > digital multiphase voltage regulators. > > Signed-off-by: Grant Peltier I hate to (have to) say that, but there are lots of checkpatch errors and warnings in this patch. total: 7 errors, 4 warnings, 182 lines checked That is really unnecessary. Please fix and resubmit. Thanks, Guenter