Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] ASoC: amd: Changing Audio Format does not reflect.
To:     Ravulapati Vishnu vardhan rao 
        <Vishnuvardhanrao.Ravulapati@amd.com>
Cc:     Alexander.Deucher@amd.com, broonie@kernel.org,
        Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Akshu Agrawal <akshu.agrawal@amd.com>,
        Wei Yongjun <weiyongjun1@huawei.com>,
        "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." 
        <alsa-devel@alsa-project.org>,
        open list <linux-kernel@vger.kernel.org>
References: <1584616991-27348-1-git-send-email-Vishnuvardhanrao.Ravulapati@amd.com>
From:   "Agrawal, Akshu" <aagrawal2@amd.com>
Message-ID: <8b1ab5dd-954e-29b7-b51f-f8c3e09a1521@amd.com>
Date:   Fri, 20 Mar 2020 09:39:21 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.2
In-Reply-To: <1584616991-27348-1-git-send-email-Vishnuvardhanrao.Ravulapati@amd.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [172.31.32.35] (165.204.159.242) by PN1PR0101CA0040.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:c::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2835.19 via Frontend Transport; Fri, 20 Mar 2020 04:09:28 +0000
X-Originating-IP: [165.204.159.242]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: ad0a8dcb-b965-4199-5e65-08d7cc848058
X-MS-TrafficTypeDiagnostic: DM5PR12MB2486:|DM5PR12MB2486:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM5PR12MB2486876A00F580E6B09DFF4AF8F50@DM5PR12MB2486.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-Forefront-PRVS: 03484C0ABF
X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4636009)(346002)(396003)(366004)(136003)(39860400002)(376002)(199004)(52116002)(16576012)(36756003)(316002)(37006003)(956004)(2616005)(54906003)(16526019)(53546011)(186003)(5660300002)(66556008)(26005)(2906002)(66476007)(66946007)(8936002)(31696002)(6486002)(81156014)(31686004)(6666004)(8676002)(81166006)(478600001)(6636002)(6862004)(4326008);DIR:OUT;SFP:1101;SCL:1;SRVR:DM5PR12MB2486;H:DM5PR12MB1849.namprd12.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;
Received-SPF: None (protection.outlook.com: amd.com does not designate
 permitted sender hosts)
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 5dVrL3yn0nHp/iYZkV0+FmY0jL8+wJ8vvE1PVmmi7Vd5i6G6eSP1wZ0GwM2xfVUoBgOeuatBWPzIURB85Qemf9US3eKD9Xtl3WfGPn6EhF+b1I0ZWR80vQyJ6jqZTLRFtK0lq6njKbK1dqIzhXkIdvM/ssjkcV/bTQMbVE7VuJTg4+9bSlPmSO8nWt/yO7LHLC5vaBdwCNQ9An2WznufYjwOW/eEgFcgRwAJ7VqTpPju8zpNoUT1tykZgGomyhv3YNWVKK6gmrFJHj30uipYaiX9XPdqk4hP+VwIfB9N4G+ixusDKkp2Nz0lUzdlW0QqKwr8t2e2a+iCPI2YxQUziK6B9lyyBMT8u6FjbbORrPfIat82EniMg0sUYTxESQ3/7NuBwxzHZsP1fUiMuXJm5Of3uQVSQoQmyX4i52L/FVRcABYG0+by+a2hHOGW6nbN
X-MS-Exchange-AntiSpam-MessageData: mkqLAvhy2F07y17z+KjlVdaujYsPKoetzlUcIXUhpJFnxPdq4nRSqU1KZ7hhrBOYCwfwnAnxceo/OwEr641CfjgOgeqZAP4Eg+KyJgyxmyu+ToClbuwuVXtv6kL6v0nE3YoXlQV2wugEgq+9VM+OHg==
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ad0a8dcb-b965-4199-5e65-08d7cc848058
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Mar 2020 04:09:36.3815
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pgVcDxTI87IUz7FpLo5xeUv/oSVTfjSXbdEX/QQJN+a4t9prL1aXDyhUUDQhFgvZwrpXDaa/uoe1hxRymB1YAw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB2486
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 3/19/2020 4:52 PM, Ravulapati Vishnu vardhan rao wrote:
> When you run aplay subsequently as below by changing the stream format:
>
> aplay -Dhw:2,0 -c2 -fS16_LE -r48000 /dev/zero -vv -d 5;aplay -Dhw:2,0
> -c2 -fS24_LE -r48000 /dev/zero -vv
> as a single command, the format gets corrupted and audio does not play.
>
> So clear the ACP_(I2S/BT)TDM_ITER/IRER register when dma stops.
>
> Signed-off-by: Ravulapati Vishnu vardhan rao <Vishnuvardhanrao.Ravulapati@amd.com>
> ---
>   sound/soc/amd/raven/acp3x-i2s.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/sound/soc/amd/raven/acp3x-i2s.c b/sound/soc/amd/raven/acp3x-i2s.c
> index 3a3c47e..b07c50a 100644
> --- a/sound/soc/amd/raven/acp3x-i2s.c
> +++ b/sound/soc/amd/raven/acp3x-i2s.c
> @@ -240,9 +240,7 @@ static int acp3x_i2s_trigger(struct snd_pcm_substream *substream,
>   				reg_val = mmACP_I2STDM_IRER;
>   			}
>   		}
> -		val = rv_readl(rtd->acp3x_base + reg_val);
> -		val = val & ~BIT(0);
> -		rv_writel(val, rtd->acp3x_base + reg_val);
> +		rv_writel(0, rtd->acp3x_base + reg_val);

Clearing the entire register might result in issues.

IMO better fix is to have a sample_len mask for ITER and IRER register.

Use it to clear sample length bits in acp3x_i2s_hwparams function before 
setting the new format resolution.


Thanks,

Akshu