Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1584502378-12609-1-git-send-email-iamjoonsoo.kim@lge.com>
 <1584502378-12609-3-git-send-email-iamjoonsoo.kim@lge.com> <99196b17-24fb-8990-2d21-c459d2321747@suse.cz>
In-Reply-To: <99196b17-24fb-8990-2d21-c459d2321747@suse.cz>
From:   Joonsoo Kim <js1304@gmail.com>
Date:   Fri, 20 Mar 2020 16:40:42 +0900
Message-ID: <CAAmzW4NJd2kh8-81sYLjRR8gcsmLpndhS4s5Jh6kB-FLM-wNKg@mail.gmail.com>
Subject: Re: [PATCH v2 2/2] mm/page_alloc: integrate classzone_idx and high_zoneidx
To:     Vlastimil Babka <vbabka@suse.cz>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Linux Memory Management List <linux-mm@kvack.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Michal Hocko <mhocko@kernel.org>,
        Minchan Kim <minchan@kernel.org>,
        Mel Gorman <mgorman@techsingularity.net>, kernel-team@lge.com,
        Ye Xiaolong <xiaolong.ye@intel.com>,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

2020=EB=85=84 3=EC=9B=94 19=EC=9D=BC (=EB=AA=A9) =EC=98=A4=ED=9B=84 9:32, V=
lastimil Babka <vbabka@suse.cz>=EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1:
>
> On 3/18/20 4:32 AM, js1304@gmail.com wrote:
> > From: Joonsoo Kim <iamjoonsoo.kim@lge.com>
> >
> > classzone_idx is just different name for high_zoneidx now.
> > So, integrate them and add some comment to struct alloc_context
> > in order to reduce future confusion about the meaning of this variable.
> >
> > In addition to integration, this patch also renames high_zoneidx
> > to highest_zoneidx since it represents more precise meaning.
>
> 2 years ago I suggested max_zone_idx.
> Not insisting, but perhaps max_zoneidx would simply be shorter than
> highest_zoneidx, while saying the same thing?

I think that highest_zoneidx looks more familiar than max_zoneidx since
it is previously high_zoneidx. It would cause less confusion.

> Also I wonder if we still need the accessor ac_classzone_idx() (before re=
name),
> or just replace it with ac->highest_zoneidx (or whatever the final name i=
s)
> instead of renaming it?

Okay. Looks like we don't need the accessor. I will use open-code.

Thanks.