Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
USER-AGENT: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
Message-ID: <20200320131429.GH4650@kadam>
Date:   Fri, 20 Mar 2020 06:14:29 -0700 (PDT)
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Leon Romanovsky <leonro@mellanox.com>
Cc:     YueHaibing <yuehaibing@huawei.com>,
        Derek Chickles <dchickles@marvell.com>,
        "David S . Miller" <davem@davemloft.net>,
        Satanand Burla <sburla@marvell.com>,
        Felix Manlunas <fmanlunas@marvell.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
        Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH net-next] liquidio: remove set but not used variable 's'
References: <20200306023254.61731-1-yuehaibing@huawei.com>
 <20200319120743.28056-1-yuehaibing@huawei.com>
 <20200319121035.GO126814@unreal>
In-Reply-To: <20200319121035.GO126814@unreal>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Mar 19, 2020 at 02:10:35PM +0200, Leon Romanovsky wrote:
> On Thu, Mar 19, 2020 at 12:07:43PM +0000, YueHaibing wrote:
> > Fixes gcc '-Wunused-but-set-variable' warning:
> >
> > drivers/net/ethernet/cavium/liquidio/lio_main.c: In function 'octeon_chip_specific_setup':
> > drivers/net/ethernet/cavium/liquidio/lio_main.c:1378:8: warning:
> >  variable 's' set but not used [-Wunused-but-set-variable]
> >
> > It's not used since commit b6334be64d6f ("net/liquidio: Delete driver version assignment")
> >
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> > ---
> >  drivers/net/ethernet/cavium/liquidio/lio_main.c | 5 -----
> >  1 file changed, 5 deletions(-)
> >
> 
> I'm sorry for missing this warning.
> 

The warning is not enabled by default.

regards,
dan carpenter