Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1584710495-308969-1-git-send-email-vincent.donnefort@arm.com> <e400d0b1-173f-bcfd-40c0-2e473e14e7ae@arm.com>
In-Reply-To: <e400d0b1-173f-bcfd-40c0-2e473e14e7ae@arm.com>
From:   Vincent Guittot <vincent.guittot@linaro.org>
Date:   Fri, 20 Mar 2020 14:57:57 +0100
Message-ID: <CAKfTPtAiFpAd7NnQorNajQZn4FV+Nn01yv_KNJcgd+MFLnH1sw@mail.gmail.com>
Subject: Re: [PATCH] sched: Remove unused last_load_update_tick rq member
To:     Dietmar Eggemann <dietmar.eggemann@arm.com>
Cc:     Vincent Donnefort <vincent.donnefort@arm.com>,
        Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Valentin Schneider <valentin.schneider@arm.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 20 Mar 2020 at 14:44, Dietmar Eggemann <dietmar.eggemann@arm.com> wrote:
>
> + Vincent Guittot

Thanks Dietmar

>
> On 20.03.20 14:21, vincent.donnefort@arm.com wrote:
> > From: Vincent Donnefort <vincent.donnefort@arm.com>
> >
> > The commit 5e83eafbfd3b ("sched/fair: Remove the rq->cpu_load[] update
> > code") eliminated the use case for rq->last_load_update_tick. Removing
> > it.
> >
> > Signed-off-by: Vincent Donnefort <vincent.donnefort@arm.com>

Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>

> >
> > diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> > index 1a9983d..c41ee26 100644
> > --- a/kernel/sched/core.c
> > +++ b/kernel/sched/core.c
> > @@ -6685,7 +6685,6 @@ void __init sched_init(void)
> >
> >               rq_attach_root(rq, &def_root_domain);
> >  #ifdef CONFIG_NO_HZ_COMMON
> > -             rq->last_load_update_tick = jiffies;
> >               rq->last_blocked_load_update_tick = jiffies;
> >               atomic_set(&rq->nohz_flags, 0);
> >  #endif
> > diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
> > index 9ea6478..6e14fad 100644
> > --- a/kernel/sched/sched.h
> > +++ b/kernel/sched/sched.h
> > @@ -860,7 +860,6 @@ struct rq {
> >  #endif
> >  #ifdef CONFIG_NO_HZ_COMMON
> >  #ifdef CONFIG_SMP
> > -     unsigned long           last_load_update_tick;
> >       unsigned long           last_blocked_load_update_tick;
> >       unsigned int            has_blocked_load;
> >  #endif /* CONFIG_SMP */
>
> Reviewed-by: Dietmar Eggemann <dietmar.eggemann@arm.com>