Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Alim Akhtar" <alim.akhtar@samsung.com>
To:     =?utf-8?Q?'Pawe=C5=82_Chmiel'?= <pawel.mikolaj.chmiel@gmail.com>
Cc:     <krzk@kernel.org>, <avri.altman@wdc.com>,
        <martin.petersen@oracle.com>, <kwmad.kim@samsung.com>,
        <stanley.chu@mediatek.com>, <cang@codeaurora.org>,
        <linux-samsung-soc@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, <robh+dt@kernel.org>,
        <devicetree@vger.kernel.org>, <linux-scsi@vger.kernel.org>
In-Reply-To: <1d128596eeefb414b7b621b0db5ca0697030dbfc.camel@gmail.com>
Subject: RE: [PATCH v3 0/5] exynos-ufs: Add support for UFS HCI
Date:   Fri, 20 Mar 2020 19:40:08 +0530
Message-ID: <007c01d5fec1$45097a90$cf1c6fb0$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQHwhQl1rFhj6z9XfaQCH7KvMUfWFgG8Fm24AZkWDOaoAcxu4A==
Content-Language: en-in
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
References: <CGME20200319150701epcas5p4bb4365de0a0f4a4a6c7bc533e16d66ec@epcas5p4.samsung.com>
        <20200319150031.11024-1-alim.akhtar@samsung.com>
        <1d128596eeefb414b7b621b0db5ca0697030dbfc.camel@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hello Pawel
Thanks for helping in testing.

> -----Original Message-----
> From: Pawe=C5=82=20Chmiel=20<pawel.mikolaj.chmiel=40gmail.com>=0D=0A>=20S=
ent:=2020=20March=202020=2001:12=0D=0A>=20To:=20Alim=20Akhtar=20<alim.akhta=
r=40samsung.com>=0D=0A>=20Cc:=20krzk=40kernel.org;=20avri.altman=40wdc.com;=
=20martin.petersen=40oracle.com;=0D=0A>=20kwmad.kim=40samsung.com;=20stanle=
y.chu=40mediatek.com;=0D=0A>=20cang=40codeaurora.org;=20linux-samsung-soc=
=40vger.kernel.org;=20linux-arm-=0D=0A>=20kernel=40lists.infradead.org;=20l=
inux-kernel=40vger.kernel.org;=20robh+dt=40kernel.org;=0D=0A>=20devicetree=
=40vger.kernel.org;=20linux-scsi=40vger.kernel.org=0D=0A>=20Subject:=20Re:=
=20=5BPATCH=20v3=200/5=5D=20exynos-ufs:=20Add=20support=20for=20UFS=20HCI=
=0D=0A>=20=0D=0A>=20On=20Thu,=202020-03-19=20at=2020:30=20+0530,=20Alim=20A=
khtar=20wrote:=0D=0A>=20>=20This=20patch-set=20introduces=20UFS=20(Universa=
l=20Flash=20Storage)=20host=0D=0A>=20>=20controller=20support=20for=20Samsu=
ng=20family=20SoC.=20Mostly,=20it=20consists=20of=20UFS=20PHY=20and=0D=0A>=
=20host=20specific=20driver.=0D=0A>=20>=0D=0A>=20>=20-=20Changes=20since=20=
v2:=0D=0A>=20>=20*=20fixed=20build=20warning=20by=20kbuild=20test=20robot=
=0D=0A>=20>=20*=20Added=20Reported-by=20tags=0D=0A>=20>=0D=0A>=20>=20-=20Ch=
anges=20since=20v1:=0D=0A>=20>=20*=20fixed=20make=20dt_binding_check=20erro=
r=20as=20pointed=20by=20Rob=0D=0A>=20>=20*=20Addressed=20Krzysztof's=20revi=
ew=20comments=0D=0A>=20>=20*=20Added=20Reviewed-by=20tags=0D=0A>=20>=0D=0A>=
=20>=0D=0A>=20>=20patch=201/5:=20define=20devicetree=20bindings=20for=20UFS=
=20PHY=20patch=202/5:=20Adds=20UFS=0D=0A>=20>=20PHY=20driver=20patch=203/5:=
=20define=20devicetree=20bindings=20for=20UFS=20HCI=20patch=0D=0A>=20>=204/=
5:=20Adds=20Samsung=20UFS=20HCI=20driver=20patch=205/5:=20Enabled=20UFS=20o=
n=20exynos7=0D=0A>=20>=20platform=0D=0A>=20Hi=0D=0A>=20Is=20this=20compatib=
le=20with=20Exynos7420?=20Looking=20at=20u-boot=20source=20code,=20there=20=
is=0D=0A>=20Espresso7420=20-=20isn't=20it=20the=20same=20device?=20Also=20t=
his=20driver=20looks=20very=20similar=20to=20the=0D=0A>=20one=20from=20vend=
or=20kernel=20sources=20(for=20my=20device).=0D=0A>=20=0D=0AExynos7=20and=
=20Exynos7420=20are=20compatible=20and=20belong=20to=20same=20Exynos=20SoC=
=20series=20(but=20there=20are=20some=20fine=20differences)=0D=0A=0D=0A>=20=
I=20did=20tried=20to=20run=20this=20on=20my=20Exynos7420=20based=20device=
=20(Samsung=20S6=20Edge=0D=0A>=20phone)=20with=205.6-rc6,=20to=20get=20any=
=20storage=20working=20(since=20it=20doesn't=20have=20sdcard=0D=0A>=20slot)=
.=0D=0A>=20=0D=0AI=20think=20this=20should=20work=20on=20S6=20Edge,=20but=
=20not=20entirely=20sure,=20as=20I=20am=20not=20aware=20of=20the=20S6=20H/W=
=20schematic,=20specially=20PMIC=20connection.=0D=0A=0D=0A>=20At=20first=20=
i=20got=20error=20in=20exynos_ufs_config_smu.=20Looking=20at=20vendor=20sou=
rces,=20on=20my=0D=0A>=20device=20only=20secureos=20is=20able=20to=20write=
=20to=20those=20registers=20so=20i=20fixed=20it=20by=20using=20smc=0D=0A>=
=20calls=20and=20driver=20probes=20fine.=20Will=20this=20be=20also=20suppor=
ted=20by=20driver=20(maybe=20in=0D=0A>=20future)?=0D=0A>=20=0D=0A>=20But=20=
now=20got=20another=20error=0D=0A>=20=5B=20=20=20=201.610464=5D=20exynos-uf=
shc=2015570000.ufs:=20ufshcd_intr:=20Unhandled=0D=0A>=20interrupt=200x00000=
000=0D=0A>=20=5B=20=20=20=201.610629=5D=20host_regs:=2000000000:=200383ff0f=
=2000000000=2000000200=2000000000=0D=0A>=20=5B=20=20=20=201.610747=5D=20hos=
t_regs:=2000000010:=2000000101=2000007fce=2000000000=2000000000=0D=0A>=20=
=5B=20=20=20=201.610863=5D=20host_regs:=2000000020:=2000000000=2000030e75=
=2000000000=2000000000=0D=0A>=20=5B=20=20=20=201.614727=5D=20host_regs:=200=
0000030:=200000000f=2000000000=2000000000=2000000000=0D=0A>=20=5B=20=20=20=
=201.621061=5D=20host_regs:=2000000040:=2000000000=2000000000=2000000000=20=
00000000=0D=0A>=20=5B=20=20=20=201.627396=5D=20host_regs:=2000000050:=20f8c=
37000=2000000000=2000000001=2000000000=0D=0A>=20=5B=20=20=20=201.633730=5D=
=20host_regs:=2000000060:=2000000001=2000000000=2000000000=2000000000=0D=0A=
>=20=5B=20=20=20=201.640065=5D=20host_regs:=2000000070:=20f9644000=20000000=
00=2000000000=2000000000=0D=0A>=20=5B=20=20=20=201.646400=5D=20host_regs:=
=2000000080:=2000000001=2000000000=2000000000=2000000000=0D=0A>=20=5B=20=20=
=20=201.652734=5D=20host_regs:=2000000090:=2000000002=2095290000=2000000000=
=2000000000=0D=0A>=20=5B=20=20=20=201.747649=5D=20exynos-ufshc=2015570000.u=
fs:=20ufshcd_intr:=20Unhandled=0D=0A>=20interrupt=200x00000000=0D=0A>=20=5B=
=20=20=20=201.747807=5D=20host_regs:=2000000000:=200383ff0f=2000000000=2000=
000200=2000000000=0D=0A>=20=5B=20=20=20=201.747924=5D=20host_regs:=20000000=
10:=2000000101=2000007fce=2000000000=2000000000=0D=0A>=20=5B=20=20=20=201.7=
48041=5D=20host_regs:=2000000020:=2000000000=2000030e75=2000000000=20000000=
00=0D=0A>=20=5B=20=20=20=201.751909=5D=20host_regs:=2000000030:=200000000f=
=2000000000=2000000000=2000000000=0D=0A>=20=5B=20=20=20=201.758244=5D=20hos=
t_regs:=2000000040:=2000000000=2000000000=2000000000=2000000000=0D=0A>=20=
=5B=20=20=20=201.764578=5D=20host_regs:=2000000050:=20f8c37000=2000000000=
=2000000001=2000000000=0D=0A>=20=5B=20=20=20=201.770913=5D=20host_regs:=200=
0000060:=2000000001=2000000000=2000000000=2000000000=0D=0A>=20=5B=20=20=20=
=201.777248=5D=20host_regs:=2000000070:=20f9644000=2000000000=2000000000=20=
00000000=0D=0A>=20=5B=20=20=20=201.783582=5D=20host_regs:=2000000080:=20000=
00001=2000000000=2000000000=2000000000=0D=0A>=20=5B=20=20=20=201.789917=5D=
=20host_regs:=2000000090:=2000000002=2095290000=2000000000=2000000000=0D=0A=
>=20=5B=20=20=20=201.884841=5D=20exynos-ufshc=2015570000.ufs:=20ufshcd_intr=
:=20Unhandled=0D=0A>=20interrupt=200x00000000=0D=0A>=20=5B=20=20=20=201.884=
999=5D=20host_regs:=2000000000:=200383ff0f=2000000000=2000000200=2000000000=
=0D=0A>=20=5B=20=20=20=201.885116=5D=20host_regs:=2000000010:=2000000101=20=
00007fce=2000000000=2000000000=0D=0A>=20=5B=20=20=20=201.885233=5D=20host_r=
egs:=2000000020:=2000000000=2000030e75=2000000000=2000000000=0D=0A>=20=5B=
=20=20=20=201.889100=5D=20host_regs:=2000000030:=200000000f=2000000000=2000=
000000=2000000000=0D=0A>=20=5B=20=20=20=201.895435=5D=20host_regs:=20000000=
40:=2000000000=2000000000=2000000000=2000000000=0D=0A>=20=5B=20=20=20=201.9=
01770=5D=20host_regs:=2000000050:=20f8c37000=2000000000=2000000001=20000000=
00=0D=0A>=20=5B=20=20=20=201.908104=5D=20host_regs:=2000000060:=2000000001=
=2000000000=2000000000=2000000000=0D=0A>=20=5B=20=20=20=201.914439=5D=20hos=
t_regs:=2000000070:=20f9644000=2000000000=2000000000=2000000000=0D=0A>=20=
=5B=20=20=20=201.920773=5D=20host_regs:=2000000080:=2000000001=2000000000=
=2000000000=2000000000=0D=0A>=20=5B=20=20=20=201.927108=5D=20host_regs:=200=
0000090:=2000000002=2095290000=2000000000=2000000000=0D=0A>=20=5B=20=20=20=
=202.998155=5D=20exynos-ufshc=2015570000.ufs:=20ufshcd_query_flag:=20Sendin=
g=0D=0A>=20flag=20query=20for=20idn=201=20failed,=20err=20=3D=20-11=0D=0A>=
=20=5B=20=20=20=204.502138=5D=20exynos-ufshc=2015570000.ufs:=20ufshcd_query=
_flag:=20Sending=0D=0A>=20flag=20query=20for=20idn=201=20failed,=20err=20=
=3D=20-11=0D=0A>=20=5B=20=20=20=206.006137=5D=20exynos-ufshc=2015570000.ufs=
:=20ufshcd_query_flag:=20Sending=0D=0A>=20flag=20query=20for=20idn=201=20fa=
iled,=20err=20=3D=20-11=0D=0A>=20=5B=20=20=20=206.006311=5D=20exynos-ufshc=
=2015570000.ufs:=20ufshcd_query_flag_retry:=0D=0A>=20query=20attribute,=20o=
pcode=205,=20idn=201,=20failed=20with=20error=20-11=20after=203=20retires=
=0D=0A>=20=5B=20=20=20=206.006545=5D=20exynos-ufshc=2015570000.ufs:=20ufshc=
d_complete_dev_init=0D=0A>=20reading=20fDeviceInit=20flag=20failed=20with=
=20error=20-11=0D=0A>=20=0D=0A>=20Do=20You=20have=20any=20idea=20what=20cou=
ld=20be=20wrong?=0D=0A>=20=0D=0ATo=20me,=20It=20looks=20like=20UFS=20device=
=20is=20not=20powered=20ON=20or=20properly=20Reseted,=20I=20have=20seen=20t=
his=20kind=20of=20issues=20in=20past=20and=20=0D=0AAFAIR,=20fix=20was=20to=
=20keep=20the=20PMIC=20rail=20which=20was=20hook=20to=20device=20RESET_N=20=
always-on.=0D=0A=0D=0A>=20Thanks=20=0D=0A>=20>=0D=0A>=20>=20Note:=20This=20=
series=20is=20based=20on=20Linux-5.6-rc6=20(commit:=20fb33c6510d55)=0D=0A>=
=20>=0D=0A>=20>=0D=0A>=20>=20Alim=20Akhtar=20(5):=0D=0A>=20>=20=20=20dt-bin=
dings:=20phy:=20Document=20Samsung=20UFS=20PHY=20bindings=0D=0A>=20>=20=20=
=20phy:=20samsung-ufs:=20add=20UFS=20PHY=20driver=20for=20samsung=20SoC=0D=
=0A>=20>=20=20=20Documentation:=20devicetree:=20ufs:=20Add=20DT=20bindings=
=20for=20exynos=20UFS=20host=0D=0A>=20>=20=20=20=20=20controller=0D=0A>=20>=
=20=20=20scsi:=20ufs-exynos:=20add=20UFS=20host=20support=20for=20Exynos=20=
SoCs=0D=0A>=20>=20=20=20arm64:=20dts:=20Add=20node=20for=20ufs=20exynos7=0D=
=0A>=20>=0D=0A>=20>=20=20.../bindings/phy/samsung,ufs-phy.yaml=20=20=20=20=
=20=20=20=20=20=7C=20=20=2062=20+=0D=0A>=20>=20=20.../devicetree/bindings/u=
fs/ufs-exynos.txt=20=20=20=20=7C=20=20104=20++=0D=0A>=20>=20=20.../boot/dts=
/exynos/exynos7-espresso.dts=20=20=20=20=20=20=7C=20=20=2016=20+=0D=0A>=20>=
=20=20arch/arm64/boot/dts/exynos/exynos7.dtsi=20=20=20=20=20=20=20=7C=20=20=
=2044=20+-=0D=0A>=20>=20=20drivers/phy/samsung/Kconfig=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=7C=20=20=20=209=20+=0D=0A>=20>=20=20dr=
ivers/phy/samsung/Makefile=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=7C=20=20=20=201=20+=0D=0A>=20>=20=20drivers/phy/samsung/phy-exynos7-=
ufs.h=20=20=20=20=20=20=20=20=20=7C=20=20=2085=20+=0D=0A>=20>=20=20drivers/=
phy/samsung/phy-samsung-ufs.c=20=20=20=20=20=20=20=20=20=7C=20=20311=20++++=
=0D=0A>=20>=20=20drivers/phy/samsung/phy-samsung-ufs.h=20=20=20=20=20=20=20=
=20=20=7C=20=20100=20++=0D=0A>=20>=20=20drivers/scsi/ufs/Kconfig=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=7C=20=20=2012=20+=
=0D=0A>=20>=20=20drivers/scsi/ufs/Makefile=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=7C=20=20=20=201=20+=0D=0A>=20>=20=20drivers/=
scsi/ufs/ufs-exynos.c=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=7C=
=201399=20+++++++++++++++++=0D=0A>=20>=20=20drivers/scsi/ufs/ufs-exynos.h=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=7C=20=20268=20++++=0D=
=0A>=20>=20=20drivers/scsi/ufs/unipro.h=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=7C=20=20=2041=20+=0D=0A>=20>=20=20include/linux=
/phy/phy-samsung-ufs.h=20=20=20=20=20=20=20=20=20=20=20=7C=20=20=2070=20+=
=0D=0A>=20>=20=2015=20files=20changed,=202521=20insertions(+),=202=20deleti=
ons(-)=20=20create=20mode=0D=0A>=20>=20100644=20Documentation/devicetree/bi=
ndings/phy/samsung,ufs-phy.yaml=0D=0A>=20>=20=20create=20mode=20100644=0D=
=0A>=20>=20Documentation/devicetree/bindings/ufs/ufs-exynos.txt=0D=0A>=20>=
=20=20create=20mode=20100644=20drivers/phy/samsung/phy-exynos7-ufs.h=0D=0A>=
=20>=20=20create=20mode=20100644=20drivers/phy/samsung/phy-samsung-ufs.c=0D=
=0A>=20>=20=20create=20mode=20100644=20drivers/phy/samsung/phy-samsung-ufs.=
h=0D=0A>=20>=20=20create=20mode=20100644=20drivers/scsi/ufs/ufs-exynos.c=20=
=20create=20mode=20100644=0D=0A>=20>=20drivers/scsi/ufs/ufs-exynos.h=20=20c=
reate=20mode=20100644=0D=0A>=20>=20include/linux/phy/phy-samsung-ufs.h=0D=
=0A>=20>=0D=0A=0D=0A=0D=0A