Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH bpf-next 1/2] bpf: tcp: Fix unused function warnings
To:     Yonghong Song <yhs@fb.com>, YueHaibing <yuehaibing@huawei.com>,
        lmb@cloudflare.com, jakub@cloudflare.com, john.fastabend@gmail.com
Cc:     davem@davemloft.net, netdev@vger.kernel.org, bpf@vger.kernel.org,
        linux-kernel@vger.kernel.org, andrii.nakryiko@gmail.com
References: <20200319124631.58432-1-yuehaibing@huawei.com>
 <20200320023426.60684-1-yuehaibing@huawei.com>
 <20200320023426.60684-2-yuehaibing@huawei.com>
 <d18a19a0-f147-03ad-b8a5-4b502199cd72@fb.com>
From:   Daniel Borkmann <daniel@iogearbox.net>
Message-ID: <71161d44-da82-b4ae-ee9e-8291d9d03021@iogearbox.net>
Date:   Fri, 20 Mar 2020 16:01:32 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.2
MIME-Version: 1.0
In-Reply-To: <d18a19a0-f147-03ad-b8a5-4b502199cd72@fb.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 3/20/20 5:21 AM, Yonghong Song wrote:
> On 3/19/20 7:34 PM, YueHaibing wrote:
>> If BPF_STREAM_PARSER is not set, gcc warns:
>>
>> net/ipv4/tcp_bpf.c:483:12: warning: 'tcp_bpf_sendpage' defined but not used [-Wunused-function]
>> net/ipv4/tcp_bpf.c:395:12: warning: 'tcp_bpf_sendmsg' defined but not used [-Wunused-function]
>> net/ipv4/tcp_bpf.c:13:13: warning: 'tcp_bpf_stream_read' defined but not used [-Wunused-function]
>>
>> Moves the unused functions into the #ifdef
> 
> Maybe explicit "into the #ifdef CONFIG_BPF_STREAM_PARSER"?
> 
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Fixes: f747632b608f ("bpf: sockmap: Move generic sockmap hooks from BPF TCP")
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> Reviewed-by: Lorenz Bauer <lmb@cloudflare.com>
>> Reviewed-by: Jakub Sitnicki <jakub@cloudflare.com>
> 
> Acked-by: Yonghong Song <yhs@fb.com>

Both applied and addressed feedback from Yonghong, thanks!