Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v7 00/48] atmel_mxt_ts misc
To:     "Wang, Jiada" <jiada_wang@mentor.com>, jikos@kernel.org,
        benjamin.tissoires@redhat.com, rydberg@bitmath.org,
        dmitry.torokhov@gmail.com, nick@shmanahar.org, bsz@semihalf.com
Cc:     linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
        erosca@de.adit-jv.com, Andrew_Gabbasov@mentor.com
References: <20200212084218.32344-1-jiada_wang@mentor.com>
 <c583d151-9243-cbde-a04b-bc0389d9be5a@gmail.com>
 <89e4bb0b-b2eb-0b67-4307-fb2af914b1c0@mentor.com>
From:   Dmitry Osipenko <digetx@gmail.com>
Message-ID: <f9b221e7-f189-3e47-adab-1cbc49490d4b@gmail.com>
Date:   Fri, 20 Mar 2020 18:53:55 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.5.0
MIME-Version: 1.0
In-Reply-To: <89e4bb0b-b2eb-0b67-4307-fb2af914b1c0@mentor.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hello Jiada,

20.03.2020 06:37, Wang, Jiada пишет:
> Hello Dmitry
> 
> I have submitted v8 patch-set to address your comments towards v7
> patch-set,
> most of checkpatch warnings and errors have been addressed,
> 
> But I didn't update for following two types of warnings
> since I want to keep consistency with legacy code
> 
> WARNING: DEVICE_ATTR unusual permissions '0600' used
> #290: FILE: drivers/input/touchscreen/atmel_mxt_ts.c:3761:
> +static DEVICE_ATTR(debug_v2_enable, 0600, NULL,

What will happen if you'll use 0644? Will an empty line be returned or
driver will crash?

> WARNING: Consider renaming function(s) 'mxt_debug_notify_show' to
> 'debug_notify_show'
> #292: FILE: drivers/input/touchscreen/atmel_mxt_ts.c:3763:
> +static DEVICE_ATTR(debug_notify, 0444, mxt_debug_notify_show, NULL);

Perhaps this should be fine to ignore, although the prefix is indeed a
bit superfluous.

> please let me know if you have different view on this

Thank you very much, I'll test v8 during the weekend.