Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
References: <20191212071847.45561-1-alison.wang@nxp.com> <CAGgjyvHHzPWjRTqxYmGCmk3qa6=kOezHywVDFomgD6UNj-zwpQ@mail.gmail.com>
 <VI1PR04MB40627CDD5F0C17D8DCDCFFE2F4550@VI1PR04MB4062.eurprd04.prod.outlook.com>
 <VI1PR04MB4062C67906888DA8142C17E1F4550@VI1PR04MB4062.eurprd04.prod.outlook.com>
 <CAGgjyvGAjx1SV=K66AM24DxMTA_sAF2uhhDw5gXCFTGNZi8E7Q@mail.gmail.com>
 <VI1PR04MB40620DD55D5ED0FDC3E94C2BF4550@VI1PR04MB4062.eurprd04.prod.outlook.com>
 <20191212122318.GB4310@sirena.org.uk> <CAJ+vNU0xZOb0R2VNkq6k3efdkgQUtO_-cEdNgZ643nt_G=vevQ@mail.gmail.com>
 <af99c9abd9c2aec6a074fb05310c56b780725ebd.camel@toradex.com> <CAJ+vNU16ax9JTx2kSMUF8SiVD-+4KGoFO-U07xM5eE=T6Fwjhw@mail.gmail.com>
In-Reply-To: <CAJ+vNU16ax9JTx2kSMUF8SiVD-+4KGoFO-U07xM5eE=T6Fwjhw@mail.gmail.com>
From:   Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
Date:   Fri, 20 Mar 2020 19:05:40 +0200
Message-ID: <CAGgjyvFNCbFw7x6QL063oi-fV2UuVQVfL1cv_pQ74HWoJS4Etg@mail.gmail.com>
Subject: Re: [alsa-devel] [EXT] Re: [PATCH] ASoC: sgtl5000: Revert "ASoC:
 sgtl5000: Fix of unmute outputs on probe"
To:     Tim Harvey <tharvey@gateworks.com>
Cc:     Marcel Ziswiler <marcel.ziswiler@toradex.com>,
        "broonie@kernel.org" <broonie@kernel.org>,
        "alison.wang@nxp.com" <alison.wang@nxp.com>,
        "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
        "festevam@gmail.com" <festevam@gmail.com>,
        Igor Opanyuk <igor.opanyuk@toradex.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from mail-qt1-f170.google.com (209.85.160.170) by BL0PR1501CA0027.namprd15.prod.outlook.com (2603:10b6:207:17::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2835.20 via Frontend Transport; Fri, 20 Mar 2020 17:05:56 +0000
Received: by mail-qt1-f170.google.com with SMTP id z8so5485642qto.12        for <linux-kernel@vger.kernel.org>; Fri, 20 Mar 2020 10:05:56 -0700 (PDT)
X-Gm-Message-State: ANhLgQ1i68E1I2RhXov+kvq7utk7nqvHu2foPSZSKIGjE9iw2Q9z+lVJ
        gPAD1NTI1jusRAQNbl9RTUhQbYLihTq7f5deXcw=
X-Received: by 2002:ac8:1633:: with SMTP id p48mr9494130qtj.305.1584723952240;
 Fri, 20 Mar 2020 10:05:52 -0700 (PDT)
X-Gmail-Original-Message-ID: <CAGgjyvFNCbFw7x6QL063oi-fV2UuVQVfL1cv_pQ74HWoJS4Etg@mail.gmail.com>
X-Originating-IP: [209.85.160.170]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 278d9382-64a1-4222-a2cc-08d7ccf0f48d
X-MS-TrafficTypeDiagnostic: VI1PR05MB3472:
X-Microsoft-Antispam-PRVS: <VI1PR05MB3472F61607F7D6B43AC3D12CF9F50@VI1PR05MB3472.eurprd05.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-Forefront-PRVS: 03484C0ABF
X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4636009)(396003)(366004)(39850400004)(136003)(346002)(376002)(199004)(44832011)(52116002)(86362001)(6666004)(81156014)(8676002)(81166006)(478600001)(6862004)(316002)(8936002)(5660300002)(42186006)(55446002)(66476007)(9686003)(26005)(2906002)(4326008)(66556008)(54906003)(53546011)(107886003)(66946007)(55236004)(186003);DIR:OUT;SFP:1102;SCL:1;SRVR:VI1PR05MB3472;H:VI1PR05MB3279.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;
Received-SPF: None (protection.outlook.com: toradex.com does not designate
 permitted sender hosts)
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: s1lEOtfAg0xyGTpKIfHj0m61Q/6dtj1b2qkN1O4IuC/mHeuSAiVQoeAUllxQXRHaRWgyaIJZ4DU22CC9v4FOrScXPE6j/AekmaOYt+/Gg6tTVU+FhfmsE/CoRZ5lLVqJl2nKkB3aDIpBzsx4+xaoMoZKFkpdH0ZwnRdk5HYw4UCaw7mZw8NJfxGU4YS4/Usav+jjqjCtUpVSa/avA9Vu4GNSWyRmiQflKnVM2r0aAuI8sIUso+O57VuxZSpMbtDJInanGwz9Q/LVuFLjdtB+lEmzK3+EZxQjhfoJI2Gb7XknlvcLaq49ZDEaPBiGwWZVoyOZZJlJW1WGOvh/W8v9ySg7STljgBjIjVDWdYHkE56WA2Qr9JWU7+etfzkajkpTUmZeLt+vw9+tJ1LAeFy9FVFg5UrukeXQ8Wxv/iF7Zq/Ai9J3kSyxKspAjqK3L14w
X-MS-Exchange-AntiSpam-MessageData: URsz3IY+TSHym8l/j30kncPakL9pAJF/mz9mGdLbMpSb4l557ePsxEqv3NSWSJdy8oor6yBLBtNYf30vT4tgyjFWv+SOBA1VIUGqdbodO9ARWuMLiw0SSC+sGDzRUnp4eM/jy+fXTBj0MuXcrICdOg==
X-OriginatorOrg: toradex.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 278d9382-64a1-4222-a2cc-08d7ccf0f48d
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Mar 2020 17:05:56.5983
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: d9995866-0d9b-4251-8315-093f062abab4
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ahB78RQ356NzzQ96iEtquk68Jw3mjlf6P8ZeyY+Q8L12F0RzBrFllY3lfmo6aDR0IQOw+9vzkOOy5FjVdpBIWSlSI2KNz2JWqd33nEGABWY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB3472
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Mar 20, 2020 at 5:51 PM Tim Harvey <tharvey@gateworks.com> wrote:
>
> On Fri, Mar 20, 2020 at 12:26 AM Marcel Ziswiler
> <marcel.ziswiler@toradex.com> wrote:
> >
> > Hi Tim
> >
> > On Thu, 2020-03-19 at 13:49 -0700, Tim Harvey wrote:
> > > On Thu, Dec 12, 2019 at 4:24 AM Mark Brown <broonie@kernel.org>
> > > wrote:
> > > > On Thu, Dec 12, 2019 at 10:46:31AM +0000, Alison Wang wrote:
> > > >
> > > > > We tested this standard solution using gstreamer and standard
> > > > > ALSA
> > > > > tools like aplay, arecord and all these tools unmute needed
> > > > > blocks
> > > > > successfully.
> > > > > [Alison Wang] I am using aplay. Do you mean I need to add some
> > > > > parameters for aplay or others to unmute the outputs?
> > > >
> > > > Use amixer.
> > >
> > > Marc / Oleksandr,
> > >
> > > I can't seem to find the original patch in my mailbox for 631bc8f:
> > > ('ASoC: sgtl5000: Fix of unmute outputs on probe')
> >
> > I forwarded you that one again. OK?
> >
> > > however I find it
> > > breaks sgtl5000 audio output on the Gateworks boards which is still
> > > broken on 5.6-rc6.
> >
> > What exactly do you mean by "breaks"? Isn't it that you just need to
> > unmute stuff e.g. using amixer or using a proper updated asound.state
> > file with default states for your controls?
>
> the audio device is in /proc/asound/cards but when I send audio to it
> I 'hear' nothing out the normal line-out output.
>
> >
> > > Was there some follow-up patches that haven't made
> > > it into mainline yet regarding this?
> >
> > I don't think so. It all works perfectly, not?
> >
> > > The response above indicates maybe there was an additional ALSA
> > > control perhaps added as a resolution but I don't see any differences
> > > there.
> >
> > Not that I am aware of, no.
> >
>
> The output of 'amixer' shows nothing different than before this patch
> where audio out worked (same controls, same settings on them). I'm
> testing this with a buildroot rootfs with no asound.conf (or at least
> none that I know of... i'm honestly not clear where all they can be).

Tim, did you try to unmute the output with amixer?

Could you provide the output of your amixer with and without this patch?

Before this patch, the driver unmuted HP, LO, and ADC unconditionally
on load (while it just had to set up ZCD bits).
Now HP, LO, ADC remain muted until one unmutes them using standard
ALSA tools/interfaces.
ALSA mute/unmute controls for these outputs have been presenting in
the kernel for a long time. Please, just use them.

>
> Tim
--
Best regards
Oleksandr Suvorov

Toradex AG
Ebenaustrasse 10 | 6048 Horw | Switzerland | T: +41 41 500 48 00