Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] mm/compaction.c: Clean code by removing unnecessary
 assignment
To:     mateusznosek0@gmail.com, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org
Cc:     akpm@linux-foundation.org
References: <20200318174509.15021-1-mateusznosek0@gmail.com>
From:   Vlastimil Babka <vbabka@suse.cz>
Message-ID: <ac3ccec1-4583-91ee-0385-5c162c789804@suse.cz>
Date:   Fri, 20 Mar 2020 18:28:55 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.5.0
MIME-Version: 1.0
In-Reply-To: <20200318174509.15021-1-mateusznosek0@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 3/18/20 6:45 PM, mateusznosek0@gmail.com wrote:
> From: Mateusz Nosek <mateusznosek0@gmail.com>
> 
> Previously 0 was assigned to variable 'last_migrated_pfn'. But the
> variable is not read after that, so the assignment can be removed.
> 
> Signed-off-by: Mateusz Nosek <mateusznosek0@gmail.com>

Acked-by: Vlastimil Babka <vbabka@suse.cz>

> ---
>  mm/compaction.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/mm/compaction.c b/mm/compaction.c
> index 827d8a2b3164..4576d6c5afb5 100644
> --- a/mm/compaction.c
> +++ b/mm/compaction.c
> @@ -2183,7 +2183,6 @@ compact_zone(struct compact_control *cc, struct capture_control *capc)
>  			ret = COMPACT_CONTENDED;
>  			putback_movable_pages(&cc->migratepages);
>  			cc->nr_migratepages = 0;
> -			last_migrated_pfn = 0;
>  			goto out;
>  		case ISOLATE_NONE:
>  			if (update_cached) {
>