Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp1061344ybb; Fri, 20 Mar 2020 12:38:29 -0700 (PDT) X-Google-Smtp-Source: ADFU+vvyY2kAQtGjQYkugwQG4c2VlDWtwGNDty8eVfBAWODTk9ndqQMGwGbXEf4eXXnjp1sj21Le X-Received: by 2002:a9d:6aca:: with SMTP id m10mr8324902otq.116.1584733109252; Fri, 20 Mar 2020 12:38:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584733109; cv=none; d=google.com; s=arc-20160816; b=XD9goaviYeOOSITTjgt1f9xSoS+7tinodsrisSrf8/O717ow15ZWzNwB3d/o7Wjguj kLqOFPDtWoJTvuWJtVNDV73+E4CMMgG2/jSted/0jaWRpYbIlNEXCdLBbXYh6Mo8x2ea bNxKG6kru1NY+m13SjILUThadPHfF3pzlFpuJ10CAvsdpWrOL/v8U0zIg7NqeF7xwL+2 bENI5KjPTV77PTHlxe1bKqEnfVoBPV3jfw3UISuBuR2mZkLEpYEtDLMXavHPk0G2IvPV 6uo2boveFew9U59wbU4vPzmaFCFJRNvepc+tTT12LvVb/2A0PSbOrHMIBhe/XmF4JkP1 8/CQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:message-id:subject:cc:to:from:date :dkim-signature; bh=3NK5Z/VfIboPUp/m+AORj5OPO6jRDA8eO0bMbXBnaac=; b=rlxsTLLf9UHn5qEjtLmgxV9GELP5xUoztAz018DWMAIlIQjL0Jk26iq+ySNtEXGG+q 1T5xqMvJrZ4Dwj8hOwuxWqJzXg/NRQv9BKngbP9Qnid6nuwVDg9HkgHWZOZA4PZ8/aiY W/k+xuKxYT7zx9T+K3/3gy+jRTIfiLai1pHeAOjP1op5YcpVt1rtXBqMeKHaueHEHFKT aRoKnvDEPVVD0Y7Ug2ZGK47qVNF2lDfSBNpyQC6sbP7FDZ2CfSr/IFi8bj34p8W4Vy1a lTJb5mw+ri33dT48e066pn/bdHh2PJgaKMLQYquRnjU/iISNayob7H8V6jKyTebuizIx 7zeg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=KvmFrZ52; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i12si4046768otk.39.2020.03.20.12.38.16; Fri, 20 Mar 2020 12:38:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=KvmFrZ52; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726912AbgCTTh6 (ORCPT + 99 others); Fri, 20 Mar 2020 15:37:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:33516 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726666AbgCTTh6 (ORCPT ); Fri, 20 Mar 2020 15:37:58 -0400 Received: from localhost (mobile-166-175-186-165.mycingular.net [166.175.186.165]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8F6D720777; Fri, 20 Mar 2020 19:37:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584733077; bh=OcAj1mRF3Wt0azKQU+0IX3Ycr8E2bKuEFpGJcAvc+tc=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=KvmFrZ52uZRJi9S5/w+0AuR8CoogezFW41f26E6VQGaGt7YSt3lscU75FgNYsBpL7 t4SynEUArqu65qcKHfHgkkcSId8a5L6gjHa+pL8itdh71BywpSxE2Pz5J4qA+/RdqM c00MY4GD8jii+2ob7HGmrhLyoinGpvm91vg0yXw8= Date: Fri, 20 Mar 2020 14:37:56 -0500 From: Bjorn Helgaas To: Ansuel Smith Cc: Stanimir Varbanov , Sham Muthayyan , Andy Gross , Bjorn Andersson , Rob Herring , Mark Rutland , Lorenzo Pieralisi , Andrew Murray , Philipp Zabel , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 10/12] pcie: qcom: add Force GEN1 support Message-ID: <20200320193756.GA249654@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200320183455.21311-10-ansuelsmth@gmail.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 20, 2020 at 07:34:52PM +0100, Ansuel Smith wrote: > From: Sham Muthayyan > > Add Force GEN1 support needed in some ipq806x board > that needs to limit some pcie line to gen1 for some > hardware limitation Usual commit log comments. > + uint32_t force_gen1; unsigned int force_gen1 : 1 > + of_property_read_u32(np, "force_gen1", &force_gen1); > + pcie->force_gen1 = force_gen1; I think there's a more or less standard property you can use for this instead of inventing a new one specific to this device. Documentation/devicetree/bindings/pci/pci.txt: "max-link-speed"