Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp1071582ybb;
        Fri, 20 Mar 2020 12:50:40 -0700 (PDT)
X-Google-Smtp-Source: ADFU+vubYj+cWPKbiQx8s7+wPC2U5OUuOsFVK2qgVXFlB/2L6duRfJPmK7gze72YjtFic5TAaCx7
X-Received: by 2002:a05:6808:8d4:: with SMTP id k20mr7682514oij.134.1584733839923;
        Fri, 20 Mar 2020 12:50:39 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1584733839; cv=none;
        d=google.com; s=arc-20160816;
        b=ZjPQUUrwg8oh7SQQu+VGzB1c7CnN2qkYf4a7zn0+y+N8NWzW8sA9JpFPT6aTI+k58L
         PrunIQ+LyYziwSBf21b69n5vP/Npy3gX3uEfW32IVDshd/v5lzlopgzonm3qIUCwuDwu
         aLS7R8wM5wZJDJFCW5vFNAD9pl13CvOFRaXh8yD0KaU3gUJNinAZgUbg5VWtO+uYwfFX
         MkeBXfJ7vCdd9gw+y3Mh/oWVMY4dLKL+iolqRTbSaRFcY5geMIfSZpe5ZnPK1V5eiEiA
         NRgyPKPklg8Jmha6mnxRHYO5GgO9zkRF/uF+etgoWtxc/W/rW0a1CBKZBMEc8LTNB8xi
         DbtA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:dkim-signature:content-transfer-encoding
         :content-language:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject;
        bh=eMx7zJHblAy5+YXR6qnBGnBggweRnlFVeODh2DtisrU=;
        b=MONgouje87hSLGNZ7YPGywC+Kg+Rl1ceUsqcnTmeLjd54wE2DU+7c4dMTqqkAgOox7
         w3coiNrVD2h1XiQ6hBFHROaV7U47NdUx+VRDURMjS+rvXmGDdAvA/BAgT8nfgGum4Uie
         7X0im3Y/SgT45+p0BzNajj7nsQdf02BlE2e0ao62np49muEDROFO5BQRDo5d4Jxtcnrd
         0Kaza3YkMCrVH6YshAJqc0JfrhI2WyDetS2Evzwv02AvFlbStlH+/1z/OjcPoOTql4C7
         vwXuOZAV3+tyF0GPovrK590s/nrB8sLHZIlmv5I4G9YdcVrw8Xu+lkitX3Ogtq9SFc6t
         0vjw==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=Tel2JQH6;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id i132si3289419oih.249.2020.03.20.12.50.27;
        Fri, 20 Mar 2020 12:50:39 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=Tel2JQH6;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726980AbgCTTuF (ORCPT <rfc822;linuxbirdgao@gmail.com>
        + 99 others); Fri, 20 Mar 2020 15:50:05 -0400
Received: from hqnvemgate24.nvidia.com ([216.228.121.143]:14131 "EHLO
        hqnvemgate24.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726843AbgCTTuF (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 20 Mar 2020 15:50:05 -0400
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5e751e090004>; Fri, 20 Mar 2020 12:48:25 -0700
Received: from hqmail.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Fri, 20 Mar 2020 12:50:04 -0700
X-PGP-Universal: processed;
        by hqpgpgate101.nvidia.com on Fri, 20 Mar 2020 12:50:04 -0700
Received: from [10.2.57.131] (172.20.13.39) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 20 Mar
 2020 19:50:04 +0000
Subject: Re: [PATCH] x86/mm: Make pud_present() check _PAGE_PROTNONE and
 _PAGE_PSE as well
To:     Anshuman Khandual <anshuman.khandual@arm.com>,
        "Kirill A. Shutemov" <kirill@shutemov.name>
CC:     <linux-mm@kvack.org>, Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Dave Hansen <dave.hansen@intel.com>,
        Andrew Morton <akpm@linux-foundation.org>, <x86@kernel.org>,
        <linux-kernel@vger.kernel.org>,
        Dan Williams <dan.j.williams@intel.com>
References: <1584507679-11976-1-git-send-email-anshuman.khandual@arm.com>
 <c03165c8-6d44-49c2-2dad-a85759200718@arm.com>
 <20200320114741.c62iolt2yzltnscf@box>
 <2e7a04cf-80cb-58c1-7344-2f8422ed7d31@arm.com>
From:   John Hubbard <jhubbard@nvidia.com>
X-Nvconfidentiality: public
Message-ID: <082aae4a-b190-7b54-eda9-0bbc28c8a6b3@nvidia.com>
Date:   Fri, 20 Mar 2020 12:50:03 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.6.0
MIME-Version: 1.0
In-Reply-To: <2e7a04cf-80cb-58c1-7344-2f8422ed7d31@arm.com>
X-Originating-IP: [172.20.13.39]
X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To
 HQMAIL107.nvidia.com (172.20.187.13)
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1584733705; bh=eMx7zJHblAy5+YXR6qnBGnBggweRnlFVeODh2DtisrU=;
        h=X-PGP-Universal:Subject:To:CC:References:From:X-Nvconfidentiality:
         Message-ID:Date:User-Agent:MIME-Version:In-Reply-To:
         X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language:
         Content-Transfer-Encoding;
        b=Tel2JQH66ScF35HhrWYTgNQPP1AMRuVM4bvqwSSCBmgG15W1HzJ865N1Qi6NhkqsQ
         woGCQZujdfF6ZIip99vvJBaU5dDWbVtk8VH6TrI7rQ9NbZef+wNBXpkIRTVF22NV5O
         DdiyvOMXxmjF10pBRS25AJ0le5iUdr8U4HqAZQ1+mEp9OAH/lpnYZm8jqp0jtIKX8y
         31/DhZyGPocZEe/XRi/zCkNQvP208imeKhlFzHwR1bTNk6xXX8xx/6zjJgtBRpjYV3
         +um0XPIw+9MhAznV0GwYZZG9146hF/ek7V/WsEFcK+FNqBWLrJ3hk7tFHVapD37Wd0
         NJivdmuFNik6Q==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 3/20/20 6:22 AM, Anshuman Khandual wrote:
...
>>> +Cc: Kirill A. Shutemov <kirill@shutemov.name>
>>> +Cc: Dan Williams <dan.j.williams@intel.com>
>>
>> Or we can just drop the pud_mknotpresent(). There's no users AFAICS and
>> only x86 provides it.

+1

> 
> Yes that will be an option but IMHO fixing pud_present() here might be
> a better choice because,
> 
> (1) pud_mknotpresent() with fixed pud_present() might be required later


It might. Or it might not. Let's wait until it's actually used, and see.
Dead code is an avoidable expense (adds size, space on the screen, email
traffic and other wasted time), so let's avoid it here.


> (2) PMD & PUD will be exact same (THP is supported on either level)
> 
> Nonetheless, I am happy to go either way.
> 


thanks,
-- 
John Hubbard
NVIDIA