Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp1124001ybb; Fri, 20 Mar 2020 13:51:21 -0700 (PDT) X-Google-Smtp-Source: ADFU+vvaq0Aqvm3RiowNMqpTa62u9GPUafZH0d9ckxzcoBaaGe5bxOsjczNyy8/PXYLvw0+p73iB X-Received: by 2002:aca:3b41:: with SMTP id i62mr7933679oia.55.1584737481142; Fri, 20 Mar 2020 13:51:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584737481; cv=none; d=google.com; s=arc-20160816; b=IALEzqv6iiuSp7Ios3l03miu+RWi49xBOvQJvx4spLoZmyb5r9QZIRK/eVcl0/7yKK HffK/LflAgl7oGaXp1sXjoTV3cgGa4Yls9ZZjkw0APOO+Mn1TDnJT3K8pmjeEmIA899T b4f0MSsdUeh/JUi6WoMDnOu+zS09rw9V00GMlkUi9ljUIIZJNI1NSE9zRN2wJE336rUV WtCdTAq840ubKhMIT7IUTno2hkHr0QSm1p88hBH2V6gIdkwMX0wIwM9cYqsY6LNveVsi qWlYjtQ1UDb7wKPVyUyUUq3GGSZpX6sXcrVhgJgDIQLOObFomNS+RnJRahNESgl5Mnt8 5jhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=2+vAPjXfaqfXfru5EB1RhBbhM5aIQPKkBp8ruOdA7zg=; b=uWVOp1choZmeB6nhlz8ROQRYZAg1txCT0rULVahEmRu5QeMv+acTbn29B2uFdPP7gl hO6vp/Dmj6oP+rV7/cTFZ9NlyTwxhP2njcHuM2qOwZWyfy9QjFmMny93xYev2p3X2J3t BskIp0gG80uwdHCfTNCpvTjumfNezMScooSaDI/46vMiLIz/4tvXJ5/G7RA76ju13LPK 1/T5Cb3B6EyFpc73lKNRdAOF3tvkNJpTpPuyg0jZnC1rv8iYV9aZkZShAJav8N5jDebk NFP25Mv5o8byGg/rmzsOUEtcb4cN/cGoRnPYQJveZqpvD4hv7zvHfraKasSUtxtKJIuI CesA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=vmware.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j84si3526112oia.126.2020.03.20.13.51.08; Fri, 20 Mar 2020 13:51:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=vmware.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726951AbgCTUuF (ORCPT + 99 others); Fri, 20 Mar 2020 16:50:05 -0400 Received: from ex13-edg-ou-002.vmware.com ([208.91.0.190]:35623 "EHLO EX13-EDG-OU-002.vmware.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726738AbgCTUuF (ORCPT ); Fri, 20 Mar 2020 16:50:05 -0400 X-Greylist: delayed 902 seconds by postgrey-1.27 at vger.kernel.org; Fri, 20 Mar 2020 16:50:04 EDT Received: from sc9-mailhost2.vmware.com (10.113.161.72) by EX13-EDG-OU-002.vmware.com (10.113.208.156) with Microsoft SMTP Server id 15.0.1156.6; Fri, 20 Mar 2020 13:34:57 -0700 Received: from localhost.localdomain (unknown [10.118.101.94]) by sc9-mailhost2.vmware.com (Postfix) with ESMTP id 3E4F8B1D85; Fri, 20 Mar 2020 16:35:01 -0400 (EDT) From: Alexey Makhalov To: CC: , Jonathan Corbet , "Thomas Gleixner" , Ingo Molnar , "Borislav Petkov" , "H . Peter Anvin" , "Mauro Carvalho Chehab" , Josh Poimboeuf , Greg Kroah-Hartman , Pawan Gupta , Juergen Gross , "Alexey Makhalov" Subject: [PATCH 4/5] x86/vmware: Enable steal time accounting Date: Fri, 20 Mar 2020 20:34:42 +0000 Message-ID: <20200320203443.27742-5-amakhalov@vmware.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20200320203443.27742-1-amakhalov@vmware.com> References: <20200320203443.27742-1-amakhalov@vmware.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: None (EX13-EDG-OU-002.vmware.com: amakhalov@vmware.com does not designate permitted sender hosts) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Set paravirt_steal_rq_enabled if steal clock present. paravirt_steal_rq_enabled is used in sched/core.c to adjust task progress by offsetting stolen time. Use 'no-steal-acc' off switch (share same name with KVM) to disable steal time accounting. Signed-off-by: Alexey Makhalov Reviewed-by: Thomas Hellstrom --- Documentation/admin-guide/kernel-parameters.txt | 2 +- arch/x86/kernel/cpu/vmware.c | 13 ++++++++++++- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt index 87176a90e61a..07fbdccdd77c 100644 --- a/Documentation/admin-guide/kernel-parameters.txt +++ b/Documentation/admin-guide/kernel-parameters.txt @@ -3152,7 +3152,7 @@ [X86,PV_OPS] Disable paravirtualized VMware scheduler clock and use the default one. - no-steal-acc [X86,KVM,ARM64] Disable paravirtualized steal time + no-steal-acc [X86,PV_OPS,ARM64] Disable paravirtualized steal time accounting. steal time is computed, but won't influence scheduler behaviour diff --git a/arch/x86/kernel/cpu/vmware.c b/arch/x86/kernel/cpu/vmware.c index 59459992ad47..0c65d661d88b 100644 --- a/arch/x86/kernel/cpu/vmware.c +++ b/arch/x86/kernel/cpu/vmware.c @@ -125,6 +125,7 @@ static struct cyc2ns_data vmware_cyc2ns __ro_after_init; static int vmw_sched_clock __initdata = 1; static DEFINE_PER_CPU_DECRYPTED(struct vmware_steal_time, steal_time) __aligned(64); static bool has_steal_clock; +static bool steal_acc __initdata = true; /* steal time accounting */ static __init int setup_vmw_sched_clock(char *s) { @@ -133,6 +134,13 @@ static __init int setup_vmw_sched_clock(char *s) } early_param("no-vmw-sched-clock", setup_vmw_sched_clock); +static __init int parse_no_stealacc(char *arg) +{ + steal_acc = false; + return 0; +} +early_param("no-steal-acc", parse_no_stealacc); + static unsigned long long notrace vmware_sched_clock(void) { unsigned long long ns; @@ -306,8 +314,11 @@ static int vmware_cpu_down_prepare(unsigned int cpu) static __init int activate_jump_labels(void) { - if (has_steal_clock) + if (has_steal_clock) { static_key_slow_inc(¶virt_steal_enabled); + if (steal_acc) + static_key_slow_inc(¶virt_steal_rq_enabled); + } return 0; } -- 2.14.2