Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191212071847.45561-1-alison.wang@nxp.com> <CAGgjyvHHzPWjRTqxYmGCmk3qa6=kOezHywVDFomgD6UNj-zwpQ@mail.gmail.com>
 <VI1PR04MB40627CDD5F0C17D8DCDCFFE2F4550@VI1PR04MB4062.eurprd04.prod.outlook.com>
 <VI1PR04MB4062C67906888DA8142C17E1F4550@VI1PR04MB4062.eurprd04.prod.outlook.com>
 <CAGgjyvGAjx1SV=K66AM24DxMTA_sAF2uhhDw5gXCFTGNZi8E7Q@mail.gmail.com>
 <VI1PR04MB40620DD55D5ED0FDC3E94C2BF4550@VI1PR04MB4062.eurprd04.prod.outlook.com>
 <20191212122318.GB4310@sirena.org.uk> <CAJ+vNU0xZOb0R2VNkq6k3efdkgQUtO_-cEdNgZ643nt_G=vevQ@mail.gmail.com>
 <af99c9abd9c2aec6a074fb05310c56b780725ebd.camel@toradex.com>
 <CAJ+vNU16ax9JTx2kSMUF8SiVD-+4KGoFO-U07xM5eE=T6Fwjhw@mail.gmail.com> <CAGgjyvFNCbFw7x6QL063oi-fV2UuVQVfL1cv_pQ74HWoJS4Etg@mail.gmail.com>
In-Reply-To: <CAGgjyvFNCbFw7x6QL063oi-fV2UuVQVfL1cv_pQ74HWoJS4Etg@mail.gmail.com>
From:   Tim Harvey <tharvey@gateworks.com>
Date:   Fri, 20 Mar 2020 15:51:05 -0700
Message-ID: <CAJ+vNU3h1-tJT-KnyaCHj9wvXzdpDyWfvgTSGYLqU8OrzGXv6g@mail.gmail.com>
Subject: Re: [alsa-devel] [EXT] Re: [PATCH] ASoC: sgtl5000: Revert "ASoC:
 sgtl5000: Fix of unmute outputs on probe"
To:     Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
Cc:     Marcel Ziswiler <marcel.ziswiler@toradex.com>,
        "broonie@kernel.org" <broonie@kernel.org>,
        "alison.wang@nxp.com" <alison.wang@nxp.com>,
        "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
        "festevam@gmail.com" <festevam@gmail.com>,
        Igor Opanyuk <igor.opanyuk@toradex.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Mar 20, 2020 at 10:06 AM Oleksandr Suvorov
<oleksandr.suvorov@toradex.com> wrote:
>
> On Fri, Mar 20, 2020 at 5:51 PM Tim Harvey <tharvey@gateworks.com> wrote:
> >
> > On Fri, Mar 20, 2020 at 12:26 AM Marcel Ziswiler
> > <marcel.ziswiler@toradex.com> wrote:
> > >
> > > Hi Tim
> > >
> > > On Thu, 2020-03-19 at 13:49 -0700, Tim Harvey wrote:
> > > > On Thu, Dec 12, 2019 at 4:24 AM Mark Brown <broonie@kernel.org>
> > > > wrote:
> > > > > On Thu, Dec 12, 2019 at 10:46:31AM +0000, Alison Wang wrote:
> > > > >
> > > > > > We tested this standard solution using gstreamer and standard
> > > > > > ALSA
> > > > > > tools like aplay, arecord and all these tools unmute needed
> > > > > > blocks
> > > > > > successfully.
> > > > > > [Alison Wang] I am using aplay. Do you mean I need to add some
> > > > > > parameters for aplay or others to unmute the outputs?
> > > > >
> > > > > Use amixer.
> > > >
> > > > Marc / Oleksandr,
> > > >
> > > > I can't seem to find the original patch in my mailbox for 631bc8f:
> > > > ('ASoC: sgtl5000: Fix of unmute outputs on probe')
> > >
> > > I forwarded you that one again. OK?
> > >
> > > > however I find it
> > > > breaks sgtl5000 audio output on the Gateworks boards which is still
> > > > broken on 5.6-rc6.
> > >
> > > What exactly do you mean by "breaks"? Isn't it that you just need to
> > > unmute stuff e.g. using amixer or using a proper updated asound.state
> > > file with default states for your controls?
> >
> > the audio device is in /proc/asound/cards but when I send audio to it
> > I 'hear' nothing out the normal line-out output.
> >
> > >
> > > > Was there some follow-up patches that haven't made
> > > > it into mainline yet regarding this?
> > >
> > > I don't think so. It all works perfectly, not?
> > >
> > > > The response above indicates maybe there was an additional ALSA
> > > > control perhaps added as a resolution but I don't see any differences
> > > > there.
> > >
> > > Not that I am aware of, no.
> > >
> >
> > The output of 'amixer' shows nothing different than before this patch
> > where audio out worked (same controls, same settings on them). I'm
> > testing this with a buildroot rootfs with no asound.conf (or at least
> > none that I know of... i'm honestly not clear where all they can be).
>
> Tim, did you try to unmute the output with amixer?
>
> Could you provide the output of your amixer with and without this patch?
>
> Before this patch, the driver unmuted HP, LO, and ADC unconditionally
> on load (while it just had to set up ZCD bits).
> Now HP, LO, ADC remain muted until one unmutes them using standard
> ALSA tools/interfaces.
> ALSA mute/unmute controls for these outputs have been presenting in
> the kernel for a long time. Please, just use them.
>

Oleksandr,

When I first bisected to this I must have done something wrong as I
thought amixer settings showed the same before and after - I see that
I'm wrong about that. I see the differences now with HP, LO, and ADC
muted by default. I agree using amixer controls is fine.

Sorry for the noise!

Tim