Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp1242845ybb; Fri, 20 Mar 2020 16:22:57 -0700 (PDT) X-Google-Smtp-Source: ADFU+vtGtMDPj97JfrOGR9rXRUwaZmkBRO87cNdfLVUe8mGNGhgXaPgHQXtULgYDf73YiFX7kxfk X-Received: by 2002:a05:6830:1c77:: with SMTP id s23mr9058262otg.191.1584746577272; Fri, 20 Mar 2020 16:22:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584746577; cv=none; d=google.com; s=arc-20160816; b=i1bZ/duoDLea3IVpQnivNDqLONsZH1j3yJ+p5iOdUorkRA3krA2yefCKS4ZzWidXIz SjZ/x6ZnYz60NuYv9DK70pm5tisIrm1P9675y8gMkWRy4q0QNALkV9ZEM/hVKanfzrJX fwn9/STSu18RbDfpAZdAcHq+F1P4LXBtoRm0aFV7C+uTuL3wBej1k6lIi2CZtLFy5elN QCl+gH2dtRAe2xGZRU6eV44CXWbDal7qDzE4fGhFGYhF5BZQH6yhgyj17mRbzA8/Mv+j QtpC2pJQCYKFIgftSPLul3gUB6DMsEuUxHHmQ9zaLTAr92GVFN55b1BF2GNQp5kw4tJK t2eQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:ironport-sdr:ironport-sdr; bh=NeptdnIDSkex6d+QCAIYr+TP1cd3hyo5Q5lpHaVFoXk=; b=zdBe1oUg+9BFdxva8lpe42n9zKSQV1s57E++ai2HcwJKw0psJ77nJ7AOScEXuKJ8lF U2a08vWWhh6Rqh/aholVTIuR1hxVRdinr8L8Hs1hcrsxKyNq64ZgN2F2nsKhN4+MUF5n 8UPPSTtZrc2IlyKUwzr8U9FHHSIWJe0xYSocHDY3yR00Bh4CJL7Yg1xG5cwvLRkERGl7 x2TraXgS9+UhxckUI5y5dGgUw6APy+SZvA+cb3gZ/XFOA07mO0CE6OjV8Cmdox1+C+sR ajNKq/JedFWrhD0Y6JOnSWCuXJh+wWFTEUHUrbSKr/FAm/TKte+eFsbswqaiLkdqbkJC B0tw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x79si3195659oif.180.2020.03.20.16.22.44; Fri, 20 Mar 2020 16:22:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727672AbgCTXWJ (ORCPT + 99 others); Fri, 20 Mar 2020 19:22:09 -0400 Received: from mga18.intel.com ([134.134.136.126]:42258 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726738AbgCTXWF (ORCPT ); Fri, 20 Mar 2020 19:22:05 -0400 IronPort-SDR: DCJijdjhTEv7e4OqDsKKKVb/BnQVdKqLeVSBqGYawOJc6rWvF3bn9C3hEHdy4XtESSJcxQIoWf TTF4f2MwpT9g== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Mar 2020 16:22:01 -0700 IronPort-SDR: 4SDwQS1DPGZCacbhYKK30hVUNTillBiN7/si/anNg6p1qlnrxlsVlf5ij19abm7ilwCR7k5+sI 97YRapIyQFXA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,286,1580803200"; d="scan'208";a="418877249" Received: from jacob-builder.jf.intel.com ([10.7.199.155]) by orsmga005.jf.intel.com with ESMTP; 20 Mar 2020 16:22:01 -0700 From: Jacob Pan To: "Lu Baolu" , iommu@lists.linux-foundation.org, LKML , Joerg Roedel , David Woodhouse , Alex Williamson , Jean-Philippe Brucker Cc: "Yi Liu" , "Tian, Kevin" , Raj Ashok , "Christoph Hellwig" , Jonathan Cameron , Eric Auger , Jacob Pan , Liu@vger.kernel.org Subject: [PATCH V10 08/11] iommu/vt-d: Add svm/sva invalidate function Date: Fri, 20 Mar 2020 16:27:38 -0700 Message-Id: <1584746861-76386-9-git-send-email-jacob.jun.pan@linux.intel.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1584746861-76386-1-git-send-email-jacob.jun.pan@linux.intel.com> References: <1584746861-76386-1-git-send-email-jacob.jun.pan@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When Shared Virtual Address (SVA) is enabled for a guest OS via vIOMMU, we need to provide invalidation support at IOMMU API and driver level. This patch adds Intel VT-d specific function to implement iommu passdown invalidate API for shared virtual address. The use case is for supporting caching structure invalidation of assigned SVM capable devices. Emulated IOMMU exposes queue invalidation capability and passes down all descriptors from the guest to the physical IOMMU. The assumption is that guest to host device ID mapping should be resolved prior to calling IOMMU driver. Based on the device handle, host IOMMU driver can replace certain fields before submit to the invalidation queue. --- v7 review fixed in v10 --- Signed-off-by: Jacob Pan Signed-off-by: Ashok Raj Signed-off-by: Liu, Yi L --- drivers/iommu/intel-iommu.c | 182 ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 182 insertions(+) diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c index b1477cd423dd..a76afb0fd51a 100644 --- a/drivers/iommu/intel-iommu.c +++ b/drivers/iommu/intel-iommu.c @@ -5619,6 +5619,187 @@ static void intel_iommu_aux_detach_device(struct iommu_domain *domain, aux_domain_remove_dev(to_dmar_domain(domain), dev); } +/* + * 2D array for converting and sanitizing IOMMU generic TLB granularity to + * VT-d granularity. Invalidation is typically included in the unmap operation + * as a result of DMA or VFIO unmap. However, for assigned devices guest + * owns the first level page tables. Invalidations of translation caches in the + * guest are trapped and passed down to the host. + * + * vIOMMU in the guest will only expose first level page tables, therefore + * we do not include IOTLB granularity for request without PASID (second level). + * + * For example, to find the VT-d granularity encoding for IOTLB + * type and page selective granularity within PASID: + * X: indexed by iommu cache type + * Y: indexed by enum iommu_inv_granularity + * [IOMMU_CACHE_INV_TYPE_IOTLB][IOMMU_INV_GRANU_ADDR] + * + * Granu_map array indicates validity of the table. 1: valid, 0: invalid + * + */ +const static int inv_type_granu_map[IOMMU_CACHE_INV_TYPE_NR][IOMMU_INV_GRANU_NR] = { + /* + * PASID based IOTLB invalidation: PASID selective (per PASID), + * page selective (address granularity) + */ + {0, 1, 1}, + /* PASID based dev TLBs, only support all PASIDs or single PASID */ + {1, 1, 0}, + /* PASID cache */ + {1, 1, 0} +}; + +const static int inv_type_granu_table[IOMMU_CACHE_INV_TYPE_NR][IOMMU_INV_GRANU_NR] = { + /* PASID based IOTLB */ + {0, QI_GRAN_NONG_PASID, QI_GRAN_PSI_PASID}, + /* PASID based dev TLBs */ + {QI_DEV_IOTLB_GRAN_ALL, QI_DEV_IOTLB_GRAN_PASID_SEL, 0}, + /* PASID cache */ + {QI_PC_ALL_PASIDS, QI_PC_PASID_SEL, 0}, +}; + +static inline int to_vtd_granularity(int type, int granu, int *vtd_granu) +{ + if (type >= IOMMU_CACHE_INV_TYPE_NR || granu >= IOMMU_INV_GRANU_NR || + !inv_type_granu_map[type][granu]) + return -EINVAL; + + *vtd_granu = inv_type_granu_table[type][granu]; + + return 0; +} + +static inline u64 to_vtd_size(u64 granu_size, u64 nr_granules) +{ + u64 nr_pages = (granu_size * nr_granules) >> VTD_PAGE_SHIFT; + + /* VT-d size is encoded as 2^size of 4K pages, 0 for 4k, 9 for 2MB, etc. + * IOMMU cache invalidate API passes granu_size in bytes, and number of + * granu size in contiguous memory. + */ + return order_base_2(nr_pages); +} + +#ifdef CONFIG_INTEL_IOMMU_SVM +static int intel_iommu_sva_invalidate(struct iommu_domain *domain, + struct device *dev, struct iommu_cache_invalidate_info *inv_info) +{ + struct dmar_domain *dmar_domain = to_dmar_domain(domain); + struct device_domain_info *info; + struct intel_iommu *iommu; + unsigned long flags; + int cache_type; + u8 bus, devfn; + u16 did, sid; + int ret = 0; + u64 size = 0; + + if (!inv_info || !dmar_domain || + inv_info->version != IOMMU_CACHE_INVALIDATE_INFO_VERSION_1) + return -EINVAL; + + if (!dev || !dev_is_pci(dev)) + return -ENODEV; + + iommu = device_to_iommu(dev, &bus, &devfn); + if (!iommu) + return -ENODEV; + + spin_lock_irqsave(&device_domain_lock, flags); + spin_lock(&iommu->lock); + info = iommu_support_dev_iotlb(dmar_domain, iommu, bus, devfn); + if (!info) { + ret = -EINVAL; + goto out_unlock; + } + did = dmar_domain->iommu_did[iommu->seq_id]; + sid = PCI_DEVID(bus, devfn); + + /* Size is only valid in non-PASID selective invalidation */ + if (inv_info->granularity != IOMMU_INV_GRANU_PASID) + size = to_vtd_size(inv_info->addr_info.granule_size, + inv_info->addr_info.nb_granules); + + for_each_set_bit(cache_type, (unsigned long *)&inv_info->cache, IOMMU_CACHE_INV_TYPE_NR) { + int granu = 0; + u64 pasid = 0; + + ret = to_vtd_granularity(cache_type, inv_info->granularity, &granu); + if (ret) { + pr_err("Invalid cache type and granu combination %d/%d\n", cache_type, + inv_info->granularity); + break; + } + + /* PASID is stored in different locations based on granularity */ + if (inv_info->granularity == IOMMU_INV_GRANU_PASID && + inv_info->pasid_info.flags & IOMMU_INV_PASID_FLAGS_PASID) + pasid = inv_info->pasid_info.pasid; + else if (inv_info->granularity == IOMMU_INV_GRANU_ADDR && + inv_info->addr_info.flags & IOMMU_INV_ADDR_FLAGS_PASID) + pasid = inv_info->addr_info.pasid; + else { + pr_err("Cannot find PASID for given cache type and granularity\n"); + break; + } + + switch (BIT(cache_type)) { + case IOMMU_CACHE_INV_TYPE_IOTLB: + if ((inv_info->granularity != IOMMU_INV_GRANU_PASID) && + size && (inv_info->addr_info.addr & ((BIT(VTD_PAGE_SHIFT + size)) - 1))) { + pr_err("Address out of range, 0x%llx, size order %llu\n", + inv_info->addr_info.addr, size); + ret = -ERANGE; + goto out_unlock; + } + + qi_flush_piotlb(iommu, did, + pasid, + mm_to_dma_pfn(inv_info->addr_info.addr), + (granu == QI_GRAN_NONG_PASID) ? -1 : 1 << size, + inv_info->addr_info.flags & IOMMU_INV_ADDR_FLAGS_LEAF); + + /* + * Always flush device IOTLB if ATS is enabled since guest + * vIOMMU exposes CM = 1, no device IOTLB flush will be passed + * down. + */ + if (info->ats_enabled) { + qi_flush_dev_iotlb_pasid(iommu, sid, info->pfsid, + pasid, info->ats_qdep, + inv_info->addr_info.addr, size, + granu); + } + break; + case IOMMU_CACHE_INV_TYPE_DEV_IOTLB: + if (info->ats_enabled) { + qi_flush_dev_iotlb_pasid(iommu, sid, info->pfsid, + inv_info->addr_info.pasid, info->ats_qdep, + inv_info->addr_info.addr, size, + granu); + } else + pr_warn("Passdown device IOTLB flush w/o ATS!\n"); + + break; + case IOMMU_CACHE_INV_TYPE_PASID: + qi_flush_pasid_cache(iommu, did, granu, inv_info->pasid_info.pasid); + + break; + default: + dev_err(dev, "Unsupported IOMMU invalidation type %d\n", + cache_type); + ret = -EINVAL; + } + } +out_unlock: + spin_unlock(&iommu->lock); + spin_unlock_irqrestore(&device_domain_lock, flags); + + return ret; +} +#endif + static int intel_iommu_map(struct iommu_domain *domain, unsigned long iova, phys_addr_t hpa, size_t size, int iommu_prot, gfp_t gfp) @@ -6204,6 +6385,7 @@ const struct iommu_ops intel_iommu_ops = { .is_attach_deferred = intel_iommu_is_attach_deferred, .pgsize_bitmap = INTEL_IOMMU_PGSIZES, #ifdef CONFIG_INTEL_IOMMU_SVM + .cache_invalidate = intel_iommu_sva_invalidate, .sva_bind_gpasid = intel_svm_bind_gpasid, .sva_unbind_gpasid = intel_svm_unbind_gpasid, #endif -- 2.7.4